RE: [EXTERNAL] Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio power
> > > pm_runtime handles sdio power on and power off transitions. > > An old workaround for trying to control the power explicitly from the > > driver was in fact causing failures on suspend/resume as the mmc layer > > already power the module on resume. > > > > In case of resume pm_runtime_get sync returns a positive device's usage > > count causing the driver to try an re-initialize an already initialized > > device. This was causing sdio bus failure on resume. > > > > Remove this manual power on/off sequence as it is in-fact not needed. > > > > Signed-off-by: Eyal Reizer > > Acked-by: Tony Lindgren > > No changelog. > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingp > atches#changelog_missing > > No need to resubmit because of this, I guess you just fixed the title > and added Tony's Acked-by? Yes, this is correct. No change in the actual patch hence there was no change Log. Best Regards, Eyal
Re: [EXTERNAL] Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio power
"Reizer, Eyal" writes: >> >> > pm_runtime handles sdio power on and power off transitions. >> > An old workaround for trying to control the power explicitly from the >> > driver was in fact causing failures on suspend/resume as the mmc layer >> > already power the module on resume. >> > >> > In case of resume pm_runtime_get sync returns a positive device's usage >> > count causing the driver to try an re-initialize an already initialized >> > device. This was causing sdio bus failure on resume. >> > >> > Remove this manual power on/off sequence as it is in-fact not needed. >> > >> > Signed-off-by: Eyal Reizer >> > Acked-by: Tony Lindgren >> >> No changelog. >> >> https://wireless.wiki.kernel.org/en/developers/documentation/submittingp >> atches#changelog_missing >> >> No need to resubmit because of this, I guess you just fixed the title >> and added Tony's Acked-by? > > Yes, this is correct. No change in the actual patch hence there was no change > Log. _Always_ include a change log, even if you didn't actually change anything. Otherwise the maintainer has no clue what has changed and why a new version was submitted. -- Kalle Valo
RE: [EXTERNAL] Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio power
> > >> > >> > pm_runtime handles sdio power on and power off transitions. > >> > An old workaround for trying to control the power explicitly from the > >> > driver was in fact causing failures on suspend/resume as the mmc layer > >> > already power the module on resume. > >> > > >> > In case of resume pm_runtime_get sync returns a positive device's > usage > >> > count causing the driver to try an re-initialize an already initialized > >> > device. This was causing sdio bus failure on resume. > >> > > >> > Remove this manual power on/off sequence as it is in-fact not needed. > >> > > >> > Signed-off-by: Eyal Reizer > >> > Acked-by: Tony Lindgren > >> > >> No changelog. > >> > >> > https://wireless.wiki.kernel.org/en/developers/documentation/submittingp > >> atches#changelog_missing > >> > >> No need to resubmit because of this, I guess you just fixed the title > >> and added Tony's Acked-by? > > > > Yes, this is correct. No change in the actual patch hence there was no > change > > Log. > > _Always_ include a change log, even if you didn't actually change > anything. Otherwise the maintainer has no clue what has changed and why > a new version was submitted. > Understood. Thanks! BR, Eyal