Re: [PATCH] NFC: fdp: Remove __func__ parameter from dev_dbg() call

2018-05-02 Thread Greg KH 
On Wed, May 02, 2018 at 08:59:28PM +0300, Andy Shevchenko wrote:
> On Wed, 2018-05-02 at 23:19 +0530, Amit Pundir wrote:
> 
> > -   dev_dbg(dev, "%s\n", __func__);
> > +   dev_dbg(dev, "\n");
> 
> If one enables function tracer this will be redundant completely. 

Yes those kinds of "trace" debug log messages should be just deleted.

Re: [PATCH] NFC: fdp: Remove __func__ parameter from dev_dbg() call

2018-05-02 Thread Andy Shevchenko 
On Wed, 2018-05-02 at 23:19 +0530, Amit Pundir wrote:

> - dev_dbg(dev, "%s\n", __func__);
> + dev_dbg(dev, "\n");

If one enables function tracer this will be redundant completely. 

-- 
Andy Shevchenko 
Intel Finland Oy