Re: [PATCH] net: wireless: rtlwifi: btcoexist: halbtc8821a2ant: Remove some unused functions
Hi All Yes I use sed as Julian said. I have it as part of my git send-email script, until a few week ago, it was enough that I removed the drivers/ and changed all / to : I have now been expanded my sed pipe a lot (tell me if anyone is interested). But a real script to do this would have been very good I think! It may be, there was some mail problems during the holiday season :-( There is not a total consensus on how patcher will was designed. I have previously received complaints that I made for large patches of too many files. Have since tried to make small patches, and it also fit better to have more specific paths in the subject line. But I'll try to gather all in one patchset instead this weekend. Kind regards Rickard Strandqvist 2015-01-06 19:14 GMT+01:00 Kalle Valo kv...@codeaurora.org: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se writes: Removes some functions that are not used anywhere: ex_halbtc8821a2ant_periodical() ex_halbtc8821a2ant_halt_notify() ex_halbtc8821a2ant_bt_info_notify() ex_halbtc8821a2ant_special_packet_notify() ex_halbtc8821a2ant_connect_notify() ex_halbtc8821a2ant_scan_notify() ex_halbtc8821a2ant_lps_notify() ex_halbtc8821a2ant_ips_notify() ex_halbtc8821a2ant_display_coex_info() ex_halbtc8821a2ant_init_coex_dm() ex_halbtc8821a2ant_init_hwconfig() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Rickard, I have dropped all your patches because I lost track which I should apply and which not and I do not want to waste half an hour figuring out. Please resend the ones which are still valid. And to make it easier for everyone please group these wireless-drivers cleanup patches into a larger patchset (like 10-15 patches max per patchset). That way it's a lot easier for me tomanage them. Sending one patch a day is not recommended, especially when we are talking trivial cleanup patches like this. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: wireless: rtlwifi: btcoexist: halbtc8821a2ant: Remove some unused functions
Rickard Strandqvist rickard_strandqv...@spectrumdigital.se writes: Removes some functions that are not used anywhere: ex_halbtc8821a2ant_periodical() ex_halbtc8821a2ant_halt_notify() ex_halbtc8821a2ant_bt_info_notify() ex_halbtc8821a2ant_special_packet_notify() ex_halbtc8821a2ant_connect_notify() ex_halbtc8821a2ant_scan_notify() ex_halbtc8821a2ant_lps_notify() ex_halbtc8821a2ant_ips_notify() ex_halbtc8821a2ant_display_coex_info() ex_halbtc8821a2ant_init_coex_dm() ex_halbtc8821a2ant_init_hwconfig() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Rickard, I have dropped all your patches because I lost track which I should apply and which not and I do not want to waste half an hour figuring out. Please resend the ones which are still valid. And to make it easier for everyone please group these wireless-drivers cleanup patches into a larger patchset (like 10-15 patches max per patchset). That way it's a lot easier for me tomanage them. Sending one patch a day is not recommended, especially when we are talking trivial cleanup patches like this. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: wireless: rtlwifi: btcoexist: halbtc8821a2ant: Remove some unused functions
On 01/03/2015 06:03 AM, Rickard Strandqvist wrote: 2015-01-03 7:05 GMT+01:00 Larry Finger larry.fin...@lwfinger.net: On 01/02/2015 02:26 PM, Rickard Strandqvist wrote: Removes some functions that are not used anywhere: ex_halbtc8821a2ant_periodical() ex_halbtc8821a2ant_halt_notify() ex_halbtc8821a2ant_bt_info_notify() ex_halbtc8821a2ant_special_packet_notify() ex_halbtc8821a2ant_connect_notify() ex_halbtc8821a2ant_scan_notify() ex_halbtc8821a2ant_lps_notify() ex_halbtc8821a2ant_ips_notify() ex_halbtc8821a2ant_display_coex_info() ex_halbtc8821a2ant_init_coex_dm() ex_halbtc8821a2ant_init_hwconfig() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqvist@ spectrumdigital.se I know that you have been told that including net: wireless: in the subject line is discouraged. Please do not do this again. The staging directory is different as GregKH uses staging: in the subject to route patches, but wireless does not. As to the patch, NACK for the simple reason that I am currently working on a number of changes to btcoexist. Some of these routines may end up being removed, but others will not. Having your patch remove them, and one of mine adding them back just constitutes a lot of churning of the source. In addition, it greatly increases the probability of the source trees becoming unsynchronized and getting merge conflicts. Larry Hi Larry I do not recognize that there has been no diskution on the subject of net: wireless: I use some sed call for this, so it's easy to fix. You want the net: wireless: part completely erased then? I check in Documentation/ but find any clear info for this. Sorry for the patch, is there any way for me to see that this is something that is being worked on? These patches are the result of private communications between the Realtek engineers and me. The only publication is in the rock branch of the git repo at http://github.com/lwfinger/rtlwifi_new.git. I do not understand the use of some 'sed' call. If you edit the source and add it to the git repo with the add and commit operations, then format-patch gives you exactly what you need, and send-email does that operation. Larry -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: wireless: rtlwifi: btcoexist: halbtc8821a2ant: Remove some unused functions
Hi Larry, On Mon, Jan 5, 2015 at 12:45 PM, Larry Finger larry.fin...@lwfinger.net wrote: On 01/03/2015 06:03 AM, Rickard Strandqvist wrote: 2015-01-03 7:05 GMT+01:00 Larry Finger larry.fin...@lwfinger.net: On 01/02/2015 02:26 PM, Rickard Strandqvist wrote: Removes some functions that are not used anywhere: ex_halbtc8821a2ant_periodical() ex_halbtc8821a2ant_halt_notify() ex_halbtc8821a2ant_bt_info_notify() ex_halbtc8821a2ant_special_packet_notify() ex_halbtc8821a2ant_connect_notify() ex_halbtc8821a2ant_scan_notify() ex_halbtc8821a2ant_lps_notify() ex_halbtc8821a2ant_ips_notify() ex_halbtc8821a2ant_display_coex_info() ex_halbtc8821a2ant_init_coex_dm() ex_halbtc8821a2ant_init_hwconfig() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqvist@ spectrumdigital.se I know that you have been told that including net: wireless: in the subject line is discouraged. Please do not do this again. The staging directory is different as GregKH uses staging: in the subject to route patches, but wireless does not. As to the patch, NACK for the simple reason that I am currently working on a number of changes to btcoexist. Some of these routines may end up being removed, but others will not. Having your patch remove them, and one of mine adding them back just constitutes a lot of churning of the source. In addition, it greatly increases the probability of the source trees becoming unsynchronized and getting merge conflicts. Larry Hi Larry I do not recognize that there has been no diskution on the subject of net: wireless: I use some sed call for this, so it's easy to fix. You want the net: wireless: part completely erased then? I check in Documentation/ but find any clear info for this. Sorry for the patch, is there any way for me to see that this is something that is being worked on? These patches are the result of private communications between the Realtek engineers and me. The only publication is in the rock branch of the git repo at http://github.com/lwfinger/rtlwifi_new.git. I do not understand the use of some 'sed' call. If you edit the source and add it to the git repo with the add and commit operations, then format-patch gives you exactly what you need, and send-email does that operation. I suspect he means how he makes the subject lines. I'm guessing something like: echo $PATH | sed 's/^.*\/drivers\///;s/\//: /;s/\.c$/: Remove some unused functions/;' Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: wireless: rtlwifi: btcoexist: halbtc8821a2ant: Remove some unused functions
On 01/02/2015 02:26 PM, Rickard Strandqvist wrote: Removes some functions that are not used anywhere: ex_halbtc8821a2ant_periodical() ex_halbtc8821a2ant_halt_notify() ex_halbtc8821a2ant_bt_info_notify() ex_halbtc8821a2ant_special_packet_notify() ex_halbtc8821a2ant_connect_notify() ex_halbtc8821a2ant_scan_notify() ex_halbtc8821a2ant_lps_notify() ex_halbtc8821a2ant_ips_notify() ex_halbtc8821a2ant_display_coex_info() ex_halbtc8821a2ant_init_coex_dm() ex_halbtc8821a2ant_init_hwconfig() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se I know that you have been told that including net: wireless: in the subject line is discouraged. Please do not do this again. The staging directory is different as GregKH uses staging: in the subject to route patches, but wireless does not. As to the patch, NACK for the simple reason that I am currently working on a number of changes to btcoexist. Some of these routines may end up being removed, but others will not. Having your patch remove them, and one of mine adding them back just constitutes a lot of churning of the source. In addition, it greatly increases the probability of the source trees becoming unsynchronized and getting merge conflicts. Larry -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
