Re: [PATCH] rsi: fix a bug in rsi_hal_key_config()

[Gustavo A. R. Silva]

Hi Dan,

On 04/27/2018 06:44 AM, Dan Carpenter wrote:

On Fri, Apr 27, 2018 at 02:32:20PM +0300, Kalle Valo wrote:


Gustavo submitted an identical patch also for this one :)

https://patchwork.kernel.org/patch/10365997/



Hey Gustavo,

We keep on sending duplicate patches.  Most of the static checker people
CC kernel-janit...@vger.kernel.org so we can see what's already been
sent.



Oh, I didn't know that.  I'll start CCing that list then.

Thanks for letting me know.
--
Gustavo

Re: [PATCH] rsi: fix a bug in rsi_hal_key_config()

[Dan Carpenter]

On Fri, Apr 27, 2018 at 02:32:20PM +0300, Kalle Valo wrote:
> 
> Gustavo submitted an identical patch also for this one :)
> 
> https://patchwork.kernel.org/patch/10365997/
> 

Hey Gustavo,

We keep on sending duplicate patches.  Most of the static checker people
CC kernel-janit...@vger.kernel.org so we can see what's already been
sent.

regards,
dan carpenter

Re: [PATCH] rsi: fix a bug in rsi_hal_key_config()

[Kalle Valo]

Dan Carpenter  writes:

> Smatch complains that the end of this function is dead code.  I'm pretty
> sure that this return needs to be changed to only return on error.
>
> Fixes: 4fd6c4762f37 ("rsi: roaming enhancements")
> Signed-off-by: Dan Carpenter 
>
> diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c 
> b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> index 766d874cc6e2..80e7f4f4f188 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> @@ -911,14 +911,14 @@ static int rsi_hal_key_config(struct ieee80211_hw *hw,
>   }
>   }
>  
> - return rsi_hal_load_key(adapter->priv,
> - key->key,
> - key->keylen,
> - key_type,
> - key->keyidx,
> - key->cipher,
> - sta_id,
> - vif);
> + status = rsi_hal_load_key(adapter->priv,
> +   key->key,
> +   key->keylen,
> +   key_type,
> +   key->keyidx,
> +   key->cipher,
> +   sta_id,
> +   vif);

Gustavo submitted an identical patch also for this one :)

https://patchwork.kernel.org/patch/10365997/

-- 
Kalle Valo