Re: [PATCH 00/19] staging/wilc1000 cleanups
On Friday 23 October 2015 16:51:13 Tony Cho wrote: > Hi Arnd, > First of all, I would like to say "thank you" for your efforts and > contributions. > We are updating the driver because new revision came up and making new > patches > to make it stable and elegant as Linux driver. In these days, we are > sending big changes > while testing such patches and also doing updates at once. > > As you did, we are scheduled to provide the patches making device tree > and delete all of platform > dependencies as you removed WILC_SDIO_IRQ_GPIO as well as other things. > So, I would like to > discuss with you for your series of patch. > > In this time, I think it's important to make the driver to be compiled > even if the link problem > happens as you reported. So, how about deleting all of SPI related files > from source tree and > even from Kconfig for the time being because new bus driver will come or > revert > the Kconfig and then can we expect the best patch in the near feature? > > I respect your efforts and patches, so your opinion is very important to me. Hi Tony, I've seen you have merged the patches that you mentioned into Greg's tree. I have now rebased my patches on top, including the separate SPI driver. Once we merge those, it should work fine, and having multiple front-end drivers gives a nice template for adding future hardware specific variations like another bus, or a newer model on the same bus. I'll post my patches after some more testing. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/19] staging/wilc1000 cleanups
Hi arnd, Thanks for the all the patches. :) About the patch ( use proper naming for global symbols ), We are planning to use this driver not only for wilc1000 but also for other atmel wireless driver. I'd appreciate if you could use wl instead of wilc1000. And the global variable g_linux_wlan will be placed in netdevice private data and finally it will be removed. I already posted some of those patches. Thanks, Glen. On 2015년 10월 21일 07:47, Arnd Bergmann wrote: After I screwed up two or three times trying to get the dependencies with the SPI and SDIO backends right, I ended up taking the time to do the real fix and make both coexist. This is a series of patches that address various issues with the driver, but is mainly targetted at splitting out the spi and sdio backends into separate drivers that can be built independent of one another. The last patch is more experimental than the others, hence the [RFC] annotation. Please review and test. Arnd Arnd Bergmann (19): staging/wilc1000: remove unused functions staging/wilc1000: make symbols static if possible staging/wilc1000: use proper naming for global symbols staging/wilc1000: move extern declarations to headers staging/wilc1000: use NO_SECURITY instead of NO_ENCRYPT staging/wilc1000: avoid static definitions in header staging/wilc1000: remove linux_wlan_{device_power,device_detection} staging/wilc1000: move wilc_wlan_inp_t into struct wilc staging/wilc1000: move init/exit functions to driver files staging/wilc1000: unify device pointer staging/wilc1000: move wilc1000_ops to drivers staging/wilc1000: use device pointer for phy creation staging/wilc1000: move COMPLEMENT_BOOT code to linux_wlan_sdio.c staging/wilc1000: get rid of WILC_SDIO_IRQ_GPIO staging/wilc1000: turn enable_irq/disable_irq into callbacks staging/wilc1000: remove WILC_SDIO/WILC_SPI macros staging/wilc1000: pass hif operations through initialization staging/wilc1000: split out bus specific modules [RFC] staging/wilc1000: use more regular probing drivers/staging/wilc1000/Kconfig | 66 +- drivers/staging/wilc1000/Makefile | 16 +- drivers/staging/wilc1000/coreconfigurator.c | 12 +- drivers/staging/wilc1000/coreconfigurator.h | 12 +- drivers/staging/wilc1000/host_interface.c | 501 +++- drivers/staging/wilc1000/host_interface.h | 349 ++- drivers/staging/wilc1000/linux_mon.c | 11 +- drivers/staging/wilc1000/linux_wlan.c | 695 +++--- drivers/staging/wilc1000/linux_wlan_common.h | 18 +- drivers/staging/wilc1000/linux_wlan_sdio.c| 202 +-- drivers/staging/wilc1000/linux_wlan_sdio.h| 14 - drivers/staging/wilc1000/linux_wlan_spi.c | 119 ++-- drivers/staging/wilc1000/linux_wlan_spi.h | 8 - drivers/staging/wilc1000/wilc_debugfs.c | 20 +- drivers/staging/wilc1000/wilc_sdio.c | 213 +++ drivers/staging/wilc1000/wilc_spi.c | 276 + drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 495 +++ drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 87 +-- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 21 +- drivers/staging/wilc1000/wilc_wlan.c | 180 +++--- drivers/staging/wilc1000/wilc_wlan.h | 49 +- drivers/staging/wilc1000/wilc_wlan_cfg.c | 6 +- drivers/staging/wilc1000/wilc_wlan_if.h | 23 +- 23 files changed, 1171 insertions(+), deletions(-) delete mode 100644 drivers/staging/wilc1000/linux_wlan_sdio.h -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/19] staging/wilc1000 cleanups
On Wednesday 21 October 2015 19:06:52 glen lee wrote: > Hi arnd, > > Thanks for the all the patches. > About the patch ( use proper naming for global symbols ), > We are planning to use this driver not only for wilc1000 but also for > other atmel wireless driver. I'd appreciate if you could use wl instead of > wilc1000. Hmm, while I see that 'wilc1000' is too specific here, using just 'wl' might be a little too general. The same namespace is used by drivers/mtd/ubi/wl.c, drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c, and a number of local identifiers in other drivers. Would 'wilc' work as a prefix for all devices you are interested in here? > And the global variable g_linux_wlan will be placed in netdevice private data > and finally it will be removed. I already posted some of those patches. Ok, so we need to coordinate a bit here. My patches also go in that direction and remove the global variables from linux_wlan_sdio.c and linux_wlan_spi.c, but did not remove the one from linux_wlan.c, because doing that depends on the last [RFC] patch in my series, and I felt I had spent enough time on it at that point ;-) Would you be ok with taking my patches and rebasing them on top of yours with the changes you want, or do you need help from me with that? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/19] staging/wilc1000 cleanups
On Wednesday 21 October 2015 19:06:52 glen lee wrote: > Hi arnd, > > Thanks for the all the patches. > About the patch ( use proper naming for global symbols ), > We are planning to use this driver not only for wilc1000 but also for > other atmel wireless driver. I'd appreciate if you could use wl instead of > wilc1000. > > And the global variable g_linux_wlan will be placed in netdevice private data > and finally it will be removed. I already posted some of those patches. I couldn't find the patches anywhere, but I've updated my series now to rename the symbols to wilc_* and to remove most but not all references to g_linux_wlan (or wilc_dev after my rename). Do you want me to post those so you can integrate them, or should I have a look at what you sent first (please send me a copy then). Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/19] staging/wilc1000 cleanups
On 2015년 10월 22일 21:23, Arnd Bergmann wrote: On Wednesday 21 October 2015 19:06:52 glen lee wrote: Hi arnd, Thanks for the all the patches. About the patch ( use proper naming for global symbols ), We are planning to use this driver not only for wilc1000 but also for other atmel wireless driver. I'd appreciate if you could use wl instead of wilc1000. And the global variable g_linux_wlan will be placed in netdevice private data and finally it will be removed. I already posted some of those patches. I couldn't find the patches anywhere, but I've updated my series now to rename the symbols to wilc_* and to remove most but not all references to g_linux_wlan (or wilc_dev after my rename). Do you want me to post those so you can integrate them, or should I have a look at what you sent first (please send me a copy then). Hi arnd, I have tested with all the patches you have posted but it does not works. firmware start timed out in the function wilc1000_start_firmware. I also have tested with all the patched without last one, [RFC] one, but it shows Segmentation fault when insmod driver. For now, I can't rebase the patches. I'd appreciate if you could help us. The title of my first patch is, [PATCH 01/13] staging: wilc1000: add wilc to netdev private data structure and also refer to [PATCH 00/12] WILC1000 V2 for the g_linux_wlan ( The patches posted by tony@atmel.com ) By the way, deleting feature COMPLEMENT_BOOT patch already posted but not yet accepted. Thank you. Glen. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/19] staging/wilc1000 cleanups
Hi Arnd, First of all, I would like to say "thank you" for your efforts and contributions. We are updating the driver because new revision came up and making new patches to make it stable and elegant as Linux driver. In these days, we are sending big changes while testing such patches and also doing updates at once. As you did, we are scheduled to provide the patches making device tree and delete all of platform dependencies as you removed WILC_SDIO_IRQ_GPIO as well as other things. So, I would like to discuss with you for your series of patch. In this time, I think it's important to make the driver to be compiled even if the link problem happens as you reported. So, how about deleting all of SPI related files from source tree and even from Kconfig for the time being because new bus driver will come or revert the Kconfig and then can we expect the best patch in the near feature? I respect your efforts and patches, so your opinion is very important to me. Thanks, Tony. On 2015년 10월 23일 10:37, glen lee wrote: On 2015년 10월 22일 21:23, Arnd Bergmann wrote: On Wednesday 21 October 2015 19:06:52 glen lee wrote: Hi arnd, Thanks for the all the patches. About the patch ( use proper naming for global symbols ), We are planning to use this driver not only for wilc1000 but also for other atmel wireless driver. I'd appreciate if you could use wl instead of wilc1000. And the global variable g_linux_wlan will be placed in netdevice private data and finally it will be removed. I already posted some of those patches. I couldn't find the patches anywhere, but I've updated my series now to rename the symbols to wilc_* and to remove most but not all references to g_linux_wlan (or wilc_dev after my rename). Do you want me to post those so you can integrate them, or should I have a look at what you sent first (please send me a copy then). Hi arnd, I have tested with all the patches you have posted but it does not works. firmware start timed out in the function wilc1000_start_firmware. I also have tested with all the patched without last one, [RFC] one, but it shows Segmentation fault when insmod driver. For now, I can't rebase the patches. I'd appreciate if you could help us. The title of my first patch is, [PATCH 01/13] staging: wilc1000: add wilc to netdev private data structure and also refer to [PATCH 00/12] WILC1000 V2 for the g_linux_wlan ( The patches posted by tony@atmel.com ) By the way, deleting feature COMPLEMENT_BOOT patch already posted but not yet accepted. Thank you. Glen. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/19] staging/wilc1000 cleanups
Hi Arnd, I expect your opinion but I would like to make the patch to revert the commit bcc43a4b5ed75285aeacf2cf8d9b96d6379fb429 if you don't mind because the WILC1000 in staging still has compile errors. Then, we had better make patch for your concerns. I always appreciate your review and contribution. Thanks, Tony. On 2015년 10월 23일 16:51, Tony Cho wrote: Hi Arnd, First of all, I would like to say "thank you" for your efforts and contributions. We are updating the driver because new revision came up and making new patches to make it stable and elegant as Linux driver. In these days, we are sending big changes while testing such patches and also doing updates at once. As you did, we are scheduled to provide the patches making device tree and delete all of platform dependencies as you removed WILC_SDIO_IRQ_GPIO as well as other things. So, I would like to discuss with you for your series of patch. In this time, I think it's important to make the driver to be compiled even if the link problem happens as you reported. So, how about deleting all of SPI related files from source tree and even from Kconfig for the time being because new bus driver will come or revert the Kconfig and then can we expect the best patch in the near feature? I respect your efforts and patches, so your opinion is very important to me. Thanks, Tony. On 2015년 10월 23일 10:37, glen lee wrote: On 2015년 10월 22일 21:23, Arnd Bergmann wrote: On Wednesday 21 October 2015 19:06:52 glen lee wrote: Hi arnd, Thanks for the all the patches. About the patch ( use proper naming for global symbols ), We are planning to use this driver not only for wilc1000 but also for other atmel wireless driver. I'd appreciate if you could use wl instead of wilc1000. And the global variable g_linux_wlan will be placed in netdevice private data and finally it will be removed. I already posted some of those patches. I couldn't find the patches anywhere, but I've updated my series now to rename the symbols to wilc_* and to remove most but not all references to g_linux_wlan (or wilc_dev after my rename). Do you want me to post those so you can integrate them, or should I have a look at what you sent first (please send me a copy then). Hi arnd, I have tested with all the patches you have posted but it does not works. firmware start timed out in the function wilc1000_start_firmware. I also have tested with all the patched without last one, [RFC] one, but it shows Segmentation fault when insmod driver. For now, I can't rebase the patches. I'd appreciate if you could help us. The title of my first patch is, [PATCH 01/13] staging: wilc1000: add wilc to netdev private data structure and also refer to [PATCH 00/12] WILC1000 V2 for the g_linux_wlan ( The patches posted by tony@atmel.com ) By the way, deleting feature COMPLEMENT_BOOT patch already posted but not yet accepted. Thank you. Glen. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html