Re: [PATCH 107/113] rtl8xxxu: Use define for REG_PWR_DATA bits

[Jes Sorensen]

Kalle Valo  writes:
> jes.soren...@redhat.com writes:
>
>> From: Jes Sorensen 
>>
>> Use the bit define rather than hard code the value for REG_PWR_DATA bits.
>>
>> Signed-off-by: Jes Sorensen 
>
> [...]
>
>> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h
>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h
>> @@ -135,7 +135,7 @@
>>  #define  EFUSE_ACCESS_DISABLE   0x00/* RTL8723 only */
>>  
>>  #define REG_PWR_DATA0x0038
>> -#define PWR_DATA_EEPRPAD_RFE_CTRL_ENBIT(11)
>> +#define  PWR_DATA_EEPRPAD_RFE_CTRL_EN   BIT(11)
>
> Again the two spaces. Is your editor adding them automatically or what?

As in the previous email, this is for bit defines, matching the
register. The above just made it consistent with the rest of the code.

Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 107/113] rtl8xxxu: Use define for REG_PWR_DATA bits

[Kalle Valo]

jes.soren...@redhat.com writes:

> From: Jes Sorensen 
>
> Use the bit define rather than hard code the value for REG_PWR_DATA bits.
>
> Signed-off-by: Jes Sorensen 

[...]

> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h
> @@ -135,7 +135,7 @@
>  #define  EFUSE_ACCESS_DISABLE0x00/* RTL8723 only */
>  
>  #define REG_PWR_DATA 0x0038
> -#define PWR_DATA_EEPRPAD_RFE_CTRL_EN BIT(11)
> +#define  PWR_DATA_EEPRPAD_RFE_CTRL_ENBIT(11)

Again the two spaces. Is your editor adding them automatically or what?

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html