Re: [PATCH 5/5] ath9k: fix reporting calculated new FFT upper max
On Monday, October 1, 2018 5:31:42 PM CEST Kalle Valo wrote: > Simon Wunderlich writes: > > On Monday, October 1, 2018 2:07:55 PM CEST Kalle Valo wrote: > >> Simon Wunderlich wrote: > >> > Cc: Nick Kossifidis > >> > Signed-off-by: Simon Wunderlich > >> > Signed-off-by: Kalle Valo > >> > >> No empty commit logs, please. But I can add that, just tell me what to > >> add. > > > > How about: > > > > Since the debug print code is outside of the loop, it shouldn't use the > > loop iterator anymore but instead print the found maximum index. > > Perfect, thanks. > > > Let me know if you need me to resend or anything else. > > No need, I added this to the patch in the (not yet pushed) pending > branch. Awesome, thank you! Cheers, Simon signature.asc Description: This is a digitally signed message part.
Re: [PATCH 5/5] ath9k: fix reporting calculated new FFT upper max
Simon Wunderlich writes: > On Monday, October 1, 2018 2:07:55 PM CEST Kalle Valo wrote: >> Simon Wunderlich wrote: >> > Cc: Nick Kossifidis >> > Signed-off-by: Simon Wunderlich >> > Signed-off-by: Kalle Valo >> >> No empty commit logs, please. But I can add that, just tell me what to add. > > How about: > > Since the debug print code is outside of the loop, it shouldn't use the loop > iterator anymore but instead print the found maximum index. Perfect, thanks. > Let me know if you need me to resend or anything else. No need, I added this to the patch in the (not yet pushed) pending branch. -- Kalle Valo
Re: [PATCH 5/5] ath9k: fix reporting calculated new FFT upper max
On Monday, October 1, 2018 2:07:55 PM CEST Kalle Valo wrote: > Simon Wunderlich wrote: > > Cc: Nick Kossifidis > > Signed-off-by: Simon Wunderlich > > Signed-off-by: Kalle Valo > > No empty commit logs, please. But I can add that, just tell me what to add. How about: Since the debug print code is outside of the loop, it shouldn't use the loop iterator anymore but instead print the found maximum index. Let me know if you need me to resend or anything else. Thank you, Simon signature.asc Description: This is a digitally signed message part.
Re: [PATCH 5/5] ath9k: fix reporting calculated new FFT upper max
Simon Wunderlich wrote: > Cc: Nick Kossifidis > Signed-off-by: Simon Wunderlich > Signed-off-by: Kalle Valo No empty commit logs, please. But I can add that, just tell me what to add. -- https://patchwork.kernel.org/patch/10605615/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
