Re: [PATCH 5/8] btmrvl: support sysfs initiated firmware coredump

[Arend van Spriel]

On 5/15/2018 12:02 PM, Kalle Valo wrote:

Arend van Spriel  writes:


+ Marcel, bt-list

On 5/15/2018 11:30 AM, Kalle Valo wrote:

Arend van Spriel  writes:


Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops")
it is possible to initiate a device coredump from user-space. This
patch adds support for it in btmrvl_sdio adding the .coredump()
driver callback. This makes dump through debugfs obsolete so removing
it.

Signed-off-by: Arend van Spriel 
---
   drivers/bluetooth/btmrvl_debugfs.c | 31 ---
   drivers/bluetooth/btmrvl_drv.h |  2 --
   drivers/bluetooth/btmrvl_main.c|  6 --
   drivers/bluetooth/btmrvl_sdio.c| 11 ---
   4 files changed, 8 insertions(+), 42 deletions(-)


Shouldn't this go via bluetooth tree?


Ah, yes. I should at least have added bt-list to Cc: I can submit this
separately so you can drop it or can you coordinate with Marcel how to
deal with it. Maybe it is fine to take this to w-d tree?


I prefer submitting this patch separately to the bluetooth tree (and
I'll drop this version from my queue).


Fine by me.

Regards,
Arend

Re: [PATCH 5/8] btmrvl: support sysfs initiated firmware coredump

[Kalle Valo]

Arend van Spriel  writes:

> + Marcel, bt-list
>
> On 5/15/2018 11:30 AM, Kalle Valo wrote:
>> Arend van Spriel  writes:
>>
>>> Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops")
>>> it is possible to initiate a device coredump from user-space. This
>>> patch adds support for it in btmrvl_sdio adding the .coredump()
>>> driver callback. This makes dump through debugfs obsolete so removing
>>> it.
>>>
>>> Signed-off-by: Arend van Spriel 
>>> ---
>>>   drivers/bluetooth/btmrvl_debugfs.c | 31 ---
>>>   drivers/bluetooth/btmrvl_drv.h |  2 --
>>>   drivers/bluetooth/btmrvl_main.c|  6 --
>>>   drivers/bluetooth/btmrvl_sdio.c| 11 ---
>>>   4 files changed, 8 insertions(+), 42 deletions(-)
>>
>> Shouldn't this go via bluetooth tree?
>
> Ah, yes. I should at least have added bt-list to Cc: I can submit this
> separately so you can drop it or can you coordinate with Marcel how to
> deal with it. Maybe it is fine to take this to w-d tree?

I prefer submitting this patch separately to the bluetooth tree (and
I'll drop this version from my queue).

-- 
Kalle Valo

Re: [PATCH 5/8] btmrvl: support sysfs initiated firmware coredump

[Arend van Spriel]

+ Marcel, bt-list

On 5/15/2018 11:30 AM, Kalle Valo wrote:

Arend van Spriel  writes:


Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops")
it is possible to initiate a device coredump from user-space. This
patch adds support for it in btmrvl_sdio adding the .coredump()
driver callback. This makes dump through debugfs obsolete so removing
it.

Signed-off-by: Arend van Spriel 
---
  drivers/bluetooth/btmrvl_debugfs.c | 31 ---
  drivers/bluetooth/btmrvl_drv.h |  2 --
  drivers/bluetooth/btmrvl_main.c|  6 --
  drivers/bluetooth/btmrvl_sdio.c| 11 ---
  4 files changed, 8 insertions(+), 42 deletions(-)


Shouldn't this go via bluetooth tree?


Ah, yes. I should at least have added bt-list to Cc: I can submit this 
separately so you can drop it or can you coordinate with Marcel how to 
deal with it. Maybe it is fine to take this to w-d tree?


Regards,
Arend

Re: [PATCH 5/8] btmrvl: support sysfs initiated firmware coredump

[Kalle Valo]

Arend van Spriel  writes:

> Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops")
> it is possible to initiate a device coredump from user-space. This
> patch adds support for it in btmrvl_sdio adding the .coredump()
> driver callback. This makes dump through debugfs obsolete so removing
> it.
>
> Signed-off-by: Arend van Spriel 
> ---
>  drivers/bluetooth/btmrvl_debugfs.c | 31 ---
>  drivers/bluetooth/btmrvl_drv.h |  2 --
>  drivers/bluetooth/btmrvl_main.c|  6 --
>  drivers/bluetooth/btmrvl_sdio.c| 11 ---
>  4 files changed, 8 insertions(+), 42 deletions(-)

Shouldn't this go via bluetooth tree?

-- 
Kalle Valo