Re: [PATCH v8 2/4] cfg80211: allow wiphy specific regdomain management

2014-12-15 Thread Arik Nemtsov 
On Fri, Dec 12, 2014 at 2:39 PM, Johannes Berg
johan...@sipsolutions.net wrote:
 On Wed, 2014-12-03 at 18:08 +0200, Arik Nemtsov wrote:

 +void nl80211_send_reg_change_event(struct regulatory_request *request)
 +{
 + nl80211_common_reg_change_event(NL80211_CMD_REG_CHANGE, request);
 +}
 +
 +void nl80211_send_wiphy_reg_change_event(struct regulatory_request *request)
 +{
 + nl80211_common_reg_change_event(NL80211_CMD_WIPHY_REG_CHANGE, request);
 +}

 These are trivial wrappers, I'd make them inlines.

You mean inline here or in the header header? I'll do it here..

Arik
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v8 2/4] cfg80211: allow wiphy specific regdomain management

2014-12-15 Thread Johannes Berg 
On Mon, 2014-12-15 at 19:12 +0200, Arik Nemtsov wrote:
 On Fri, Dec 12, 2014 at 2:39 PM, Johannes Berg
 johan...@sipsolutions.net wrote:
  On Wed, 2014-12-03 at 18:08 +0200, Arik Nemtsov wrote:
 
  +void nl80211_send_reg_change_event(struct regulatory_request *request)
  +{
  + nl80211_common_reg_change_event(NL80211_CMD_REG_CHANGE, request);
  +}
  +
  +void nl80211_send_wiphy_reg_change_event(struct regulatory_request 
  *request)
  +{
  + nl80211_common_reg_change_event(NL80211_CMD_WIPHY_REG_CHANGE, 
  request);
  +}
 
  These are trivial wrappers, I'd make them inlines.
 
 You mean inline here or in the header header? I'll do it here..

Inline here makes no sense since it's declared in the header - it'd have
to be in the header.

johannes

--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html