Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr

[Ajay Singh]

On Tue, 13 Mar 2018 10:58:16 +0100
Greg Kroah-Hartman  wrote:

> On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote:
> > 
> > Reviewed-by: Ajay Singh 
> > 
> > On Mon, 12 Mar 2018 15:09:03 +0530
> >  wrote:
> >   
> > > From: HariPrasath Elango 
> > >  
> > 
> > Please avoid use of 'From' tag specially when there is only one
> > 'Signed-off-by' tag and its same.  
> 
> But the email client isn't putting the correct info in the email header,
> so this line is needed.
> 
> And if it's redundant, not a problem, git handles it just fine, better
> to be safe.


Thanks Greg, for giving the information.
In that case, we can keep the 'From:' tag to be on safe side.


Regards,
Ajay

Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr

[Greg Kroah-Hartman]

On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote:
> 
> Reviewed-by: Ajay Singh 
> 
> On Mon, 12 Mar 2018 15:09:03 +0530
>  wrote:
> 
> > From: HariPrasath Elango 
> >
> 
> Please avoid use of 'From' tag specially when there is only one
> 'Signed-off-by' tag and its same.

But the email client isn't putting the correct info in the email header,
so this line is needed.

And if it's redundant, not a problem, git handles it just fine, better
to be safe.

thanks,

greg k-h

Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr

[Ajay Singh]

Reviewed-by: Ajay Singh 

On Mon, 12 Mar 2018 15:09:03 +0530
 wrote:

> From: HariPrasath Elango 
>

Please avoid use of 'From' tag specially when there is only one
'Signed-off-by' tag and its same.

> Use the kernel pre-defined macro is_broadcast_ether_addr() instead of
> doing a memcmp here.
> 
> Signed-off-by: HariPrasath Elango 
> ---

Regards,
Ajay