Re: ath10k: Clean header files from bad block comments
Kalle Valo writes: > Marcin Rokicki wrote: >> Fix output from checkpatch.pl like: >> Block comments use a trailing */ on a separate line >> >> Signed-off-by: Marcin Rokicki > > Patch applied to ath-next branch of ath.git, thanks. > > 37ff1b0df37a ath10k: clean header files from bad block comments I also enabled the checkpatch warning in ath10k-check so that we can catch any new warnings: https://github.com/qca/qca-swiss-army-knife/commit/e23fbd3c9647c20e29e819b8a6d934e1b56067b9 -- Kalle Valo
Re: ath10k: Clean header files from bad block comments
Marcin Rokicki wrote: > Fix output from checkpatch.pl like: > Block comments use a trailing */ on a separate line > > Signed-off-by: Marcin Rokicki Patch applied to ath-next branch of ath.git, thanks. 37ff1b0df37a ath10k: clean header files from bad block comments -- https://patchwork.kernel.org/patch/9582975/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[PATCH] ath10k: Clean header files from bad block comments
Fix output from checkpatch.pl like:
Block comments use a trailing */ on a separate line
Signed-off-by: Marcin Rokicki
---
drivers/net/wireless/ath/ath10k/bmi.h | 3 ++-
drivers/net/wireless/ath/ath10k/core.h | 9 ++---
drivers/net/wireless/ath/ath10k/hif.h | 6 --
drivers/net/wireless/ath/ath10k/htt.h | 24 +++
drivers/net/wireless/ath/ath10k/hw.h| 3 ++-
drivers/net/wireless/ath/ath10k/rx_desc.h | 13 -
drivers/net/wireless/ath/ath10k/targaddrs.h | 19 +-
drivers/net/wireless/ath/ath10k/wmi-ops.h | 3 ++-
drivers/net/wireless/ath/ath10k/wmi.h | 30 +++--
9 files changed, 70 insertions(+), 40 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/bmi.h
b/drivers/net/wireless/ath/ath10k/bmi.h
index 7d3231a..98be562 100644
--- a/drivers/net/wireless/ath/ath10k/bmi.h
+++ b/drivers/net/wireless/ath/ath10k/bmi.h
@@ -176,7 +176,8 @@ union bmi_resp {
} rompatch_uninstall;
struct {
/* 0 = nothing executed
-* otherwise = NVRAM segment return value */
+* otherwise = NVRAM segment return value
+*/
__le32 result;
} nvram_process;
u8 payload[BMI_MAX_CMDBUF_SIZE];
diff --git a/drivers/net/wireless/ath/ath10k/core.h
b/drivers/net/wireless/ath/ath10k/core.h
index 88d14be..53a66e6 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -501,14 +501,16 @@ enum ath10k_state {
* stopped in ath10k_core_restart() work holding conf_mutex. The state
* RESTARTED means that the device is up and mac80211 has started hw
* reconfiguration. Once mac80211 is done with the reconfiguration we
-* set the state to STATE_ON in reconfig_complete(). */
+* set the state to STATE_ON in reconfig_complete().
+*/
ATH10K_STATE_RESTARTING,
ATH10K_STATE_RESTARTED,
/* The device has crashed while restarting hw. This state is like ON
* but commands are blocked in HTC and -ECOMM response is given. This
* prevents completion timeouts and makes the driver more responsive to
-* userspace commands. This is also prevents recursive recovery. */
+* userspace commands. This is also prevents recursive recovery.
+*/
ATH10K_STATE_WEDGED,
/* factory tests */
@@ -918,7 +920,8 @@ struct ath10k {
struct work_struct restart_work;
/* cycle count is reported twice for each visited channel during scan.
-* access protected by data_lock */
+* access protected by data_lock
+*/
u32 survey_last_rx_clear_count;
u32 survey_last_cycle_count;
struct survey_info survey[ATH10K_NUM_CHANS];
diff --git a/drivers/net/wireless/ath/ath10k/hif.h
b/drivers/net/wireless/ath/ath10k/hif.h
index b2566b0..6679dd9 100644
--- a/drivers/net/wireless/ath/ath10k/hif.h
+++ b/drivers/net/wireless/ath/ath10k/hif.h
@@ -54,7 +54,8 @@ struct ath10k_hif_ops {
int (*start)(struct ath10k *ar);
/* Clean up what start() did. This does not revert to BMI phase. If
-* desired so, call power_down() and power_up() */
+* desired so, call power_down() and power_up()
+*/
void (*stop)(struct ath10k *ar);
int (*map_service_to_pipe)(struct ath10k *ar, u16 service_id,
@@ -82,7 +83,8 @@ struct ath10k_hif_ops {
int (*power_up)(struct ath10k *ar);
/* Power down the device and free up resources. stop() must be called
-* before this if start() was called earlier */
+* before this if start() was called earlier
+*/
void (*power_down)(struct ath10k *ar);
int (*suspend)(struct ath10k *ar);
diff --git a/drivers/net/wireless/ath/ath10k/htt.h
b/drivers/net/wireless/ath/ath10k/htt.h
index 90c2f72..6305308 100644
--- a/drivers/net/wireless/ath/ath10k/htt.h
+++ b/drivers/net/wireless/ath/ath10k/htt.h
@@ -51,7 +51,8 @@ enum htt_h2t_msg_type { /* host-to-target */
HTT_H2T_MSG_TYPE_FRAG_DESC_BANK_CFG = 6,
/* This command is used for sending management frames in HTT < 3.0.
-* HTT >= 3.0 uses TX_FRM for everything. */
+* HTT >= 3.0 uses TX_FRM for everything.
+*/
HTT_H2T_MSG_TYPE_MGMT_TX= 7,
HTT_H2T_MSG_TYPE_TX_FETCH_RESP = 11,
@@ -910,7 +911,8 @@ struct htt_rx_test {
/* payload consists of 2 lists:
* a) num_ints * sizeof(__le32)
-* b) num_chars * sizeof(u8) aligned to 4bytes */
+* b) num_chars * sizeof(u8) aligned to 4bytes
+*/
u8 payload[0];
} __packed;
@@ -1307,7 +1309,8 @@ struct htt_frag_desc_bank_id {
} __packed;
/* real is 16 but it wouldn't fit in the max htt message size
- * so we use a conservatively safe value for now */
+ * so we use a conservatively safe value for now
+ */
#define HTT_FRAG
[PATCH] ath10k: Clean header files from bad block comments
Fix output from checkpatch.pl like:
Block comments use a trailing */ on a separate line
Signed-off-by: Marcin Rokicki
---
drivers/net/wireless/ath/ath10k/bmi.h | 3 ++-
drivers/net/wireless/ath/ath10k/core.h | 9 ++---
drivers/net/wireless/ath/ath10k/hif.h | 6 --
drivers/net/wireless/ath/ath10k/htt.h | 24 +++
drivers/net/wireless/ath/ath10k/hw.h| 3 ++-
drivers/net/wireless/ath/ath10k/rx_desc.h | 13 -
drivers/net/wireless/ath/ath10k/targaddrs.h | 19 +-
drivers/net/wireless/ath/ath10k/wmi-ops.h | 3 ++-
drivers/net/wireless/ath/ath10k/wmi.h | 30 +++--
9 files changed, 70 insertions(+), 40 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/bmi.h
b/drivers/net/wireless/ath/ath10k/bmi.h
index 7d3231a..98be562 100644
--- a/drivers/net/wireless/ath/ath10k/bmi.h
+++ b/drivers/net/wireless/ath/ath10k/bmi.h
@@ -176,7 +176,8 @@ union bmi_resp {
} rompatch_uninstall;
struct {
/* 0 = nothing executed
-* otherwise = NVRAM segment return value */
+* otherwise = NVRAM segment return value
+*/
__le32 result;
} nvram_process;
u8 payload[BMI_MAX_CMDBUF_SIZE];
diff --git a/drivers/net/wireless/ath/ath10k/core.h
b/drivers/net/wireless/ath/ath10k/core.h
index 88d14be..53a66e6 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -501,14 +501,16 @@ enum ath10k_state {
* stopped in ath10k_core_restart() work holding conf_mutex. The state
* RESTARTED means that the device is up and mac80211 has started hw
* reconfiguration. Once mac80211 is done with the reconfiguration we
-* set the state to STATE_ON in reconfig_complete(). */
+* set the state to STATE_ON in reconfig_complete().
+*/
ATH10K_STATE_RESTARTING,
ATH10K_STATE_RESTARTED,
/* The device has crashed while restarting hw. This state is like ON
* but commands are blocked in HTC and -ECOMM response is given. This
* prevents completion timeouts and makes the driver more responsive to
-* userspace commands. This is also prevents recursive recovery. */
+* userspace commands. This is also prevents recursive recovery.
+*/
ATH10K_STATE_WEDGED,
/* factory tests */
@@ -918,7 +920,8 @@ struct ath10k {
struct work_struct restart_work;
/* cycle count is reported twice for each visited channel during scan.
-* access protected by data_lock */
+* access protected by data_lock
+*/
u32 survey_last_rx_clear_count;
u32 survey_last_cycle_count;
struct survey_info survey[ATH10K_NUM_CHANS];
diff --git a/drivers/net/wireless/ath/ath10k/hif.h
b/drivers/net/wireless/ath/ath10k/hif.h
index b2566b0..6679dd9 100644
--- a/drivers/net/wireless/ath/ath10k/hif.h
+++ b/drivers/net/wireless/ath/ath10k/hif.h
@@ -54,7 +54,8 @@ struct ath10k_hif_ops {
int (*start)(struct ath10k *ar);
/* Clean up what start() did. This does not revert to BMI phase. If
-* desired so, call power_down() and power_up() */
+* desired so, call power_down() and power_up()
+*/
void (*stop)(struct ath10k *ar);
int (*map_service_to_pipe)(struct ath10k *ar, u16 service_id,
@@ -82,7 +83,8 @@ struct ath10k_hif_ops {
int (*power_up)(struct ath10k *ar);
/* Power down the device and free up resources. stop() must be called
-* before this if start() was called earlier */
+* before this if start() was called earlier
+*/
void (*power_down)(struct ath10k *ar);
int (*suspend)(struct ath10k *ar);
diff --git a/drivers/net/wireless/ath/ath10k/htt.h
b/drivers/net/wireless/ath/ath10k/htt.h
index 90c2f72..6305308 100644
--- a/drivers/net/wireless/ath/ath10k/htt.h
+++ b/drivers/net/wireless/ath/ath10k/htt.h
@@ -51,7 +51,8 @@ enum htt_h2t_msg_type { /* host-to-target */
HTT_H2T_MSG_TYPE_FRAG_DESC_BANK_CFG = 6,
/* This command is used for sending management frames in HTT < 3.0.
-* HTT >= 3.0 uses TX_FRM for everything. */
+* HTT >= 3.0 uses TX_FRM for everything.
+*/
HTT_H2T_MSG_TYPE_MGMT_TX= 7,
HTT_H2T_MSG_TYPE_TX_FETCH_RESP = 11,
@@ -910,7 +911,8 @@ struct htt_rx_test {
/* payload consists of 2 lists:
* a) num_ints * sizeof(__le32)
-* b) num_chars * sizeof(u8) aligned to 4bytes */
+* b) num_chars * sizeof(u8) aligned to 4bytes
+*/
u8 payload[0];
} __packed;
@@ -1307,7 +1309,8 @@ struct htt_frag_desc_bank_id {
} __packed;
/* real is 16 but it wouldn't fit in the max htt message size
- * so we use a conservatively safe value for now */
+ * so we use a conservatively safe value for now
+ */
#define HTT_FRAG
