Re: [v2] ath10k: Enable hw checksum for wcn3990
Rakesh Pillai wrote: > By default ath10k driver enables the support for HW_CHECKSUM > (NETIF_F_HW_CSUM). Since the TCP/UDP checksum calculation is not enabled > in the wcn3990 firmware the checksum is incorrect in the TCP/UDP packets > and all patckets are dropped. But due note that wcn3990 support in > ath10k is still incomplete so this isn't a critical fix (yet). > > Enable hw checksum calculations in wcn3990 hardware by > setting the proper flags in msdu descriptor tso flags. > > Signed-off-by: Rakesh Pillai > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 20529b33aa12 ath10k: enable hw checksum for wcn3990 -- https://patchwork.kernel.org/patch/10344621/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: ath10k: Enable hw checksum for wcn3990
Hi Kalle, The ath10k-check warning has been corrected and I have sent the v2 for the same. Thanks, Rakesh Pillai. On 2018-04-16 18:46, Kalle Valo wrote: Rakesh Pillai wrote: By default ath10k driver enables the support for HW_CHECKSUM (NETIF_F_HW_CSUM). Since the TCP/UDP checksum calculation is not enabled in the wcn3990 firmware the checksum is incorrect in the TCP/UDP packets and all patckets are dropped. But due note that wcn3990 support in ath10k is still incomplete so this isn't a critical fix (yet). Enable hw checksum calculations in wcn3990 hardware by setting the proper flags in msdu descriptor tso flags. Signed-off-by: Rakesh Pillai Signed-off-by: Kalle Valo Introduces a new sparse warning: potku:~/ath10k/src/ath$ ath10k-check drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47: warning: invalid assignment: |= drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47:left side has type restricted __le32 drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47:right side has type unsigned long Patch set to Changes Requested.
[PATCH v2] ath10k: Enable hw checksum for wcn3990
From: Rakesh Pillai
By default ath10k driver enables the support for HW_CHECKSUM
(NETIF_F_HW_CSUM). Since the TCP/UDP checksum calculation is not enabled
in the wcn3990 firmware the checksum is incorrect in the TCP/UDP packets
and all patckets are dropped. But due note that wcn3990 support in
ath10k is still incomplete so this isn't a critical fix (yet).
Enable hw checksum calculations in wcn3990 hardware by
setting the proper flags in msdu descriptor tso flags.
Signed-off-by: Rakesh Pillai
---
drivers/net/wireless/ath/ath10k/htt.h| 13 +
drivers/net/wireless/ath/ath10k/htt_tx.c | 7 +--
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt.h
b/drivers/net/wireless/ath/ath10k/htt.h
index 8cc2a8b..11f52df 100644
--- a/drivers/net/wireless/ath/ath10k/htt.h
+++ b/drivers/net/wireless/ath/ath10k/htt.h
@@ -127,6 +127,19 @@ struct htt_msdu_ext_desc_64 {
| HTT_MSDU_EXT_DESC_FLAG_TCP_IPV4_CSUM_ENABLE \
| HTT_MSDU_EXT_DESC_FLAG_TCP_IPV6_CSUM_ENABLE)
+#define HTT_MSDU_EXT_DESC_FLAG_IPV4_CSUM_ENABLE_64 BIT(16)
+#define HTT_MSDU_EXT_DESC_FLAG_UDP_IPV4_CSUM_ENABLE_64 BIT(17)
+#define HTT_MSDU_EXT_DESC_FLAG_UDP_IPV6_CSUM_ENABLE_64 BIT(18)
+#define HTT_MSDU_EXT_DESC_FLAG_TCP_IPV4_CSUM_ENABLE_64 BIT(19)
+#define HTT_MSDU_EXT_DESC_FLAG_TCP_IPV6_CSUM_ENABLE_64 BIT(20)
+#define HTT_MSDU_EXT_DESC_FLAG_PARTIAL_CSUM_ENABLE_64 BIT(21)
+
+#define HTT_MSDU_CHECKSUM_ENABLE_64
(HTT_MSDU_EXT_DESC_FLAG_IPV4_CSUM_ENABLE_64 \
+|
HTT_MSDU_EXT_DESC_FLAG_UDP_IPV4_CSUM_ENABLE_64 \
+|
HTT_MSDU_EXT_DESC_FLAG_UDP_IPV6_CSUM_ENABLE_64 \
+|
HTT_MSDU_EXT_DESC_FLAG_TCP_IPV4_CSUM_ENABLE_64 \
+|
HTT_MSDU_EXT_DESC_FLAG_TCP_IPV6_CSUM_ENABLE_64)
+
enum htt_data_tx_desc_flags0 {
HTT_DATA_TX_DESC_FLAGS0_MAC_HDR_PRESENT = 1 << 0,
HTT_DATA_TX_DESC_FLAGS0_NO_AGGR = 1 << 1,
diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c
b/drivers/net/wireless/ath/ath10k/htt_tx.c
index d334b7b..ad49d06 100644
--- a/drivers/net/wireless/ath/ath10k/htt_tx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_tx.c
@@ -1475,8 +1475,11 @@ static int ath10k_htt_tx_64(struct ath10k_htt *htt,
!test_bit(ATH10K_FLAG_RAW_MODE, &ar->dev_flags)) {
flags1 |= HTT_DATA_TX_DESC_FLAGS1_CKSUM_L3_OFFLOAD;
flags1 |= HTT_DATA_TX_DESC_FLAGS1_CKSUM_L4_OFFLOAD;
- if (ar->hw_params.continuous_frag_desc)
- ext_desc->flags |= HTT_MSDU_CHECKSUM_ENABLE;
+ if (ar->hw_params.continuous_frag_desc) {
+ memset(ext_desc->tso_flag, 0,
sizeof(ext_desc->tso_flag));
+ ext_desc->tso_flag[3] |=
+ __cpu_to_le32(HTT_MSDU_CHECKSUM_ENABLE_64);
+ }
}
/* Prevent firmware from sending up tx inspection requests. There's
--
1.9.1
Re: ath10k: Enable hw checksum for wcn3990
Rakesh Pillai wrote: > By default ath10k driver enables the support for HW_CHECKSUM > (NETIF_F_HW_CSUM). Since the TCP/UDP checksum calculation is not enabled > in the wcn3990 firmware the checksum is incorrect in the TCP/UDP packets > and all patckets are dropped. But due note that wcn3990 support in > ath10k is still incomplete so this isn't a critical fix (yet). > > Enable hw checksum calculations in wcn3990 hardware by > setting the proper flags in msdu descriptor tso flags. > > Signed-off-by: Rakesh Pillai > Signed-off-by: Kalle Valo Introduces a new sparse warning: potku:~/ath10k/src/ath$ ath10k-check drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47: warning: invalid assignment: |= drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47:left side has type restricted __le32 drivers/net/wireless/ath/ath10k/htt_tx.c:1480:47:right side has type unsigned long Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/10325669/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[PATCH] ath10k: Enable hw checksum for wcn3990
From: Rakesh Pillai
By default ath10k driver enables the support for HW_CHECKSUM
(NETIF_F_HW_CSUM). Since the TCP/UDP checksum calculation is not enabled
in the wcn3990 firmware the checksum is incorrect in the TCP/UDP packets
and all patckets are dropped. But due note that wcn3990 support in
ath10k is still incomplete so this isn't a critical fix (yet).
Enable hw checksum calculations in wcn3990 hardware by
setting the proper flags in msdu descriptor tso flags.
Signed-off-by: Rakesh Pillai
---
drivers/net/wireless/ath/ath10k/htt.h| 13 +
drivers/net/wireless/ath/ath10k/htt_tx.c | 6 --
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt.h
b/drivers/net/wireless/ath/ath10k/htt.h
index 8cc2a8b..11f52df 100644
--- a/drivers/net/wireless/ath/ath10k/htt.h
+++ b/drivers/net/wireless/ath/ath10k/htt.h
@@ -127,6 +127,19 @@ struct htt_msdu_ext_desc_64 {
| HTT_MSDU_EXT_DESC_FLAG_TCP_IPV4_CSUM_ENABLE \
| HTT_MSDU_EXT_DESC_FLAG_TCP_IPV6_CSUM_ENABLE)
+#define HTT_MSDU_EXT_DESC_FLAG_IPV4_CSUM_ENABLE_64 BIT(16)
+#define HTT_MSDU_EXT_DESC_FLAG_UDP_IPV4_CSUM_ENABLE_64 BIT(17)
+#define HTT_MSDU_EXT_DESC_FLAG_UDP_IPV6_CSUM_ENABLE_64 BIT(18)
+#define HTT_MSDU_EXT_DESC_FLAG_TCP_IPV4_CSUM_ENABLE_64 BIT(19)
+#define HTT_MSDU_EXT_DESC_FLAG_TCP_IPV6_CSUM_ENABLE_64 BIT(20)
+#define HTT_MSDU_EXT_DESC_FLAG_PARTIAL_CSUM_ENABLE_64 BIT(21)
+
+#define HTT_MSDU_CHECKSUM_ENABLE_64
(HTT_MSDU_EXT_DESC_FLAG_IPV4_CSUM_ENABLE_64 \
+|
HTT_MSDU_EXT_DESC_FLAG_UDP_IPV4_CSUM_ENABLE_64 \
+|
HTT_MSDU_EXT_DESC_FLAG_UDP_IPV6_CSUM_ENABLE_64 \
+|
HTT_MSDU_EXT_DESC_FLAG_TCP_IPV4_CSUM_ENABLE_64 \
+|
HTT_MSDU_EXT_DESC_FLAG_TCP_IPV6_CSUM_ENABLE_64)
+
enum htt_data_tx_desc_flags0 {
HTT_DATA_TX_DESC_FLAGS0_MAC_HDR_PRESENT = 1 << 0,
HTT_DATA_TX_DESC_FLAGS0_NO_AGGR = 1 << 1,
diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c
b/drivers/net/wireless/ath/ath10k/htt_tx.c
index d334b7b..d97ef72 100644
--- a/drivers/net/wireless/ath/ath10k/htt_tx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_tx.c
@@ -1475,8 +1475,10 @@ static int ath10k_htt_tx_64(struct ath10k_htt *htt,
!test_bit(ATH10K_FLAG_RAW_MODE, &ar->dev_flags)) {
flags1 |= HTT_DATA_TX_DESC_FLAGS1_CKSUM_L3_OFFLOAD;
flags1 |= HTT_DATA_TX_DESC_FLAGS1_CKSUM_L4_OFFLOAD;
- if (ar->hw_params.continuous_frag_desc)
- ext_desc->flags |= HTT_MSDU_CHECKSUM_ENABLE;
+ if (ar->hw_params.continuous_frag_desc) {
+ memset(ext_desc->tso_flag, 0,
sizeof(ext_desc->tso_flag));
+ ext_desc->tso_flag[3] |= HTT_MSDU_CHECKSUM_ENABLE_64;
+ }
}
/* Prevent firmware from sending up tx inspection requests. There's
--
1.9.1
