Re: ath10k: Fix possible wrong rx_busy time reporting in QCA4019

[Kalle Valo]

Vasanthakumar Thiagarajan <vthia...@qti.qualcomm.com> wrote:
> As hw cycle counters in QCA4019 wraparound independantly in QCA4019
> it is possible cycle counter and rx clear counter would wraparound
> at the same time. Current logic assumes only one of the counters
> would wraparound at anytime. Fix this by moving 'else' part to
> another 'if'.
> 
> Fixes: 8e100354a98 ("ath10k: fix cycle counter wraparound handling for 
> QCA4019")
> Signed-off-by: Vasanthakumar Thiagarajan <vthia...@qti.qualcomm.com>
> Reviewed-by: Julian Calaby <julian.cal...@gmail.com>

Thanks, 1 patch applied to ath-next branch of ath.git:

c11e99396d0f ath10k: fix possible wrong rx_busy time reporting in QCA4019

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9209723/

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ath10k: Fix possible wrong rx_busy time reporting in QCA4019

[Julian Calaby]

Hi All,

On Fri, Jul 1, 2016 at 9:07 PM, Vasanthakumar Thiagarajan
 wrote:
> As hw cycle counters in QCA4019 wraparound independantly in QCA4019
> it is possible cycle counter and rx clear counter would wraparound
> at the same time. Current logic assumes only one of the counters
> would wraparound at anytime. Fix this by moving 'else' part to
> another 'if'.
>
> Fixes: 8e100354a98 ("ath10k: fix cycle counter wraparound handling for 
> QCA4019")
> Signed-off-by: Vasanthakumar Thiagarajan 

Looks right to me.

Reviewed-by: Julian Calaby 

Thanks,

-- 
Julian Calaby

Email: julian.cal...@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] ath10k: Fix possible wrong rx_busy time reporting in QCA4019

[Vasanthakumar Thiagarajan]

As hw cycle counters in QCA4019 wraparound independantly in QCA4019
it is possible cycle counter and rx clear counter would wraparound
at the same time. Current logic assumes only one of the counters
would wraparound at anytime. Fix this by moving 'else' part to
another 'if'.

Fixes: 8e100354a98 ("ath10k: fix cycle counter wraparound handling for QCA4019")
Signed-off-by: Vasanthakumar Thiagarajan 
---
 drivers/net/wireless/ath/ath10k/hw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/hw.c 
b/drivers/net/wireless/ath/ath10k/hw.c
index bd86e7a..7462627 100644
--- a/drivers/net/wireless/ath/ath10k/hw.c
+++ b/drivers/net/wireless/ath/ath10k/hw.c
@@ -198,7 +198,8 @@ void ath10k_hw_fill_survey_time(struct ath10k *ar, struct 
survey_info *survey,
case ATH10K_HW_CC_WRAP_SHIFTED_EACH:
if (cc < cc_prev)
cc_fix = 0x7fff;
-   else
+
+   if (rcc < rcc_prev)
rcc_fix = 0x7fff;
break;
case ATH10K_HW_CC_WRAP_DISABLED:
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html