Re: mt7601u: let mac80211 validate rx CCMP PN

[Kalle Valo]

Lorenzo Bianconi <lorenzo.bianc...@redhat.com> wrote:

> Apparently the hardware does not perform CCMP PN validation so
> let mac80211 take care of possible replay attacks in sw.
> Moreover indicate ICV and MIC had been stripped setting corresponding
> bits in ieee80211_rx_status.
> The fix has been validated using 4.2.1 and 4.1.3 tests from the WiFi
> Alliance vulnerability detection tool.
> 
> Fixes: c869f77d6abb ("add mt7601u driver")
> Acked-by: Jakub Kicinski <kubak...@wp.pl>
> Tested-by: David Park <david.p...@hitemengineering.com>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianc...@redhat.com>

Patch applied to wireless-drivers-next.git, thanks.

a9eab62d4164 mt7601u: let mac80211 validate rx CCMP PN

-- 
https://patchwork.kernel.org/patch/10270239/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

[PATCH] mt7601u: let mac80211 validate rx CCMP PN

[Lorenzo Bianconi]

Apparently the hardware does not perform CCMP PN validation so
let mac80211 take care of possible replay attacks in sw.
Moreover indicate ICV and MIC had been stripped setting corresponding
bits in ieee80211_rx_status.
The fix has been validated using 4.2.1 and 4.1.3 tests from the WiFi
Alliance vulnerability detection tool.

Fixes: c869f77d6abb ("add mt7601u driver")
Acked-by: Jakub Kicinski 
Tested-by: David Park 
Signed-off-by: Lorenzo Bianconi 
---
 drivers/net/wireless/mediatek/mt7601u/initvals.h |  1 +
 drivers/net/wireless/mediatek/mt7601u/mac.c  | 10 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt7601u/initvals.h 
b/drivers/net/wireless/mediatek/mt7601u/initvals.h
index ec11ff66969d..2dc6b68e7fb9 100644
--- a/drivers/net/wireless/mediatek/mt7601u/initvals.h
+++ b/drivers/net/wireless/mediatek/mt7601u/initvals.h
@@ -139,6 +139,7 @@ static const struct mt76_reg_pair mac_common_vals[] = {
{ MT_TXOP_HLDR_ET,  0x0002 },
{ MT_XIFS_TIME_CFG, 0x33a41010 },
{ MT_PWR_PIN_CFG,   0x },
+   { MT_PN_PAD_MODE,   0x0001 },
 };
 
 static const struct mt76_reg_pair mac_chip_vals[] = {
diff --git a/drivers/net/wireless/mediatek/mt7601u/mac.c 
b/drivers/net/wireless/mediatek/mt7601u/mac.c
index 4d3077941138..d55d7040a56d 100644
--- a/drivers/net/wireless/mediatek/mt7601u/mac.c
+++ b/drivers/net/wireless/mediatek/mt7601u/mac.c
@@ -480,8 +480,16 @@ u32 mt76_mac_process_rx(struct mt7601u_dev *dev, struct 
sk_buff *skb,
 
if (rxwi->rxinfo & cpu_to_le32(MT_RXINFO_DECRYPT)) {
status->flag |= RX_FLAG_DECRYPTED;
-   status->flag |= RX_FLAG_IV_STRIPPED | RX_FLAG_MMIC_STRIPPED;
+   status->flag |= RX_FLAG_MMIC_STRIPPED;
+   status->flag |= RX_FLAG_MIC_STRIPPED;
+   status->flag |= RX_FLAG_ICV_STRIPPED;
+   status->flag |= RX_FLAG_IV_STRIPPED;
}
+   /* let mac80211 take care of PN validation since apparently
+* the hardware does not support it
+*/
+   if (rxwi->rxinfo & cpu_to_le32(MT_RXINFO_PN_LEN))
+   status->flag &= ~RX_FLAG_IV_STRIPPED;
 
status->chains = BIT(0);
rssi = mt7601u_phy_get_rssi(dev, rxwi, rate);
-- 
2.14.3