Re: next-20151126 build: 3 failures 15 warnings (next-20151126)
On Thu, Nov 26, 2015 at 08:34:20PM +0200, Kalle Valo wrote: > Mark Brown writes: > > It still ought to be fixed regardless of why it showed up - the > > intention of the code is that we build the real thermal code regardless > > of if that's modular or not but that's not what the code actually does. > Like I said above Michal will apply a fix to his tree. Read the full > discussion from patchwork: > https://patchwork.kernel.org/patch/7707801/ Oh, right - a fix for this specific issue rather than a fix for whatever change he made. signature.asc Description: PGP signature
Re: next-20151126 build: 3 failures 15 warnings (next-20151126)
Mark Brown writes:
> On Thu, Nov 26, 2015 at 06:58:32PM +0200, Kalle Valo wrote:
>> Mark Brown writes:
>
>> > No, I didn't make much effort to check though since the use of ifdef was
>> > clearly a bug waiting to happen anyway, I was more surprised it worked
>> > at all than anything.
>
>> Michal Marek explains[1] that this is due to commit cf4f21938e13
>> ("kbuild: Allow to specify composite modules with modname-m") and has
>> nothing to do with the wireless drivers reorganisation. I'll drop this
>> patch as Michal will apply his fix to the kbuild tree.
>
> It still ought to be fixed regardless of why it showed up - the
> intention of the code is that we build the real thermal code regardless
> of if that's modular or not but that's not what the code actually does.
Like I said above Michal will apply a fix to his tree. Read the full
discussion from patchwork:
https://patchwork.kernel.org/patch/7707801/
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: next-20151126 build: 3 failures 15 warnings (next-20151126)
On Thu, Nov 26, 2015 at 06:58:32PM +0200, Kalle Valo wrote:
> Mark Brown writes:
> > No, I didn't make much effort to check though since the use of ifdef was
> > clearly a bug waiting to happen anyway, I was more surprised it worked
> > at all than anything.
> Michal Marek explains[1] that this is due to commit cf4f21938e13
> ("kbuild: Allow to specify composite modules with modname-m") and has
> nothing to do with the wireless drivers reorganisation. I'll drop this
> patch as Michal will apply his fix to the kbuild tree.
It still ought to be fixed regardless of why it showed up - the
intention of the code is that we build the real thermal code regardless
of if that's modular or not but that's not what the code actually does.
signature.asc
Description: PGP signature
Re: next-20151126 build: 3 failures 15 warnings (next-20151126)
Mark Brown writes:
> On Thu, Nov 26, 2015 at 02:39:40PM +0200, Kalle Valo wrote:
>> Mark Brown writes:
>
>> > It looks like this was somehow triggered as part of the reorganisation
>> > of the WiFi directory structure.
>
>> This is surprising and also worrying, any ideas why? It would be good to
>> understand the root cause in case there's a bug in wireless drivers
>> directory reorganisation.
>
> No, I didn't make much effort to check though since the use of ifdef was
> clearly a bug waiting to happen anyway, I was more surprised it worked
> at all than anything.
Michal Marek explains[1] that this is due to commit cf4f21938e13
("kbuild: Allow to specify composite modules with modname-m") and has
nothing to do with the wireless drivers reorganisation. I'll drop this
patch as Michal will apply his fix to the kbuild tree.
[1] https://patchwork.kernel.org/patch/7707801/
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: next-20151126 build: 3 failures 15 warnings (next-20151126)
On Thu, Nov 26, 2015 at 02:39:40PM +0200, Kalle Valo wrote: > Mark Brown writes: > > It looks like this was somehow triggered as part of the reorganisation > > of the WiFi directory structure. > This is surprising and also worrying, any ideas why? It would be good to > understand the root cause in case there's a bug in wireless drivers > directory reorganisation. No, I didn't make much effort to check though since the use of ifdef was clearly a bug waiting to happen anyway, I was more surprised it worked at all than anything. signature.asc Description: PGP signature
Re: next-20151126 build: 3 failures 15 warnings (next-20151126)
Mark Brown writes: > On Thu, Nov 26, 2015 at 09:06:25AM +, Build bot for Mark Brown wrote: > > Today's -next fails to build an arm64 allmodconfig due to: > >> arm64-allmodconfig >> ../drivers/net/wireless/ath/ath10k/thermal.c:119:6: error: redefinition of >> 'ath10k_thermal_event_temperature' >> ../drivers/net/wireless/ath/ath10k/thermal.c:136:6: error: redefinition of >> 'ath10k_thermal_set_throttling' >> ../drivers/net/wireless/ath/ath10k/thermal.c:162:5: error: redefinition of >> 'ath10k_thermal_register' >> ../drivers/net/wireless/ath/ath10k/thermal.c:216:6: error: redefinition of >> 'ath10k_thermal_unregister' > > This is happening because there are stub functions provided in the > driver's thermal.h for !THERMAL cases but these are guarded by an #ifdef > not an #if and so fails to do the right thing if the thermal code is > built as a module. Thanks, I'll apply the fix soon. Just wait for comments from others first. > It looks like this was somehow triggered as part of the reorganisation > of the WiFi directory structure. This is surprising and also worrying, any ideas why? It would be good to understand the root cause in case there's a bug in wireless drivers directory reorganisation. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: next-20151126 build: 3 failures 15 warnings (next-20151126)
On Thu, Nov 26, 2015 at 09:06:25AM +, Build bot for Mark Brown wrote: Today's -next fails to build an arm64 allmodconfig due to: > arm64-allmodconfig > ../drivers/net/wireless/ath/ath10k/thermal.c:119:6: error: redefinition of > 'ath10k_thermal_event_temperature' > ../drivers/net/wireless/ath/ath10k/thermal.c:136:6: error: redefinition of > 'ath10k_thermal_set_throttling' > ../drivers/net/wireless/ath/ath10k/thermal.c:162:5: error: redefinition of > 'ath10k_thermal_register' > ../drivers/net/wireless/ath/ath10k/thermal.c:216:6: error: redefinition of > 'ath10k_thermal_unregister' This is happening because there are stub functions provided in the driver's thermal.h for !THERMAL cases but these are guarded by an #ifdef not an #if and so fails to do the right thing if the thermal code is built as a module. It looks like this was somehow triggered as part of the reorganisation of the WiFi directory structure. signature.asc Description: PGP signature
