Re: pull request: iwlwifi 2016-05-04

[Coelho, Luciano]

On Fri, 2016-05-06 at 14:34 +0300, Kalle Valo wrote:
> "Grumbach, Emmanuel"  writes:
> 
> > 
> > I know it is extremely late in the cycle, but this patch is
> > intended
> > for 4.6... It fixes a regression I introduced: a P2P specification
> > violation as mentioned in the commit message.
> > The patch is rather big in terms of number of lines changed, but
> > the
> > semantics is very simple. I have to copy the control block of the
> > skb
> > to the stack whereas we accessed we used to access it directly
> > through
> > a pointer.
> > This obviously introduces a lot of line changes, but don't really
> > change the behavior of the code (since most of the accesses are
> > read
> > only).
> > 
> > Let me know how it goes.
> [...]
> 
> > 
> > The following changes since commit
> > f742aaf36edf0390c54d0614bc4d20fd4cd3762a:
> > 
> >   iwlwifi: mvm: fix accessing Null pointer during fw dump
> > collection (2016-04-12 11:52:39 +0300)
> > 
> > are available in the git repository at:
> > 
> >   https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-f
> > ixes.git tags/iwlwifi-for-kalle-2016-05-04
> Pulled, thanks. Let's see if this makes it to 4.6.
> 
> > 
> > I take this opportunity to inform you that I will be replaced by
> > Luca
> > for a few months at least. I will be working full steam on a side
> > project that will not allow me to do the maintainer job in
> > parallel.
> Ok, have fun in your new project.
> 
> Luca, as we _finally_ got sun here in Finland we have to have a "kick
> off meeting about the new organisation structure" by your grill ;)

Sounds good! When are you going to be coming to "The South"? :)

--
Luca.N�r��yb�X��ǧv�^�)޺{.n�+{��*ޕ�,�{ay�ʇڙ�,j��f���h���z��w���
���j:+v���w�j�mzZ+�ݢj"��!�i

Re: pull request: iwlwifi 2016-05-04

[Kalle Valo]

"Grumbach, Emmanuel"  writes:

> I know it is extremely late in the cycle, but this patch is intended
> for 4.6... It fixes a regression I introduced: a P2P specification
> violation as mentioned in the commit message.
> The patch is rather big in terms of number of lines changed, but the
> semantics is very simple. I have to copy the control block of the skb
> to the stack whereas we accessed we used to access it directly through
> a pointer.
> This obviously introduces a lot of line changes, but don't really
> change the behavior of the code (since most of the accesses are read
> only).
>
> Let me know how it goes.

[...]

> The following changes since commit f742aaf36edf0390c54d0614bc4d20fd4cd3762a:
>
>   iwlwifi: mvm: fix accessing Null pointer during fw dump collection 
> (2016-04-12 11:52:39 +0300)
>
> are available in the git repository at:
>
>   https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git 
> tags/iwlwifi-for-kalle-2016-05-04

Pulled, thanks. Let's see if this makes it to 4.6.

> I take this opportunity to inform you that I will be replaced by Luca
> for a few months at least. I will be working full steam on a side
> project that will not allow me to do the maintainer job in parallel.

Ok, have fun in your new project.

Luca, as we _finally_ got sun here in Finland we have to have a "kick
off meeting about the new organisation structure" by your grill ;)

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

pull request: iwlwifi 2016-05-04

[Grumbach, Emmanuel]

Hi Kalle,

I know it is extremely late in the cycle, but this patch is intended
for 4.6... It fixes a regression I introduced: a P2P specification
violation as mentioned in the commit message.
The patch is rather big in terms of number of lines changed, but the
semantics is very simple. I have to copy the control block of the skb
to the stack whereas we accessed we used to access it directly through
a pointer.
This obviously introduces a lot of line changes, but don't really
change the behavior of the code (since most of the accesses are read
only).

Let me know how it goes.

I take this opportunity to inform you that I will be replaced by Luca
for a few months at least. I will be working full steam on a side
project that will not allow me to do the maintainer job in parallel.

Thank you!

The following changes since commit f742aaf36edf0390c54d0614bc4d20fd4cd3762a:

  iwlwifi: mvm: fix accessing Null pointer during fw dump collection 
(2016-04-12 11:52:39 +0300)

are available in the git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git 
tags/iwlwifi-for-kalle-2016-05-04

for you to fetch changes up to 5c08b0f5026fcc13efb947c4d1f2ca3558145f68:

  iwlwifi: mvm: don't override the rate with the AMSDU len (2016-05-04 20:59:55 
+0300)


* fix P2P rates (and possibly other issues)


Emmanuel Grumbach (1):
  iwlwifi: mvm: don't override the rate with the AMSDU len

 drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 83 
---
 1 file changed, 48 insertions(+), 35 deletions(-)