Re: [linux-yocto] [kernel-cache][PATCH] efi.cfg: Drop ACPI dependency

2022-08-22 Thread Andrei Gherzan
On Mon, 22 Aug 2022, at 18:55, Andrei Gherzan wrote:
> From: Andrei Gherzan 
>
> On X86 this will have no impact as CONFIG_ACPI is enabled by default. On
> the other hand, ARM64 would be affected as they don't have the same
> default. The defconfig for arm64 recommends CONFIG_ACPI and this patch
> follows this recommendation in the qemuarm64 bsp configuration to fix
> ACPI-only EFI boots on this arch.
>
> arm (32bit) would also be unaffected as there is no ACPI support there
> at all. And this unconditional drop (CONFIG_ACPI) will actually fix a
> configuration warning when enabling EFI on a arm (32bit) machine:
>
> [INFO]: config 'CONFIG_ACPI' was set, but it wasn't assignable, check
> (parent) dependencies
>
> Upstream-status: Pending

Please drop this when you apply the patch. It is from a layer local integration.

Andrei

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#11580): 
https://lists.yoctoproject.org/g/linux-yocto/message/11580
Mute This Topic: https://lists.yoctoproject.org/mt/93187197/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[linux-yocto] [kernel-cache][PATCH] efi.cfg: Drop ACPI dependency

2022-08-22 Thread Andrei Gherzan
From: Andrei Gherzan 

On X86 this will have no impact as CONFIG_ACPI is enabled by default. On
the other hand, ARM64 would be affected as they don't have the same
default. The defconfig for arm64 recommends CONFIG_ACPI and this patch
follows this recommendation in the qemuarm64 bsp configuration to fix
ACPI-only EFI boots on this arch.

arm (32bit) would also be unaffected as there is no ACPI support there
at all. And this unconditional drop (CONFIG_ACPI) will actually fix a
configuration warning when enabling EFI on a arm (32bit) machine:

[INFO]: config 'CONFIG_ACPI' was set, but it wasn't assignable, check
(parent) dependencies

Upstream-status: Pending
Signed-off-by: Andrei Gherzan 
---
 bsp/qemuarm64/qemuarm64.cfg | 7 +++
 cfg/efi.cfg | 1 -
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/bsp/qemuarm64/qemuarm64.cfg b/bsp/qemuarm64/qemuarm64.cfg
index 2412d24e..81415cf9 100644
--- a/bsp/qemuarm64/qemuarm64.cfg
+++ b/bsp/qemuarm64/qemuarm64.cfg
@@ -33,3 +33,10 @@ CONFIG_RTC_DRV_PL031=y
 # PCI configs, needed for virtio-rng (and others)
 CONFIG_PCI=y
 CONFIG_PCI_HOST_GENERIC=y
+
+# arm64 defconfig suggests CONFIG_ACPI as default because it won't be enabled
+# with CONFIG_EFI - even though ACPI-only ARM64 EFI boots would break
+# otherwise. We also do the same here as a sane default.
+CONFIG_ARCH_SUPPORTS_ACPI=y
+CONFIG_ACPI=y
+
diff --git a/cfg/efi.cfg b/cfg/efi.cfg
index d3dfd603..d729cbe9 100644
--- a/cfg/efi.cfg
+++ b/cfg/efi.cfg
@@ -3,7 +3,6 @@
 
 # Dependencies
 CONFIG_PCI=y
-CONFIG_ACPI=y
 
 # Enable basic EFI support
 CONFIG_EFI=y
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#11579): 
https://lists.yoctoproject.org/g/linux-yocto/message/11579
Mute This Topic: https://lists.yoctoproject.org/mt/93187197/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-