[linux-yocto] [linux-yocto PATCH] drivers: mpam: Drop the improper assertions
From: Kevin Hao
The mpam_reprogram_ris_partid() and mpam_reset_ris() may be invoked on a
specific CPU by smp_call_on_cpu(). According to the implementation of
smp_call_on_cpu(), that also means these functions would be executed
in the worker kthread context. Both the
lockdep_assert_preemption_disabled() and lockdep_assert_held()
assertions are not suitable in this context because:
- the lockdep_assert_preemption_disabled() will trigger false positive
since the preempt is enabled in the worker kthread, but it will not
migrate to other CPU since the worker kthread is bound to one CPU.
- the implementation of lockdep_assert_held() is to check the lock
acquired by the current process. So in a worker kthread, it
definitely not acquire the &msc->lock.
Signed-off-by: Kevin Hao
---
Hi Bruce,
Please help me merge this into the following two branches:
v5.15/standard/cn-sdkv5.15/octeon
v5.15/standard/preempt-rt/cn-sdkv5.15/octeon
drivers/platform/mpam/mpam_devices.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/platform/mpam/mpam_devices.c
b/drivers/platform/mpam/mpam_devices.c
index 6fd355048d99..bd705dfe2498 100644
--- a/drivers/platform/mpam/mpam_devices.c
+++ b/drivers/platform/mpam/mpam_devices.c
@@ -1040,8 +1040,6 @@ static void mpam_reprogram_ris_partid(struct mpam_msc_ris
*ris, u16 partid,
u16 bwa_fract = GENMASK(15, rprops->bwa_wd);
u16 minval;
- lockdep_assert_held(&msc->lock);
-
spin_lock(&msc->part_sel_lock);
__mpam_part_sel(ris->ris_idx, partid, msc);
@@ -1206,13 +1204,9 @@ static int mpam_save_mbwu_state(void *arg)
static int mpam_reset_ris(void *arg)
{
struct mpam_msc_ris *ris = arg;
- struct mpam_msc *msc = ris->msc;
struct reprogram_ris reprogram_arg;
struct mpam_config empty_cfg = { 0 };
- lockdep_assert_preemption_disabled(); /* don't migrate to another CPU */
- lockdep_assert_held(&msc->lock);
-
if (ris->in_reset_state)
return 0;
--
2.39.2
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#12962):
https://lists.yoctoproject.org/g/linux-yocto/message/12962
Mute This Topic: https://lists.yoctoproject.org/mt/100679186/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[linux-yocto]: [kernel/kernel-rt]: drivers: i2c: remove default y from I2C_IMX_FLEXIO config
From: Limeng Hi Bruce, This patch is used to remove default y from I2C_IMX_FLEXIO config So, could you please help merge these patches into linux-ycoto kernel, both below 2 branchs? v6.1/standard/nxp-sdk-6.1/nxp-soc v6.1/standard/preempt-rt/nxp-sdk-6.1/nxp-soc diffstat info as below: Kconfig |1 - 1 file changed, 1 deletion(-) thanks, Limeng -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#12960): https://lists.yoctoproject.org/g/linux-yocto/message/12960 Mute This Topic: https://lists.yoctoproject.org/mt/100660337/21656 Group Owner: linux-yocto+ow...@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[linux-yocto] [PATCH] drivers: i2c: remove default y from I2C_IMX_FLEXIO config
When building kernel with kts test layer, COMPILE_TEST is set as y. This causes I2C_IMX_FLEXIO to be enabled because there is default y option in this kernel config. But the depended MFD_IMX_FLEXIO config is not enabled, and causes below building issue: drivers/i2c/busses/i2c-flexio.c:290: undefined reference to `flexio_sw_reset' Therefore, remove default y to avoid building issue. In this way, users also can select proper driver based on specific SoC. Signed-off-by: Meng Li --- drivers/i2c/busses/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 06a2f5db1352..567f5199c42a 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -725,7 +725,6 @@ config I2C_IMX_LPI2C config I2C_IMX_FLEXIO tristate "NXP IMX FLEXIO I2C MASTER" depends on (ARCH_MXC && MFD_IMX_FLEXIO) || COMPILE_TEST - default y help If you say yes to this option, support will be included for the I2C controller simulated by flexio embedded in NXP IMX8ULP SOCs. -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#12961): https://lists.yoctoproject.org/g/linux-yocto/message/12961 Mute This Topic: https://lists.yoctoproject.org/mt/100660338/21656 Group Owner: linux-yocto+ow...@lists.yoctoproject.org Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
