Re: [linux-yocto][linux-yocto v5.10/standard/nxp-sdk-5.10/nxp-soc & v5.10/standard/preempt-rt/nxp-sdk-5.10/nxp-soc][PATCH 1/1] dmaengine: imx-sdma: Fix a build warning in sdma_runtime_resume function

2022-01-19 Thread Bruce Ashfield 
merged.

Bruce

In message: [linux-yocto][linux-yocto v5.10/standard/nxp-sdk-5.10/nxp-soc & 
v5.10/standard/preempt-rt/nxp-sdk-5.10/nxp-soc][PATCH 1/1] dmaengine: imx-sdma: 
Fix a build warning in sdma_runtime_resume function
on 19/01/2022 Xiaolei Wang wrote:

> Delete redundant variables 'i' and change disable_clk_ahb to
> disable_clk_ipg to void following warning:
> warning: unused variable 'i' [-Wunused-variable]
> warning: label 'disable_clk_ipg' defined but not used
> 
> Fix commit 2da31cfd59da("dmaengine: imx-sdma: Fix a hang when run dma test in 
> imx8mq board")
> Signed-off-by: Xiaolei Wang 
> ---
>  drivers/dma/imx-sdma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index e61dd499c3dc..c754f2ba3d90 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1639,7 +1639,7 @@ static int sdma_runtime_resume(struct device *dev)
>  {
>   struct platform_device *pdev = to_platform_device(dev);
>   struct sdma_engine *sdma = platform_get_drvdata(pdev);
> - int i, ret = 0;
> + int ret = 0;
>  
>   /* Do nothing at HW level if audiomix which shared with audio driver
>* not off indeed.
> @@ -1723,7 +1723,7 @@ static int sdma_alloc_chan_resources(struct dma_chan 
> *chan)
>   return ret;
>   ret = clk_enable(sdmac->sdma->clk_ahb);
>   if (ret)
> - goto disable_clk_ahb;
> + goto disable_clk_ipg;
>   }
>  
>   ret = sdma_set_channel_priority(sdmac, prio);
> -- 
> 2.25.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#10849): 
https://lists.yoctoproject.org/g/linux-yocto/message/10849
Mute This Topic: https://lists.yoctoproject.org/mt/88529094/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[linux-yocto][linux-yocto v5.10/standard/nxp-sdk-5.10/nxp-soc & v5.10/standard/preempt-rt/nxp-sdk-5.10/nxp-soc][PATCH 1/1] dmaengine: imx-sdma: Fix a build warning in sdma_runtime_resume function

2022-01-18 Thread Xiaolei Wang 
Delete redundant variables 'i' and change disable_clk_ahb to
disable_clk_ipg to void following warning:
warning: unused variable 'i' [-Wunused-variable]
warning: label 'disable_clk_ipg' defined but not used

Fix commit 2da31cfd59da("dmaengine: imx-sdma: Fix a hang when run dma test in 
imx8mq board")
Signed-off-by: Xiaolei Wang 
---
 drivers/dma/imx-sdma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index e61dd499c3dc..c754f2ba3d90 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1639,7 +1639,7 @@ static int sdma_runtime_resume(struct device *dev)
 {
struct platform_device *pdev = to_platform_device(dev);
struct sdma_engine *sdma = platform_get_drvdata(pdev);
-   int i, ret = 0;
+   int ret = 0;
 
/* Do nothing at HW level if audiomix which shared with audio driver
 * not off indeed.
@@ -1723,7 +1723,7 @@ static int sdma_alloc_chan_resources(struct dma_chan 
*chan)
return ret;
ret = clk_enable(sdmac->sdma->clk_ahb);
if (ret)
-   goto disable_clk_ahb;
+   goto disable_clk_ipg;
}
 
ret = sdma_set_channel_priority(sdmac, prio);
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#10845): 
https://lists.yoctoproject.org/g/linux-yocto/message/10845
Mute This Topic: https://lists.yoctoproject.org/mt/88529094/21656
Group Owner: linux-yocto+ow...@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/linux-yocto/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-