Re: [linux-yocto] [PATCH 0/4][3.10] minnow-io feature branch
On Fri, 2013-10-18 at 15:50 -0700, Darren Hart wrote: > Please pull the follow branch as "minnow-io" as a feature-branch into > linux-yocto 3.10. This is an update to the patches in the minnow bsp > meta-data, which will be removed in a subsequent patch series. Bruce, I was modeling this after the emgd driver in an effort to reduce machine-specific branches. But this may not make as much sense as these drivers are only used for this one machine. These could be used just as patches in the minnow-io.scc file rather than a feature branch and a merge command. Do you have a preference? -- Darren > > > The following changes since commit e5596282dc64d597bb3b7808aeec6718b157fbe1: > > kgit: creating baseline state (2013-08-22 14:32:22 -0400) > > are available in the git repository at: > > git://git.yoctoproject.org/linux-yocto-contrib dvhart/minnow-io > > http://git.yoctoproject.org/cgit.cgi/linux-yocto-contrib/log/?h=dvhart/minnow-io > > Darren Hart (4): > gpio-sch: Add sch_gpio_resume_set_enable() > minnowboard: Add base platform driver for the MinnowBoard > minnowboard-gpio: Export MinnowBoard expansion GPIO > minnowboard-keys: Bind MinnowBoard buttons to arrow keys > > drivers/gpio/gpio-sch.c | 24 + > drivers/platform/x86/Kconfig| 52 ++ > drivers/platform/x86/Makefile |3 + > drivers/platform/x86/minnowboard-gpio.c | 108 > drivers/platform/x86/minnowboard-gpio.h | 58 +++ > drivers/platform/x86/minnowboard-keys.c | 101 +++ > drivers/platform/x86/minnowboard.c | 167 > +++ > include/linux/gpio-sch.h|6 ++ > include/linux/minnowboard.h | 37 +++ > 9 files changed, 556 insertions(+) > create mode 100644 drivers/platform/x86/minnowboard-gpio.c > create mode 100644 drivers/platform/x86/minnowboard-gpio.h > create mode 100644 drivers/platform/x86/minnowboard-keys.c > create mode 100644 drivers/platform/x86/minnowboard.c > create mode 100644 include/linux/gpio-sch.h > create mode 100644 include/linux/minnowboard.h > -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel ___ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto
Re: [linux-yocto] [PATCH 0/4][3.10] minnow-io feature branch
On 13-10-19 12:37 PM, Darren Hart wrote: On Fri, 2013-10-18 at 15:50 -0700, Darren Hart wrote: Please pull the follow branch as "minnow-io" as a feature-branch into linux-yocto 3.10. This is an update to the patches in the minnow bsp meta-data, which will be removed in a subsequent patch series. Bruce, I was modeling this after the emgd driver in an effort to reduce machine-specific branches. But this may not make as much sense as these drivers are only used for this one machine. These could be used just as patches in the minnow-io.scc file rather than a feature branch and a merge command. Do you have a preference? I was pondering that while reading the series as well. If there's continued development on a feature branch, and it is really being grafted into the snapshot kernel versions over time, it definitely makes sense. But since you are doing this work the right way, and developing it upstream .. it is likely easier to just do it in the feature .scc as cherry-picked or pending upstream submissions and we'll update and evolve it over time. So if you have the time, can you re-spin the two series with just the patches and a .scc file included by the BSP ? We still can avoid the BSP branch and work directly on standard, since these are safe for all boards. Cheers, Bruce -- Darren The following changes since commit e5596282dc64d597bb3b7808aeec6718b157fbe1: kgit: creating baseline state (2013-08-22 14:32:22 -0400) are available in the git repository at: git://git.yoctoproject.org/linux-yocto-contrib dvhart/minnow-io http://git.yoctoproject.org/cgit.cgi/linux-yocto-contrib/log/?h=dvhart/minnow-io Darren Hart (4): gpio-sch: Add sch_gpio_resume_set_enable() minnowboard: Add base platform driver for the MinnowBoard minnowboard-gpio: Export MinnowBoard expansion GPIO minnowboard-keys: Bind MinnowBoard buttons to arrow keys drivers/gpio/gpio-sch.c | 24 + drivers/platform/x86/Kconfig| 52 ++ drivers/platform/x86/Makefile |3 + drivers/platform/x86/minnowboard-gpio.c | 108 drivers/platform/x86/minnowboard-gpio.h | 58 +++ drivers/platform/x86/minnowboard-keys.c | 101 +++ drivers/platform/x86/minnowboard.c | 167 +++ include/linux/gpio-sch.h|6 ++ include/linux/minnowboard.h | 37 +++ 9 files changed, 556 insertions(+) create mode 100644 drivers/platform/x86/minnowboard-gpio.c create mode 100644 drivers/platform/x86/minnowboard-gpio.h create mode 100644 drivers/platform/x86/minnowboard-keys.c create mode 100644 drivers/platform/x86/minnowboard.c create mode 100644 include/linux/gpio-sch.h create mode 100644 include/linux/minnowboard.h ___ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto
Re: [linux-yocto] [PATCH 0/4][3.10] minnow-io feature branch
On Sat, 2013-10-19 at 22:51 -0400, Bruce Ashfield wrote: > On 13-10-19 12:37 PM, Darren Hart wrote: > > On Fri, 2013-10-18 at 15:50 -0700, Darren Hart wrote: > >> Please pull the follow branch as "minnow-io" as a feature-branch into > >> linux-yocto 3.10. This is an update to the patches in the minnow bsp > >> meta-data, which will be removed in a subsequent patch series. > > > > > > Bruce, > > > > I was modeling this after the emgd driver in an effort to reduce > > machine-specific branches. But this may not make as much sense as these > > drivers are only used for this one machine. These could be used just as > > patches in the minnow-io.scc file rather than a feature branch and a > > merge command. Do you have a preference? > > I was pondering that while reading the series as well. If there's > continued development on a feature branch, and it is really being > grafted into the snapshot kernel versions over time, it definitely > makes sense. > > But since you are doing this work the right way, and developing it > upstream .. it is likely easier to just do it in the feature > .scc as cherry-picked or pending upstream submissions and we'll > update and evolve it over time. > > So if you have the time, can you re-spin the two series with just > the patches and a .scc file included by the BSP ? We still can avoid > the BSP branch and work directly on standard, since these are safe > for all boards. Will do, thanks! -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel ___ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto