Re: [linux-yocto] [yocto-kernel-cache][PATCH v2] common-pc-wifi.cfg: Add CONFIG_BRCMFMAC_PCIE
On 2017-09-15 2:21 PM, California Sullivan wrote: This is needed for some Broadcomm wifi drivers. Signed-off-by: California Sullivan --- Actually applies to 4.9, 4.10, and 4.12 this time. It looks like master is missing "b898385 wifi: drop BRCMFMAC_PROTO_MSGBUF, since it is selected" so that should be applied before this patch. merged (and I just merged yocto-4.12 -> master) so everything is ready for the next kernel versions. Bruce bsp/common-pc/common-pc-wifi.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/bsp/common-pc/common-pc-wifi.cfg b/bsp/common-pc/common-pc-wifi.cfg index 14d82b1..7831abe 100644 --- a/bsp/common-pc/common-pc-wifi.cfg +++ b/bsp/common-pc/common-pc-wifi.cfg @@ -24,6 +24,7 @@ CONFIG_BRCMFMAC=m CONFIG_BRCMFMAC_USB=y CONFIG_BRCMFMAC_SDIO=y CONFIG_BRCMFMAC_PROTO_BCDC=y +CONFIG_BRCMFMAC_PCIE=y CONFIG_WEXT_CORE=y CONFIG_WEXT_PROC=y -- ___ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto
[linux-yocto] [yocto-kernel-cache][PATCH v2] common-pc-wifi.cfg: Add CONFIG_BRCMFMAC_PCIE
This is needed for some Broadcomm wifi drivers. Signed-off-by: California Sullivan --- Actually applies to 4.9, 4.10, and 4.12 this time. It looks like master is missing "b898385 wifi: drop BRCMFMAC_PROTO_MSGBUF, since it is selected" so that should be applied before this patch. bsp/common-pc/common-pc-wifi.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/bsp/common-pc/common-pc-wifi.cfg b/bsp/common-pc/common-pc-wifi.cfg index 14d82b1..7831abe 100644 --- a/bsp/common-pc/common-pc-wifi.cfg +++ b/bsp/common-pc/common-pc-wifi.cfg @@ -24,6 +24,7 @@ CONFIG_BRCMFMAC=m CONFIG_BRCMFMAC_USB=y CONFIG_BRCMFMAC_SDIO=y CONFIG_BRCMFMAC_PROTO_BCDC=y +CONFIG_BRCMFMAC_PCIE=y CONFIG_WEXT_CORE=y CONFIG_WEXT_PROC=y -- 2.9.5 -- ___ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto
Re: [linux-yocto] [yocto-kernel-cache][PATCH] common-pc-wifi.cfg: Add CONFIG_BRCMFMAC_PCIE
On 09/15/2017 08:04 AM, Bruce Ashfield wrote: On 09/14/2017 04:51 PM, California Sullivan wrote: This is needed for some Broadcomm wifi drivers. Signed-off-by: California Sullivan --- This is for yocto-4.9 and newer. I got a reject when applying this to the tip of the yocto-4.9 branch. Can you double check your top commit for that branch ? Oops, I was working off of 4.4 still. I will send a v2. --- Cal Bruce bsp/common-pc/common-pc-wifi.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/bsp/common-pc/common-pc-wifi.cfg b/bsp/common-pc/common-pc-wifi.cfg index 272f912..c2f7d38 100644 --- a/bsp/common-pc/common-pc-wifi.cfg +++ b/bsp/common-pc/common-pc-wifi.cfg @@ -20,6 +20,7 @@ CONFIG_BRCMUTIL=m CONFIG_BRCMSMAC=m CONFIG_BRCMFMAC=m CONFIG_BRCMFMAC_USB=y +CONFIG_BRCMFMAC_PCIE=y CONFIG_WEXT_CORE=y CONFIG_WEXT_PROC=y -- ___ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto
Re: [linux-yocto] [yocto-kernel-cache][PATCH] common-pc-wifi.cfg: Add CONFIG_BRCMFMAC_PCIE
On 09/14/2017 04:51 PM, California Sullivan wrote: This is needed for some Broadcomm wifi drivers. Signed-off-by: California Sullivan --- This is for yocto-4.9 and newer. I got a reject when applying this to the tip of the yocto-4.9 branch. Can you double check your top commit for that branch ? Bruce bsp/common-pc/common-pc-wifi.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/bsp/common-pc/common-pc-wifi.cfg b/bsp/common-pc/common-pc-wifi.cfg index 272f912..c2f7d38 100644 --- a/bsp/common-pc/common-pc-wifi.cfg +++ b/bsp/common-pc/common-pc-wifi.cfg @@ -20,6 +20,7 @@ CONFIG_BRCMUTIL=m CONFIG_BRCMSMAC=m CONFIG_BRCMFMAC=m CONFIG_BRCMFMAC_USB=y +CONFIG_BRCMFMAC_PCIE=y CONFIG_WEXT_CORE=y CONFIG_WEXT_PROC=y -- ___ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto
Re: [linux-yocto] [PATCH] ipv6: Fix expected expression before OR operand error
I've cherry picked the patch, and perf now builds for me.
Bruce
On 09/15/2017 07:32 AM, Dragomir Daniel wrote:
Thanks Bruce!
What about the following error on perf do_compile?
util/string.c: In function 'perf_atoll':
util/string.c:25:4: error: '__fallthrough' undeclared (first use in this
function)
__fallthrough;
^
Is there any patch staged for this one?
The patch which bring this error is:
commit 9de93e56698fe20998d085dccc9c3b20f673149a
tools string: Use __fallthrough in perf_atoll()
The fix is also upstream signed off by the same author. See here:
https://patchwork.openembedded.org/patch/143863/
Regards,
Daniel
On 14.09.2017 19:08, Bruce Ashfield wrote:
I already have a fix staged for this one, the pushed commits
were only for testing purposes.
Cheers,
Bruce
On 09/14/2017 12:14 PM, Daniel Dragomir wrote:
Use parentheses for the entire condition for if statement.
Error introduced by commit
d27e21a ("udp: consistently apply ufo or fragmentation")
| tmp/work-shared/axxiaarm64/kernel-source/net/ipv6/
| ip6_output.c:1343:30: error: expected expression before '||' token
| if (skb && skb_is_gso(skb)) ||
Tested on branches: standard/axxia/base
standard/preempt-rt/axxia/base
Also affected: standard/base
standard/preempt-rt/base
and so on.
Signed-off-by: Daniel Dragomir
---
net/ipv6/ip6_output.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index eb05df0..a6da5fa 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -1340,12 +1340,12 @@ emsgsize:
*/
cork->length += length;
-if (skb && skb_is_gso(skb)) ||
+if ((skb && skb_is_gso(skb)) ||
(((length > mtu) &&
(skb_queue_len(queue) <= 1) &&
(sk->sk_protocol == IPPROTO_UDP) &&
(rt->dst.dev->features & NETIF_F_UFO) &&
-(sk->sk_type == SOCK_DGRAM) && !udp_get_no_check6_tx(sk))) {
+(sk->sk_type == SOCK_DGRAM) && !udp_get_no_check6_tx(sk {
err = ip6_ufo_append_data(sk, queue, getfrag, from, length,
hh_len, fragheaderlen,
transhdrlen, mtu, flags, rt);
--
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto
Re: [linux-yocto] [PATCH] ipv6: Fix expected expression before OR operand error
On 09/15/2017 07:32 AM, Dragomir Daniel wrote:
Thanks Bruce!
What about the following error on perf do_compile?
util/string.c: In function 'perf_atoll':
util/string.c:25:4: error: '__fallthrough' undeclared (first use in this
function)
__fallthrough;
^
Is there any patch staged for this one?
I hadn't done a perf build .. so I missed this one. I'll cherry pick
that patch onto the branches after I fire up a build and see it blow
up myself.
Thanks for pointing this out!
Bruce
The patch which bring this error is:
commit 9de93e56698fe20998d085dccc9c3b20f673149a
tools string: Use __fallthrough in perf_atoll()
The fix is also upstream signed off by the same author. See here:
https://patchwork.openembedded.org/patch/143863/
Regards,
Daniel
On 14.09.2017 19:08, Bruce Ashfield wrote:
I already have a fix staged for this one, the pushed commits
were only for testing purposes.
Cheers,
Bruce
On 09/14/2017 12:14 PM, Daniel Dragomir wrote:
Use parentheses for the entire condition for if statement.
Error introduced by commit
d27e21a ("udp: consistently apply ufo or fragmentation")
| tmp/work-shared/axxiaarm64/kernel-source/net/ipv6/
| ip6_output.c:1343:30: error: expected expression before '||' token
| if (skb && skb_is_gso(skb)) ||
Tested on branches: standard/axxia/base
standard/preempt-rt/axxia/base
Also affected: standard/base
standard/preempt-rt/base
and so on.
Signed-off-by: Daniel Dragomir
---
net/ipv6/ip6_output.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index eb05df0..a6da5fa 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -1340,12 +1340,12 @@ emsgsize:
*/
cork->length += length;
-if (skb && skb_is_gso(skb)) ||
+if ((skb && skb_is_gso(skb)) ||
(((length > mtu) &&
(skb_queue_len(queue) <= 1) &&
(sk->sk_protocol == IPPROTO_UDP) &&
(rt->dst.dev->features & NETIF_F_UFO) &&
-(sk->sk_type == SOCK_DGRAM) && !udp_get_no_check6_tx(sk))) {
+(sk->sk_type == SOCK_DGRAM) && !udp_get_no_check6_tx(sk {
err = ip6_ufo_append_data(sk, queue, getfrag, from, length,
hh_len, fragheaderlen,
transhdrlen, mtu, flags, rt);
--
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto
Re: [linux-yocto] [PATCH] ipv6: Fix expected expression before OR operand error
Thanks Bruce!
What about the following error on perf do_compile?
util/string.c: In function 'perf_atoll':
util/string.c:25:4: error: '__fallthrough' undeclared (first use in this
function)
__fallthrough;
^
Is there any patch staged for this one?
The patch which bring this error is:
commit 9de93e56698fe20998d085dccc9c3b20f673149a
tools string: Use __fallthrough in perf_atoll()
The fix is also upstream signed off by the same author. See here:
https://patchwork.openembedded.org/patch/143863/
Regards,
Daniel
On 14.09.2017 19:08, Bruce Ashfield wrote:
I already have a fix staged for this one, the pushed commits
were only for testing purposes.
Cheers,
Bruce
On 09/14/2017 12:14 PM, Daniel Dragomir wrote:
Use parentheses for the entire condition for if statement.
Error introduced by commit
d27e21a ("udp: consistently apply ufo or fragmentation")
| tmp/work-shared/axxiaarm64/kernel-source/net/ipv6/
| ip6_output.c:1343:30: error: expected expression before '||' token
| if (skb && skb_is_gso(skb)) ||
Tested on branches: standard/axxia/base
standard/preempt-rt/axxia/base
Also affected: standard/base
standard/preempt-rt/base
and so on.
Signed-off-by: Daniel Dragomir
---
net/ipv6/ip6_output.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index eb05df0..a6da5fa 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -1340,12 +1340,12 @@ emsgsize:
*/
cork->length += length;
- if (skb && skb_is_gso(skb)) ||
+ if ((skb && skb_is_gso(skb)) ||
(((length > mtu) &&
(skb_queue_len(queue) <= 1) &&
(sk->sk_protocol == IPPROTO_UDP) &&
(rt->dst.dev->features & NETIF_F_UFO) &&
- (sk->sk_type == SOCK_DGRAM) && !udp_get_no_check6_tx(sk))) {
+ (sk->sk_type == SOCK_DGRAM) && !udp_get_no_check6_tx(sk {
err = ip6_ufo_append_data(sk, queue, getfrag, from, length,
hh_len, fragheaderlen,
transhdrlen, mtu, flags, rt);
--
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto
