Re: [linux-yocto] [PATCH 03/13] ktypes/base: Disable EMBEDDED and DEBUG_KERNEL

2016-02-08 Thread Sullivan, California L
On 02/07/2016 03:17 PM, Paul Gortmaker wrote:
> [[linux-yocto] [PATCH 03/13] ktypes/base: Disable EMBEDDED and DEBUG_KERNEL] 
> On 04/02/2016 (Thu 16:25) California Sullivan wrote:
>
>> DEBUG_KERNEL should not be in the base ktype, as a production kernel
>> may not necessarily want any debug turned on. EMBEDDED is also removed,
>> as EMBEDDED selects EXPERT which selects DEBUG_KERNEL.
>>
>> Signed-off-by: California Sullivan <california.l.sulli...@intel.com>
>> ---
>>  ktypes/base/base.cfg | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/ktypes/base/base.cfg b/ktypes/base/base.cfg
>> index 3b8ccd2..30a3f77 100644
>> --- a/ktypes/base/base.cfg
>> +++ b/ktypes/base/base.cfg
>> @@ -33,7 +33,7 @@ CONFIG_INITRAMFS_SOURCE=""
>>  # Resource Groups
>>  #
>>  CONFIG_SYSCTL=y
>> -CONFIG_EMBEDDED=y
>> +# CONFIG_EMBEDDED is not set
> Guessing this is "default n"  [which is also equivalent to no default
> setting at all].  In which case it probably is best to simply not
> specify it at all here.  That will avoid all the extended users getting
> an override warning at kernel config time.
You are are right about the options defaulting to n, but I want it to be
explicit that the base ktype sets them to off.
I believe the kernel_checkconfig task only looks at the last file that
sets a config option. In my testing of the extended ktype, no warning
was issued.

---
Cal
>
>>  CONFIG_KALLSYMS=y
>>  # CONFIG_KALLSYMS_ALL is not set
>>  CONFIG_FUTEX=y
>> @@ -1011,13 +1011,13 @@ CONFIG_NLS_DEFAULT="iso8859-1"
>>  # Kernel hacking
>>  #
>>  CONFIG_MAGIC_SYSRQ=y
>> -CONFIG_DEBUG_KERNEL=y
>> +# CONFIG_DEBUG_KERNEL is not set
> ...same here.
>
> P.
> --
>
>>  # CONFIG_SCHEDSTATS is not set
>>  # CONFIG_DEBUG_SLAB is not set
>>  # CONFIG_DEBUG_SPINLOCK is not set
>>  # CONFIG_DEBUG_KOBJECT is not set
>>  # CONFIG_DEBUG_HIGHMEM is not set
>> -CONFIG_DEBUG_INFO=y
>> +# CONFIG_DEBUG_INFO is not set
>>  
>>  #
>>  # Security options
>> -- 
>> 2.5.0
>>
>> -- 
>> ___
>> linux-yocto mailing list
>> linux-yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/linux-yocto

-- 
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto


Re: [linux-yocto] [PATCH 03/13] ktypes/base: Disable EMBEDDED and DEBUG_KERNEL

2016-02-07 Thread Paul Gortmaker
[[linux-yocto] [PATCH 03/13] ktypes/base: Disable EMBEDDED and DEBUG_KERNEL] On 
04/02/2016 (Thu 16:25) California Sullivan wrote:

> DEBUG_KERNEL should not be in the base ktype, as a production kernel
> may not necessarily want any debug turned on. EMBEDDED is also removed,
> as EMBEDDED selects EXPERT which selects DEBUG_KERNEL.
> 
> Signed-off-by: California Sullivan <california.l.sulli...@intel.com>
> ---
>  ktypes/base/base.cfg | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ktypes/base/base.cfg b/ktypes/base/base.cfg
> index 3b8ccd2..30a3f77 100644
> --- a/ktypes/base/base.cfg
> +++ b/ktypes/base/base.cfg
> @@ -33,7 +33,7 @@ CONFIG_INITRAMFS_SOURCE=""
>  # Resource Groups
>  #
>  CONFIG_SYSCTL=y
> -CONFIG_EMBEDDED=y
> +# CONFIG_EMBEDDED is not set

Guessing this is "default n"  [which is also equivalent to no default
setting at all].  In which case it probably is best to simply not
specify it at all here.  That will avoid all the extended users getting
an override warning at kernel config time.

>  CONFIG_KALLSYMS=y
>  # CONFIG_KALLSYMS_ALL is not set
>  CONFIG_FUTEX=y
> @@ -1011,13 +1011,13 @@ CONFIG_NLS_DEFAULT="iso8859-1"
>  # Kernel hacking
>  #
>  CONFIG_MAGIC_SYSRQ=y
> -CONFIG_DEBUG_KERNEL=y
> +# CONFIG_DEBUG_KERNEL is not set

...same here.

P.
--

>  # CONFIG_SCHEDSTATS is not set
>  # CONFIG_DEBUG_SLAB is not set
>  # CONFIG_DEBUG_SPINLOCK is not set
>  # CONFIG_DEBUG_KOBJECT is not set
>  # CONFIG_DEBUG_HIGHMEM is not set
> -CONFIG_DEBUG_INFO=y
> +# CONFIG_DEBUG_INFO is not set
>  
>  #
>  # Security options
> -- 
> 2.5.0
> 
> -- 
> ___
> linux-yocto mailing list
> linux-yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/linux-yocto
-- 
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto


[linux-yocto] [PATCH 03/13] ktypes/base: Disable EMBEDDED and DEBUG_KERNEL

2016-02-04 Thread California Sullivan
DEBUG_KERNEL should not be in the base ktype, as a production kernel
may not necessarily want any debug turned on. EMBEDDED is also removed,
as EMBEDDED selects EXPERT which selects DEBUG_KERNEL.

Signed-off-by: California Sullivan 
---
 ktypes/base/base.cfg | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ktypes/base/base.cfg b/ktypes/base/base.cfg
index 3b8ccd2..30a3f77 100644
--- a/ktypes/base/base.cfg
+++ b/ktypes/base/base.cfg
@@ -33,7 +33,7 @@ CONFIG_INITRAMFS_SOURCE=""
 # Resource Groups
 #
 CONFIG_SYSCTL=y
-CONFIG_EMBEDDED=y
+# CONFIG_EMBEDDED is not set
 CONFIG_KALLSYMS=y
 # CONFIG_KALLSYMS_ALL is not set
 CONFIG_FUTEX=y
@@ -1011,13 +1011,13 @@ CONFIG_NLS_DEFAULT="iso8859-1"
 # Kernel hacking
 #
 CONFIG_MAGIC_SYSRQ=y
-CONFIG_DEBUG_KERNEL=y
+# CONFIG_DEBUG_KERNEL is not set
 # CONFIG_SCHEDSTATS is not set
 # CONFIG_DEBUG_SLAB is not set
 # CONFIG_DEBUG_SPINLOCK is not set
 # CONFIG_DEBUG_KOBJECT is not set
 # CONFIG_DEBUG_HIGHMEM is not set
-CONFIG_DEBUG_INFO=y
+# CONFIG_DEBUG_INFO is not set
 
 #
 # Security options
-- 
2.5.0

-- 
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto