Re: [linux-yocto] [PATCH 23/29] x86/byt: Fix device name string for clkdev registration

2014-04-09 Thread Kamble, Nitin A


On 4/7/2014 8:18 AM, rebecca.swee.fun.ch...@intel.com wrote:

From: Maurice Petallo mauricex.r.peta...@intel.com

Use BYT DMA PCI domain:bus:slot.func identification
as device name input during clkdev registration.

Signed-off-by: Maurice Petallo mauricex.r.peta...@intel.com
---
  arch/x86/platform/byt/byt-board.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/platform/byt/byt-board.c 
b/arch/x86/platform/byt/byt-board.c
index be4ed4d..e94a377 100644
--- a/arch/x86/platform/byt/byt-board.c
+++ b/arch/x86/platform/byt/byt-board.c
@@ -47,7 +47,7 @@ static int byt_clk_setup(void)
if (IS_ERR(clk))
return PTR_ERR(clk);
  
-	clk_register_clkdev(clk, hclk, dw_dmac.0);

+   clk_register_clkdev(clk, hclk, :00:1e.0);
Such kind of hard-coded constant addresses are not well received for 
upstreaming. Can this

address instead be deduced at runtime?

Nitin



  
  	clk = clk_register_fixed_rate(NULL, spi_clk, lpss_clk, 0, 5000);

if (IS_ERR(clk))


--
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto


[linux-yocto] [PATCH 23/29] x86/byt: Fix device name string for clkdev registration

2014-04-07 Thread rebecca . swee . fun . chang
From: Maurice Petallo mauricex.r.peta...@intel.com

Use BYT DMA PCI domain:bus:slot.func identification
as device name input during clkdev registration.

Signed-off-by: Maurice Petallo mauricex.r.peta...@intel.com
---
 arch/x86/platform/byt/byt-board.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/platform/byt/byt-board.c 
b/arch/x86/platform/byt/byt-board.c
index be4ed4d..e94a377 100644
--- a/arch/x86/platform/byt/byt-board.c
+++ b/arch/x86/platform/byt/byt-board.c
@@ -47,7 +47,7 @@ static int byt_clk_setup(void)
if (IS_ERR(clk))
return PTR_ERR(clk);
 
-   clk_register_clkdev(clk, hclk, dw_dmac.0);
+   clk_register_clkdev(clk, hclk, :00:1e.0);
 
clk = clk_register_fixed_rate(NULL, spi_clk, lpss_clk, 0, 5000);
if (IS_ERR(clk))
-- 
1.7.10.4

-- 
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto