Re: [linux-yocto] [PATCH v3 00/12] ktype refactoring: move DEBUG_KERNEL, EXPERT and EMBEDDED
On 2016-02-17 7:47 PM, California Sullivan wrote: Targetted for yocto-4.4 and master Sorry for the delay, I've been fighting some 4.4 and 4.1 kernel issues, and bisecting has been taking up my cycles. This looks reasonable to me, I've pulled it into my queue to see if there's any fallout Bruce Changes since last revision: *Removed branch command from developer ktype* Including standard does this already. *Removed "default policy" comment from -developer common-pc BSPs* This was copied from the -standard BSPs and is no longer accurate. I could have changed standard to developer in the comment, but I don't feel comfortable asserting that this is the default policy for developer kernels when more is likely to be added. *Updated commit messages* Explain that standard is now for production in "add developer common-pc BSPs" patch. Fix typo in subject line of "inlcude developer ktype instead of standard" patch. *Patches aren't 00/12* That was embarassing. This patch series refactors the ktypes so that base and standard ktypes do not enable EMBEDDED, EXPERT, or DEBUG_KERNEL. The reason this decision was made is because production platforms likely do not want DEBUG_KERNEL enabled, and EMBEDDED selects EXPERT which selects DEBUG_KERNEL. A new ktype called "developer" was also created. This ktype enables the options now missing from standard and base, making it easy to maintain the functionality of a BSP through simply swapping the ktype from standard to developer. The preempt-rt ktype is now based off of developer in order to maintain its functionality. The new standard ktype does not include EMBEDDED, EXPERT, or DEBUG_KERNEL. Without DEBUG_KERNEL it loses a number of debug features that are selected by default. Without EXPERT it gains RFKILL_INPUT and DEBUG_MEMORY_INIT, while losing VMSPLIT_3G. These are only available to configure with CONFIG_EXPERT=y and default to EXPERT or !EXPERT. Not selecting EMBEDDED has no apparent impacts. Some coordination is required for this change, as existing BSPs WILL be affected, and will either need to accept the changes in the standard ktype or move to the developer ktype. California Sullivan (12): features/debug: add debug-kernel feature ktypes: add developer ktype ktypes/base: Disable EMBEDDED and DEBUG_KERNEL CONFIG_PROCESSOR_SELECT: do not enable intel-common-drivers.scc: move profiling and latencytop to a new file romley.scc remove profiling and latencytop features bsp/intel-common: add intel-core* developer BSPs preempt-rt.scc: include developer ktype instead of standard intel-common: add intel-developer-drivers.scc to preempt-rt BSPs CONFIG_I2C_I801: set option to yes in intel-core* BSPs bsp: add developer common-pc BSPs bsp: remove profiling and latencytop from non-developer common-pc BSPs bsp/common-pc-64/common-pc-64-developer.scc | 16 bsp/common-pc-64/common-pc-64-standard.scc | 2 -- bsp/common-pc/common-pc-developer.scc | 16 bsp/common-pc/common-pc-standard.scc| 2 -- bsp/haswell-wc/haswell-wc.cfg | 2 +- bsp/intel-common/intel-common-drivers.scc | 2 -- bsp/intel-common/intel-core2-32-developer.scc | 14 ++ bsp/intel-common/intel-core2-32-preempt-rt.scc | 1 + bsp/intel-common/intel-core2-32.cfg | 1 - bsp/intel-common/intel-corei7-64-developer.scc | 13 + bsp/intel-common/intel-corei7-64-preempt-rt.scc | 1 + bsp/intel-common/intel-developer-drivers.scc| 3 +++ bsp/mohonpeak/mohonpeak.cfg | 2 +- bsp/romley/romley.scc | 3 --- cfg/amd.cfg | 1 - cfg/intel.cfg | 2 -- features/debug/debug-kernel.cfg | 3 +++ features/debug/debug-kernel.scc | 5 + features/debug/printk.scc | 1 + features/latencytop/latencytop.scc | 3 +++ features/profiling/profiling.scc| 2 ++ features/soc/baytrail/baytrail.cfg | 2 +- ktypes/base/base.cfg| 6 +++--- ktypes/developer/developer.cfg | 19 +++ ktypes/developer/developer.scc | 9 + ktypes/preempt-rt/preempt-rt.scc| 2 +- 26 files changed, 113 insertions(+), 20 deletions(-) create mode 100644 bsp/common-pc-64/common-pc-64-developer.scc create mode 100644 bsp/common-pc/common-pc-developer.scc create mode 100644 bsp/intel-common/intel-core2-32-developer.scc create mode 100644 bsp/intel-common/intel-corei7-64-developer.scc create mode 100644 bsp/intel-common/intel-developer-drivers.scc create mode 100644 features/debug/debug-kernel.cfg create mode 100644 features/debug/debug-kernel.scc create mode 100644 ktypes/developer/developer.cfg create mode 100644
[linux-yocto] [PATCH v3 00/12] ktype refactoring: move DEBUG_KERNEL, EXPERT and EMBEDDED
Targetted for yocto-4.4 and master Changes since last revision: *Removed branch command from developer ktype* Including standard does this already. *Removed "default policy" comment from -developer common-pc BSPs* This was copied from the -standard BSPs and is no longer accurate. I could have changed standard to developer in the comment, but I don't feel comfortable asserting that this is the default policy for developer kernels when more is likely to be added. *Updated commit messages* Explain that standard is now for production in "add developer common-pc BSPs" patch. Fix typo in subject line of "inlcude developer ktype instead of standard" patch. *Patches aren't 00/12* That was embarassing. This patch series refactors the ktypes so that base and standard ktypes do not enable EMBEDDED, EXPERT, or DEBUG_KERNEL. The reason this decision was made is because production platforms likely do not want DEBUG_KERNEL enabled, and EMBEDDED selects EXPERT which selects DEBUG_KERNEL. A new ktype called "developer" was also created. This ktype enables the options now missing from standard and base, making it easy to maintain the functionality of a BSP through simply swapping the ktype from standard to developer. The preempt-rt ktype is now based off of developer in order to maintain its functionality. The new standard ktype does not include EMBEDDED, EXPERT, or DEBUG_KERNEL. Without DEBUG_KERNEL it loses a number of debug features that are selected by default. Without EXPERT it gains RFKILL_INPUT and DEBUG_MEMORY_INIT, while losing VMSPLIT_3G. These are only available to configure with CONFIG_EXPERT=y and default to EXPERT or !EXPERT. Not selecting EMBEDDED has no apparent impacts. Some coordination is required for this change, as existing BSPs WILL be affected, and will either need to accept the changes in the standard ktype or move to the developer ktype. California Sullivan (12): features/debug: add debug-kernel feature ktypes: add developer ktype ktypes/base: Disable EMBEDDED and DEBUG_KERNEL CONFIG_PROCESSOR_SELECT: do not enable intel-common-drivers.scc: move profiling and latencytop to a new file romley.scc remove profiling and latencytop features bsp/intel-common: add intel-core* developer BSPs preempt-rt.scc: include developer ktype instead of standard intel-common: add intel-developer-drivers.scc to preempt-rt BSPs CONFIG_I2C_I801: set option to yes in intel-core* BSPs bsp: add developer common-pc BSPs bsp: remove profiling and latencytop from non-developer common-pc BSPs bsp/common-pc-64/common-pc-64-developer.scc | 16 bsp/common-pc-64/common-pc-64-standard.scc | 2 -- bsp/common-pc/common-pc-developer.scc | 16 bsp/common-pc/common-pc-standard.scc| 2 -- bsp/haswell-wc/haswell-wc.cfg | 2 +- bsp/intel-common/intel-common-drivers.scc | 2 -- bsp/intel-common/intel-core2-32-developer.scc | 14 ++ bsp/intel-common/intel-core2-32-preempt-rt.scc | 1 + bsp/intel-common/intel-core2-32.cfg | 1 - bsp/intel-common/intel-corei7-64-developer.scc | 13 + bsp/intel-common/intel-corei7-64-preempt-rt.scc | 1 + bsp/intel-common/intel-developer-drivers.scc| 3 +++ bsp/mohonpeak/mohonpeak.cfg | 2 +- bsp/romley/romley.scc | 3 --- cfg/amd.cfg | 1 - cfg/intel.cfg | 2 -- features/debug/debug-kernel.cfg | 3 +++ features/debug/debug-kernel.scc | 5 + features/debug/printk.scc | 1 + features/latencytop/latencytop.scc | 3 +++ features/profiling/profiling.scc| 2 ++ features/soc/baytrail/baytrail.cfg | 2 +- ktypes/base/base.cfg| 6 +++--- ktypes/developer/developer.cfg | 19 +++ ktypes/developer/developer.scc | 9 + ktypes/preempt-rt/preempt-rt.scc| 2 +- 26 files changed, 113 insertions(+), 20 deletions(-) create mode 100644 bsp/common-pc-64/common-pc-64-developer.scc create mode 100644 bsp/common-pc/common-pc-developer.scc create mode 100644 bsp/intel-common/intel-core2-32-developer.scc create mode 100644 bsp/intel-common/intel-corei7-64-developer.scc create mode 100644 bsp/intel-common/intel-developer-drivers.scc create mode 100644 features/debug/debug-kernel.cfg create mode 100644 features/debug/debug-kernel.scc create mode 100644 ktypes/developer/developer.cfg create mode 100644 ktypes/developer/developer.scc -- 2.5.0 -- ___ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto