Re: [linux-yocto] [PATCH] mips: kernel: Move cc-disable-warning assignments down to avoid being overwritten
On 2018-06-18 10:38 PM, He Zhe wrote: On 2018年06月17日 15:22, Kevin Hao wrote: On Fri, Jun 15, 2018 at 07:12:09AM -0700, He Zhe wrote: cc-disable-warning assignments could be overwritten by CFLAGS_DSP and thus causes the follow build error with GCC 8.1.0. Move them down to the bottom. In file included from arch/mips/kernel/signal32.c:15: include/linux/syscalls.h:233:18: error: 'sys_32_sigaction' alias between functions of incompatible types 'long int(long int, const struct compat_sigaction *, struct compat_sigaction *)' and 'long int(long int, long int, long int)' [-Werror=attribute-alias] asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ ^~~ I have sent a patch [1] to fix this issue and it has been merged into linux-yocto several days ago. [1] https://lists.yoctoproject.org/pipermail/linux-yocto/2018-June/007140.html But it has not gone into linux-yocto-dev. Bruce, When will it be there? I was working with 4.18 and hadn't pushed it yet. But I just updated linux-yocto-dev to v4.17 and have merged that patch as well. So everything should be in place now. Bruce Thanks, Zhe Thanks, Kevin Signed-off-by: He Zhe --- arch/mips/kernel/Makefile | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/mips/kernel/Makefile b/arch/mips/kernel/Makefile index 795aa4c9ef7f..0234db5e0a98 100644 --- a/arch/mips/kernel/Makefile +++ b/arch/mips/kernel/Makefile @@ -2,10 +2,6 @@ # # Makefile for the Linux/MIPS kernel. # -CFLAGS_signal.o+= $(call cc-disable-warning, attribute-alias) -CFLAGS_syscall.o += $(call cc-disable-warning, attribute-alias) -CFLAGS_linux32.o += $(call cc-disable-warning, attribute-alias) -CFLAGS_signal32.o += $(call cc-disable-warning, attribute-alias) extra-y := head.o vmlinux.lds @@ -135,4 +131,9 @@ CFLAGS_branch.o = $(CFLAGS_DSP) CFLAGS_ptrace.o = $(CFLAGS_DSP) endif +CFLAGS_signal.o += $(call cc-disable-warning, attribute-alias) +CFLAGS_syscall.o += $(call cc-disable-warning, attribute-alias) +CFLAGS_linux32.o += $(call cc-disable-warning, attribute-alias) +CFLAGS_signal32.o += $(call cc-disable-warning, attribute-alias) + CPPFLAGS_vmlinux.lds := $(KBUILD_CFLAGS) -- 2.11.0 -- ___ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto -- ___ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto
Re: [linux-yocto] [PATCH] mips: kernel: Move cc-disable-warning assignments down to avoid being overwritten
On 2018年06月17日 15:22, Kevin Hao wrote: > On Fri, Jun 15, 2018 at 07:12:09AM -0700, He Zhe wrote: >> cc-disable-warning assignments could be overwritten by CFLAGS_DSP and thus >> causes the follow build error with GCC 8.1.0. Move them down to the bottom. >> >> In file included from arch/mips/kernel/signal32.c:15: >> include/linux/syscalls.h:233:18: error: 'sys_32_sigaction' alias between >> functions of incompatible types 'long int(long int, const struct >> compat_sigaction *, struct compat_sigaction *)' and 'long int(long int, >> long int, long int)' [-Werror=attribute-alias] >> asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ >> ^~~ > I have sent a patch [1] to fix this issue and it has been merged into > linux-yocto > several days ago. > > [1] > https://lists.yoctoproject.org/pipermail/linux-yocto/2018-June/007140.html But it has not gone into linux-yocto-dev. Bruce, When will it be there? Thanks, Zhe > > Thanks, > Kevin > >> Signed-off-by: He Zhe >> --- >> arch/mips/kernel/Makefile | 9 + >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/arch/mips/kernel/Makefile b/arch/mips/kernel/Makefile >> index 795aa4c9ef7f..0234db5e0a98 100644 >> --- a/arch/mips/kernel/Makefile >> +++ b/arch/mips/kernel/Makefile >> @@ -2,10 +2,6 @@ >> # >> # Makefile for the Linux/MIPS kernel. >> # >> -CFLAGS_signal.o += $(call cc-disable-warning, attribute-alias) >> -CFLAGS_syscall.o+= $(call cc-disable-warning, attribute-alias) >> -CFLAGS_linux32.o+= $(call cc-disable-warning, attribute-alias) >> -CFLAGS_signal32.o += $(call cc-disable-warning, attribute-alias) >> >> extra-y := head.o vmlinux.lds >> >> @@ -135,4 +131,9 @@ CFLAGS_branch.o = $(CFLAGS_DSP) >> CFLAGS_ptrace.o = $(CFLAGS_DSP) >> endif >> >> +CFLAGS_signal.o += $(call cc-disable-warning, attribute-alias) >> +CFLAGS_syscall.o+= $(call cc-disable-warning, attribute-alias) >> +CFLAGS_linux32.o+= $(call cc-disable-warning, attribute-alias) >> +CFLAGS_signal32.o += $(call cc-disable-warning, attribute-alias) >> + >> CPPFLAGS_vmlinux.lds:= $(KBUILD_CFLAGS) >> -- >> 2.11.0 >> >> -- >> ___ >> linux-yocto mailing list >> linux-yocto@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/linux-yocto -- ___ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto
Re: [linux-yocto] [PATCH] mips: kernel: Move cc-disable-warning assignments down to avoid being overwritten
On Fri, Jun 15, 2018 at 07:12:09AM -0700, He Zhe wrote: > cc-disable-warning assignments could be overwritten by CFLAGS_DSP and thus > causes the follow build error with GCC 8.1.0. Move them down to the bottom. > > In file included from arch/mips/kernel/signal32.c:15: > include/linux/syscalls.h:233:18: error: 'sys_32_sigaction' alias between > functions of incompatible types 'long int(long int, const struct > compat_sigaction *, struct compat_sigaction *)' and 'long int(long int, long > int, long int)' [-Werror=attribute-alias] > asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ > ^~~ I have sent a patch [1] to fix this issue and it has been merged into linux-yocto several days ago. [1] https://lists.yoctoproject.org/pipermail/linux-yocto/2018-June/007140.html Thanks, Kevin > > Signed-off-by: He Zhe > --- > arch/mips/kernel/Makefile | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/mips/kernel/Makefile b/arch/mips/kernel/Makefile > index 795aa4c9ef7f..0234db5e0a98 100644 > --- a/arch/mips/kernel/Makefile > +++ b/arch/mips/kernel/Makefile > @@ -2,10 +2,6 @@ > # > # Makefile for the Linux/MIPS kernel. > # > -CFLAGS_signal.o += $(call cc-disable-warning, attribute-alias) > -CFLAGS_syscall.o += $(call cc-disable-warning, attribute-alias) > -CFLAGS_linux32.o += $(call cc-disable-warning, attribute-alias) > -CFLAGS_signal32.o+= $(call cc-disable-warning, attribute-alias) > > extra-y := head.o vmlinux.lds > > @@ -135,4 +131,9 @@ CFLAGS_branch.o = $(CFLAGS_DSP) > CFLAGS_ptrace.o = $(CFLAGS_DSP) > endif > > +CFLAGS_signal.o += $(call cc-disable-warning, attribute-alias) > +CFLAGS_syscall.o += $(call cc-disable-warning, attribute-alias) > +CFLAGS_linux32.o += $(call cc-disable-warning, attribute-alias) > +CFLAGS_signal32.o+= $(call cc-disable-warning, attribute-alias) > + > CPPFLAGS_vmlinux.lds := $(KBUILD_CFLAGS) > -- > 2.11.0 > > -- > ___ > linux-yocto mailing list > linux-yocto@yoctoproject.org > https://lists.yoctoproject.org/listinfo/linux-yocto signature.asc Description: PGP signature -- ___ linux-yocto mailing list linux-yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/linux-yocto
