Re: [LinuxBIOS] [PATCH] Common code base for Intel 440BX boards

2007-10-20 Thread Stefan Reinauer
Uwe Hermann wrote:
 Hi,

 here's a patch which unifies all 440BX boards to use the same (board)
 code base, similar to what the GX1-base patch does (which I sent earlier).

 This code supports 4 boards right now, more will follow.

 The only v2 440BX board not yet supported is the Bitworks IMS. IMO we
 can drop it for now, AFAIK Richard is no longer working on it, it's
 not useful as reference anymore (as this new code works fine now),
 and AFAIK the v2 version of the IMS never worked anyway. It's also a
 special-purpose board (not generally available in stores) and in the
 case we still need it later, the history remains in svn, of course.

 Richard is CC'd. Please let us know if you intend to work on the board
 later, or whether we should drop it from v2 (it'll stay in v1).


 Thanks, Uwe.
   
Please put generic 440 code in northbridge/, and not in mainboard/440-base/

Having two northbridge directories for the same northbridge sounds complex.


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
  Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [EMAIL PROTECTED]  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866


-- 
linuxbios mailing list
linuxbios@linuxbios.org
http://www.linuxbios.org/mailman/listinfo/linuxbios

Re: [LinuxBIOS] [PATCH] Common code base for Intel 440BX boards

2007-10-20 Thread Uwe Hermann
On Sat, Oct 20, 2007 at 08:44:57PM +0200, Stefan Reinauer wrote:
 Please put generic 440 code in northbridge/, and not in mainboard/440-base/
 
 Having two northbridge directories for the same northbridge sounds complex.

Full ack. Northbridge-specific code belongs in src/northbridge/*.

However, this is not northbridge specific code. It's more like common
code which somewhat similar mainboards share. Theoretically this could
include even more (non-440BX) boards which are also similar enough, but
for now I concentrated on 440BX boards.

If we later add non-440bx boards (e.g. 430TX or i810 or something) to
the same framework, we might rename it to xyz-base (but I have no idea
what a good name for xyz would be ;-)

Also, I'm a bit undecided if it should be 
 src/mainboard/common/i440bx-base
or 
 src/mainboard/i440bx-base
(i.e. put the base code parts in an extra directory or not). Opinions?


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org


signature.asc
Description: Digital signature
-- 
linuxbios mailing list
linuxbios@linuxbios.org
http://www.linuxbios.org/mailman/listinfo/linuxbios

Re: [LinuxBIOS] [PATCH] BCOM WinNET100 improvements

2007-10-20 Thread Kenji Noguchi
How about ACPI?  Though it's too early to worry about ACPI
it needs SMI.

-kenji

2007/10/20, Juergen Beisert [EMAIL PROTECTED]:
 Hi Uwe,

 On Sunday 14 October 2007 19:10, Uwe Hermann wrote:
  Btw, do we need to (or want to) enable the SMI PCI device? I guess not
  as we don't use the VSA(?) Do we need it for the VSA-less audio driver?

 For VSA-less audio it would be required. But maybe the audio itself is not
 required...

  Btw, Juergen, can you please attach a license to your photos in the
  wiki? GPL or CC or public domain, whatever. There are templates such as
  {{GPL}} or {{PD-self}} etc.

 Yes, I will.

 Juergen

 --
 linuxbios mailing list
 linuxbios@linuxbios.org
 http://www.linuxbios.org/mailman/listinfo/linuxbios


-- 
linuxbios mailing list
linuxbios@linuxbios.org
http://www.linuxbios.org/mailman/listinfo/linuxbios


Re: [LinuxBIOS] [PATCH] Common code base for Intel 440BX boards

2007-10-20 Thread joe
Quoting Uwe Hermann [EMAIL PROTECTED]:

 On Sat, Oct 20, 2007 at 08:44:57PM +0200, Stefan Reinauer wrote:
 Please put generic 440 code in northbridge/, and not in mainboard/440-base/

 Having two northbridge directories for the same northbridge sounds complex.

 Full ack. Northbridge-specific code belongs in src/northbridge/*.

 However, this is not northbridge specific code. It's more like common
 code which somewhat similar mainboards share. Theoretically this could
 include even more (non-440BX) boards which are also similar enough, but
 for now I concentrated on 440BX boards.

 If we later add non-440bx boards (e.g. 430TX or i810 or something) to
 the same framework, we might rename it to xyz-base (but I have no idea
 what a good name for xyz would be ;-)

 Also, I'm a bit undecided if it should be
  src/mainboard/common/i440bx-base
 or
  src/mainboard/i440bx-base
 (i.e. put the base code parts in an extra directory or not). Opinions?


 Uwe.

Why couldn't there just be a src/northbridge/intel/common/ directory?


Thanks - Joe

-- 
linuxbios mailing list
linuxbios@linuxbios.org
http://www.linuxbios.org/mailman/listinfo/linuxbios


Re: [LinuxBIOS] [PATCH] Common code base for Intel 440BX boards

2007-10-20 Thread Uwe Hermann
On Sat, Oct 20, 2007 at 05:13:45PM -0400, [EMAIL PROTECTED] wrote:
 Quoting Uwe Hermann [EMAIL PROTECTED]:
 
  On Sat, Oct 20, 2007 at 08:44:57PM +0200, Stefan Reinauer wrote:
  Please put generic 440 code in northbridge/, and not in mainboard/440-base/
 
  Having two northbridge directories for the same northbridge sounds complex.
 
  Full ack. Northbridge-specific code belongs in src/northbridge/*.
 
  However, this is not northbridge specific code. It's more like common
  code which somewhat similar mainboards share. Theoretically this could
  include even more (non-440BX) boards which are also similar enough, but
  for now I concentrated on 440BX boards.
 
  If we later add non-440bx boards (e.g. 430TX or i810 or something) to
  the same framework, we might rename it to xyz-base (but I have no idea
  what a good name for xyz would be ;-)
 
  Also, I'm a bit undecided if it should be
   src/mainboard/common/i440bx-base
  or
   src/mainboard/i440bx-base
  (i.e. put the base code parts in an extra directory or not). Opinions?
 
 
  Uwe.
 
 Why couldn't there just be a src/northbridge/intel/common/ directory?

Well, maybe there could -- for Intel northbridge-specific stuff. But the
code in my patch is not specific for any northbridge. It's common
mainboard code.

Actually, on the long run (i.e. v3), if we're good we could go even one
step further and have only _one_ mainboard code directory for all boards.

Everything mainboard-specific would then be extactly _one_ file (quite
likely the dts, which we already have), which only contains data (no code).

Basically, the file could just say

 - Use northbridge xyz
 - Use southbridge xyz
 - Use superio xyz
   - Use Super I/O port 0x4e
 - Use this PIRQ table (a bunch of numbers in the dts)
 - Use this CMOS layout (a bunch of lines in dts)
 - Set option yxz (e.g. enable IDE1, disable floppy, etc)

All of this can be done with a plain text/config file (such as the dts),
no need for _any_ code per mainboard.

We're already moving in this very direction with the dts, and it would be
really great if we could make v3 boards consist of only one (data) file.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org


signature.asc
Description: Digital signature
-- 
linuxbios mailing list
linuxbios@linuxbios.org
http://www.linuxbios.org/mailman/listinfo/linuxbios

[LinuxBIOS] r2878 - trunk/LinuxBIOSv2/src/northbridge/amd/lx

2007-10-20 Thread svn
Author: rminnich
Date: 2007-10-21 05:51:06 +0200 (Sun, 21 Oct 2007)
New Revision: 2878

Modified:
   trunk/LinuxBIOSv2/src/northbridge/amd/lx/pll_reset.c
Log:
I am signing off and acking this trivial patch, as I just wasted several
days on a function named pll_reset that, on exit, says Done
cpuRegInit, and which, in turn, made me think it was a lot farther
along that it was. 

Signed-off-by: Ronald G. Minnich [EMAIL PROTECTED]
Acked-by: Ronald G. Minnich [EMAIL PROTECTED]



Modified: trunk/LinuxBIOSv2/src/northbridge/amd/lx/pll_reset.c
===
--- trunk/LinuxBIOSv2/src/northbridge/amd/lx/pll_reset.c2007-10-19 
18:07:59 UTC (rev 2877)
+++ trunk/LinuxBIOSv2/src/northbridge/amd/lx/pll_reset.c2007-10-21 
03:51:06 UTC (rev 2878)
@@ -68,7 +68,7 @@
__asm__ __volatile__(hlt\n);
 
}
-   print_debug(Done cpuRegInit\n);
+   print_debug(Done pll_reset\r\n);
return;
 }
 


-- 
linuxbios mailing list
linuxbios@linuxbios.org
http://www.linuxbios.org/mailman/listinfo/linuxbios


[LinuxBIOS] r2879 - trunk/LinuxBIOSv2/src/cpu/amd/model_lx

2007-10-20 Thread svn
Author: rminnich
Date: 2007-10-21 06:33:02 +0200 (Sun, 21 Oct 2007)
New Revision: 2879

Modified:
   trunk/LinuxBIOSv2/src/cpu/amd/model_lx/cpureginit.c
Log:
Put the print in the right place. This is trivial patch but a very
serious issue, so I am self-acking.

Signed-off-by: Ronald G. Minnich [EMAIL PROTECTED]
Acked-by: Ronald G. Minnich [EMAIL PROTECTED]



Modified: trunk/LinuxBIOSv2/src/cpu/amd/model_lx/cpureginit.c
===
--- trunk/LinuxBIOSv2/src/cpu/amd/model_lx/cpureginit.c 2007-10-21 03:51:06 UTC 
(rev 2878)
+++ trunk/LinuxBIOSv2/src/cpu/amd/model_lx/cpureginit.c 2007-10-21 04:33:02 UTC 
(rev 2879)
@@ -290,4 +290,5 @@
msr.hi = 0;
msr.lo = 0x0603C;
wrmsr(msrnum, msr);
+   print_debug(Done cpuRegInit\r\n);
 }


-- 
linuxbios mailing list
linuxbios@linuxbios.org
http://www.linuxbios.org/mailman/listinfo/linuxbios


[LinuxBIOS] r2878 build service

2007-10-20 Thread LinuxBIOS information
Dear LinuxBIOS readers!

This is the automated build check service of LinuxBIOS.

The developer rminnich checked in revision 2878 to
the LinuxBIOS source repository and caused the following 
changes:

Change Log:
I am signing off and acking this trivial patch, as I just wasted several
days on a function named pll_reset that, on exit, says Done
cpuRegInit, and which, in turn, made me think it was a lot farther
along that it was.

Signed-off-by: Ronald G. Minnich [EMAIL PROTECTED]
Acked-by: Ronald G. Minnich [EMAIL PROTECTED]



Build Log:
Compilation of arima:hdama is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2878device=hdamavendor=arima
Configuration of bcom:winnet100 is still broken
Compilation of ibm:e325 is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2878device=e325vendor=ibm
Compilation of ibm:e326 is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2878device=e326vendor=ibm
Compilation of iei:juki-511p is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2878device=juki-511pvendor=iei
Compilation of iwill:dk8s2 is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2878device=dk8s2vendor=iwill
Compilation of iwill:dk8x is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2878device=dk8xvendor=iwill
Compilation of newisys:khepri is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2878device=kheprivendor=newisys


If something broke during this checkin please be a pain 
in rminnich's neck until the issue is fixed.

If this issue is not fixed within 24h the revision should 
be backed out.

   Best regards,
 LinuxBIOS automatic build system



-- 
linuxbios mailing list
linuxbios@linuxbios.org
http://www.linuxbios.org/mailman/listinfo/linuxbios


[LinuxBIOS] r2879 build service

2007-10-20 Thread LinuxBIOS information
Dear LinuxBIOS readers!

This is the automated build check service of LinuxBIOS.

The developer rminnich checked in revision 2879 to
the LinuxBIOS source repository and caused the following 
changes:

Change Log:
Put the print in the right place. This is trivial patch but a very
serious issue, so I am self-acking.

Signed-off-by: Ronald G. Minnich [EMAIL PROTECTED]
Acked-by: Ronald G. Minnich [EMAIL PROTECTED]



Build Log:
Compilation of arima:hdama is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2879device=hdamavendor=arima
Configuration of bcom:winnet100 is still broken
Compilation of ibm:e325 is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2879device=e325vendor=ibm
Compilation of ibm:e326 is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2879device=e326vendor=ibm
Compilation of iei:juki-511p is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2879device=juki-511pvendor=iei
Compilation of iwill:dk8s2 is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2879device=dk8s2vendor=iwill
Compilation of iwill:dk8x is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2879device=dk8xvendor=iwill
Compilation of newisys:khepri is still broken
See the error log at 
http://qa.linuxbios.org/log_buildbrd.php?revision=2879device=kheprivendor=newisys


If something broke during this checkin please be a pain 
in rminnich's neck until the issue is fixed.

If this issue is not fixed within 24h the revision should 
be backed out.

   Best regards,
 LinuxBIOS automatic build system



-- 
linuxbios mailing list
linuxbios@linuxbios.org
http://www.linuxbios.org/mailman/listinfo/linuxbios