Re: [PATCH] powerpc: enable heap randomization for linkstations
Hi again. On Oct 18 2008, Rogério Brito wrote: > And it seems that there is something not quite right for these embedded > systems. Here is something that I get with a vanilla linkstation_defconfig: > > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - > drivers/rtc/hctosys.c: unable to open rtc device (rtc0) > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - (...) > I just saw that in the default config: > > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - > # CONFIG_PPC_CLOCK is not set > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - > > Maybe this should be enabled? I can iterate once more to see if this > option would make any difference here. Even if I enable this option, I still get the same problem as above. :-( Regards, Rogério Brito. -- Rogério Brito : [EMAIL PROTECTED],ime.usp}.br : GPG key 1024D/7C2CAEB8 http://www.ime.usp.br/~rbrito : http://meusite.mackenzie.com.br/rbrito Projects: algorithms.berlios.de : lame.sf.net : vrms.alioth.debian.org ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: enable heap randomization for linkstations
Hi. On Oct 13 2008, Scott Wood wrote: > On Mon, Oct 13, 2008 at 08:05:09PM +0200, Guennadi Liakhovetski wrote: > > On Mon, 13 Oct 2008, Rogério Brito wrote: > > > The current defconfig for Linkstation/Kuroboxes has the "Disable > > > Heap Randomization" option enabled. > > > > > > Since some of these machines are facing the internet, it helps to > > > have heap randomization enabled. This patch enables it. > > > > Same as the previous patch - this is one of options, that users > > select according to their needs. If any specific distribution > > enables this option by default in their kernels, they can do this > > too, don't think this is critical enough to patch the defconfig. I guess, Guennadi, that this is questionable. Many people would base their configs on the defconfig. Also, the defconfig has many questionable settings for an embedded platform like the Kurobox. And it seems that there is something not quite right for these embedded systems. Here is something that I get with a vanilla linkstation_defconfig: - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - drivers/rtc/hctosys.c: unable to open rtc device (rtc0) - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - This gets me (with bootlogd enabled): - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Wed Dec 31 21:00:15 1969: Cannot access the Hardware Clock via any known method. Wed Dec 31 21:00:15 1969: Use the --debug option to see the details of our search for an access method. Wed Dec 31 21:00:15 1969: Unable to set System Clock to: Thu Jan 1 00:00:15 UTC 1970 ^[[33m(warning).^[[39;49m - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - I just saw that in the default config: - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - # CONFIG_PPC_CLOCK is not set - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Maybe this should be enabled? I can iterate once more to see if this option would make any difference here. > Just because users/distros can change it doesn't mean it's pointless > to discuss what default is sane, and make changes if the current > default isn't. 100% agreed again, Scott. To repeat myself here, I think that the defconfig should show the users the best current practices. > For security-related options it's usually best to default to the more > secure state, especially since the option description talks about it > being needed mainly for libc5 compatibility -- did libc5 ever even > exist for powerpc? > > The only reason it was turned on in the first place was likely the > "default y", which in turn is there to avoid breaking old x86 distros. I'm including both Paul and BenH here. Regards, Rogério Brito. -- Rogério Brito : [EMAIL PROTECTED],ime.usp}.br : GPG key 1024D/7C2CAEB8 http://www.ime.usp.br/~rbrito : http://meusite.mackenzie.com.br/rbrito Projects: algorithms.berlios.de : lame.sf.net : vrms.alioth.debian.org ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] Add new framebuffer driver for Fujitsu MB862xx GDCs
On Tue, 14 Oct 2008 17:25:06 +0200 Anatolij Gustschin <[EMAIL PROTECTED]> wrote: > This patch adds framebuffer driver for Fujitsu > Carmine/Coral-P(A)/Lime graphics controllers. > Lime GDC support is known to work on PPC440EPx > based lwmon5 and MPC8544E based socrates embedded > boards, both equipped with Lime GDC. Carmine/Coral-P > PCI GDC support is known to work on PPC440EPx based > Sequoia board and also on x86 platform. i386 allmodconfig: drivers/video/mb862xx/mb862xxfb.h:65:2: error: #error "Select Lime GDC or CoralP/Carmine support, but not both together" drivers/video/mb862xx/mb862xxfb.c:549: warning: 'struct of_device' declared inside parameter list drivers/video/mb862xx/mb862xxfb.c:549: warning: its scope is only this definition or declaration, which is probably not what you want drivers/video/mb862xx/mb862xxfb.c: In function 'of_platform_mb862xx_probe': drivers/video/mb862xx/mb862xxfb.c:551: error: dereferencing pointer to incomplete type drivers/video/mb862xx/mb862xxfb.c:552: error: dereferencing pointer to incomplete type drivers/video/mb862xx/mb862xxfb.c:559: error: implicit declaration of function 'of_address_to_resource' drivers/video/mb862xx/mb862xxfb.c:574: error: implicit declaration of function 'irq_of_parse_and_map' drivers/video/mb862xx/mb862xxfb.c:575: error: 'NO_IRQ' undeclared (first use in this function) drivers/video/mb862xx/mb862xxfb.c:575: error: (Each undeclared identifier is reported only once drivers/video/mb862xx/mb862xxfb.c:575: error: for each function it appears in.) drivers/video/mb862xx/mb862xxfb.c:664: error: implicit declaration of function 'irq_dispose_mapping' drivers/video/mb862xx/mb862xxfb.c: At top level: drivers/video/mb862xx/mb862xxfb.c:671: warning: 'struct of_device' declared inside parameter list drivers/video/mb862xx/mb862xxfb.c: In function 'of_platform_mb862xx_remove': drivers/video/mb862xx/mb862xxfb.c:673: error: dereferencing pointer to incomplete type drivers/video/mb862xx/mb862xxfb.c:691: error: dereferencing pointer to incomplete type drivers/video/mb862xx/mb862xxfb.c:699: error: dereferencing pointer to incomplete type drivers/video/mb862xx/mb862xxfb.c: At top level: drivers/video/mb862xx/mb862xxfb.c:719: error: variable 'of_platform_mb862xxfb_driver' has initializer but incomplete type drivers/video/mb862xx/mb862xxfb.c:720: error: unknown field 'owner' specified in initializer drivers/video/mb862xx/mb862xxfb.c:720: warning: excess elements in struct initializer drivers/video/mb862xx/mb862xxfb.c:720: warning: (near initialization for 'of_platform_mb862xxfb_driver') drivers/video/mb862xx/mb862xxfb.c:721: error: unknown field 'name' specified in initializer drivers/video/mb862xx/mb862xxfb.c:721: warning: excess elements in struct initializer drivers/video/mb862xx/mb862xxfb.c:721: warning: (near initialization for 'of_platform_mb862xxfb_driver') drivers/video/mb862xx/mb862xxfb.c:722: error: unknown field 'match_table' specified in initializer drivers/video/mb862xx/mb862xxfb.c:722: warning: excess elements in struct initializer drivers/video/mb862xx/mb862xxfb.c:722: warning: (near initialization for 'of_platform_mb862xxfb_driver') drivers/video/mb862xx/mb862xxfb.c:723: error: unknown field 'probe' specified in initializer drivers/video/mb862xx/mb862xxfb.c:723: warning: excess elements in struct initializer drivers/video/mb862xx/mb862xxfb.c:723: warning: (near initialization for 'of_platform_mb862xxfb_driver') drivers/video/mb862xx/mb862xxfb.c:724: error: unknown field 'remove' specified in initializer drivers/video/mb862xx/mb862xxfb.c:724: warning: excess elements in struct initializer drivers/video/mb862xx/mb862xxfb.c:724: warning: (near initialization for 'of_platform_mb862xxfb_driver') drivers/video/mb862xx/mb862xxfb.c: In function 'mb862xxfb_init': drivers/video/mb862xx/mb862xxfb.c:1038: error: implicit declaration of function 'of_register_platform_driver' drivers/video/mb862xx/mb862xxfb.c: In function 'mb862xxfb_exit': drivers/video/mb862xx/mb862xxfb.c:1049: error: implicit declaration of function 'of_unregister_platform_driver' ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH] Implement polling for 5200FEC to make netconsole work.
Implement polling for 5200FEC to make netconsole work. Tested on Phytec pcm030
and Efika.
Signed-off-by: Jon Smirl <[EMAIL PROTECTED]>
---
drivers/net/fec_mpc52xx.c | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c
index 4e4f683..aec3b97 100644
--- a/drivers/net/fec_mpc52xx.c
+++ b/drivers/net/fec_mpc52xx.c
@@ -401,6 +401,21 @@ static int mpc52xx_fec_hard_start_xmit(struct sk_buff
*skb, struct net_device *d
return 0;
}
+#ifdef CONFIG_NET_POLL_CONTROLLER
+static void mpc52xx_fec_poll_controller(struct net_device *dev)
+{
+ struct mpc52xx_fec_priv *priv = netdev_priv(dev);
+
+ disable_irq(priv->t_irq);
+ mpc52xx_fec_tx_interrupt(priv->t_irq, dev);
+ enable_irq(priv->t_irq);
+ disable_irq(priv->r_irq);
+ mpc52xx_fec_rx_interrupt(priv->r_irq, dev);
+ enable_irq(priv->r_irq);
+}
+#endif
+
+
/* This handles BestComm transmit task interrupts
*/
static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id)
@@ -926,6 +941,9 @@ mpc52xx_fec_probe(struct of_device *op, const struct
of_device_id *match)
ndev->tx_timeout= mpc52xx_fec_tx_timeout;
ndev->watchdog_timeo= FEC_WATCHDOG_TIMEOUT;
ndev->base_addr = mem.start;
+#ifdef CONFIG_NET_POLL_CONTROLLER
+ ndev->poll_controller = mpc52xx_fec_poll_controller;
+#endif
priv->t_irq = priv->r_irq = ndev->irq = NO_IRQ; /* IRQ are free for now
*/
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 1/2] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.
> It helps if you CC the person you're writing too :). Thanks Josh for pointing this out :-) I will be careful in future. > Anyway, I looked over it briefly and agree it looks pretty good. A bit > late for 2.6.28, but I'll do a more thorough review and get it in for > 2.6.29. > Great. Look forward to seeing this on the mainline kernel. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: 4xx 'next' branch updated
On Sat, 18 Oct 2008 14:54:58 +0200 Niklaus Giger <[EMAIL PROTECTED]> wrote: > Am Samstag 18 Oktober 2008 02.32:05 schrieb Josh Boyer: > > Hi All, > <..> > > Niklaus Giger (1): > > powerpc/40x: Add support for Netstal HCU4 board > Checked out the branch and tested it. The HCU4 board compiled and ran > without > problems. Wonderful. Thanks for testing! > Thanks a lot for your advise and help. Getting it into the linux > kernel seems not take as much effort as expected. That's because you did quite well on your original submission and in your responses to review. Thanks for taking the time to submit the patch. josh ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 1/2] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.
On Fri, 17 Oct 2008 08:54:52 -0700 "prodyut hazarika" <[EMAIL PROTECTED]> wrote: > On Wed, Oct 15, 2008 at 7:22 PM, Ilya Yanok <[EMAIL PROTECTED]> wrote: > > This patch adds support for page sizes bigger than 4K (16K/64K) on > > PPC 44x. > > > > This patch looks good to me. Seems that all the review comments have > been incorporated. > > Josh, it would be great if this patch is pulled into the mainline > kernel. I have seen significant performance improvement with RAID0/5 > by using 64K pages. It helps if you CC the person you're writing too :). Anyway, I looked over it briefly and agree it looks pretty good. A bit late for 2.6.28, but I'll do a more thorough review and get it in for 2.6.29. josh ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: 4xx 'next' branch updated
Am Samstag 18 Oktober 2008 02.32:05 schrieb Josh Boyer: > Hi All, <..> > Niklaus Giger (1): > powerpc/40x: Add support for Netstal HCU4 board Checked out the branch and tested it. The HCU4 board compiled and ran without problems. Thanks a lot for your advise and help. Getting it into the linux kernel seems not take as much effort as expected. Best regards Niklaus ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: powerpc allmodconfig
On Thu, 2008-10-16 at 13:02 -0700, Arjan van de Ven wrote:
> On Thu, 16 Oct 2008 12:49:23 -0700 (PDT)
> David Miller <[EMAIL PROTECTED]> wrote:
> > #endif
> > #define __WARN() warn_on_slowpath(__FILE__, __LINE__)
> > #define __WARN_printf(arg...) warn_slowpath(__FILE__, __LINE__, arg)
> > #else
> > #define __WARN_printf(arg...) __WARN()
>
> the easiest way I suppose would be to do
>
> #define __WARN_printf(arg..) do { printk(arg); __WARN(); } while (0)
>
> any obvious problems with this ?
No, not really. You won't get it on kerneloops, but I guess that's not
an easily tractable problem.
johannes
signature.asc
Description: This is a digitally signed message part
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
