Re: [PATCH 1/2] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.
On Sun, Nov 02, 2008 at 08:55:02AM +1100, Benjamin Herrenschmidt wrote: >On Sat, 2008-11-01 at 07:30 -0400, Josh Boyer wrote: >> >> That is on purpose. The chip has an errata that causes badness if >> you use the last XX bytes of DRAM. I forget exactly what XX is, but >> we just remove the last page. > >Doing that from the device-tree is very hairy tho... you end up with >informations in there that aren't aligned etc... oh well. What? -ENOTVERBOSEENOUGH. I don't see how this is really different from U-Boot just passing in a smaller memory size in the old arch/ppc world. (And I think U-Boot will actually fixup the device tree in a similar manner itself these days.) So if there are problems with this, please do tell. josh ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
"Introduce local (non-broadcast) forms of tlb invalidates" causes BUG()
After I updated to 67d1128425 I get plenty of this: | VFS: Mounted root (nfs filesystem) readonly. | Freeing unused kernel memory: 148k init | BUG: sleeping function called from invalid context at /home/bigeasy/git/linux-2.6-powerpc/mm/mmap.c:234 | in_atomic():1, irqs_disabled():0 | Call Trace: | [df189df0] [c0007160] show_stack+0x48/0x148 (unreliable) | [df189e30] [c0029480] __might_sleep+0xf0/0x100 | [df189e40] [c0070ac0] remove_vma+0x28/0x98 | [df189e50] [c0070c1c] exit_mmap+0xec/0x128 | [df189e80] [c002d2f4] mmput+0x54/0xec | [df189ea0] [c0030b6c] exit_mm+0x10c/0x120 | [df189ed0] [c003288c] do_exit+0x1ac/0x6e8 | [df189f20] [c0032e48] do_group_exit+0x80/0xac | [df189f40] [c000e9dc] ret_from_syscall+0x0/0x3c | BUG: scheduling while atomic: udevd/956/0x1002 | Modules linked in: | Call Trace: | [df189df0] [c0007160] show_stack+0x48/0x148 (unreliable) | [df189e30] [c002ac88] __schedule_bug+0x58/0x6c | [df189e40] [c023e6cc] schedule+0xa8/0x4a8 | [df189e90] [c002ad6c] __cond_resched+0x38/0x64 | [df189ea0] [c023ebc8] _cond_resched+0x3c/0x58 | [df189eb0] [c0030e70] put_files_struct+0x90/0xec | [df189ed0] [c00328a8] do_exit+0x1c8/0x6e8 | [df189f20] [c0032e48] do_group_exit+0x80/0xac | [df189f40] [c000e9dc] ret_from_syscall+0x0/0x3c on my 8544. This happans as soon as I hit userspace. A bisect leads to |commit 0ba3418b8b1c85ee1771c63f1dd12041614e56ff |Author: Kumar Gala <[EMAIL PROTECTED]> |Date: Tue Jul 15 16:12:25 2008 -0500 | |powerpc: Introduce local (non-broadcast) forms of tlb invalidates | |Introduced a new set of low level tlb invalidate functions that do not |broadcast invalidates on the bus: | |_tlbil_all - invalidate all |_tlbil_pid - invalidate based on process id (or mm context) |_tlbil_va - invalidate based on virtual address (ea + pid) | |On non-SMP configs _tlbil_all should be functionally equivalent to _tlbia and |_tlbil_va should be functionally equivalent to _tlbie. | |The intent of this change is to handle SMP based invalidates via IPIs instead |of broadcasts as the mechanism scales better for larger number of cores. | |On e500 (fsl-booke mmu) based cores move to using MMUCSR for invalidate alls |and tlbsx/tlbwe for invalidate virtual address. | |Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> | |:04 04 1b04e004e4d30e8654f9f4fd6095327bb3211ea0 317b8a3a3fba7b0184f9fbc83e3ee21adfc45b80 M arch A revert of this commit makes BUG() go away and evertything looks fine. I guess this is a config thing on my MPC8544 and my .config is available at [1]. [1] http://download.breakpoint.cc/dot.config.txt Sebastian ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH] ps3: ps3-lpm.c compile fix
drivers/ps3/ps3-lpm.c:838: error: implicit declaration of function 'get_hard_smp_processor_id' Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- drivers/ps3/ps3-lpm.c |1 + 1 file changed, 1 insertion(+) --- a/drivers/ps3/ps3-lpm.c +++ b/drivers/ps3/ps3-lpm.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include #include ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH] cell: fix ras.c compilation
arch/powerpc/platforms/cell/ras.c:299: error: implicit declaration of function 'crash_shutdown_register' Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- arch/powerpc/platforms/cell/ras.c |1 + 1 file changed, 1 insertion(+) --- a/arch/powerpc/platforms/cell/ras.c +++ b/arch/powerpc/platforms/cell/ras.c @@ -16,6 +16,7 @@ #include #include +#include #include #include #include ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 1/2] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.
On Sun, 2008-11-02 at 08:41 -0500, Josh Boyer wrote: > On Sun, Nov 02, 2008 at 08:55:02AM +1100, Benjamin Herrenschmidt wrote: > >On Sat, 2008-11-01 at 07:30 -0400, Josh Boyer wrote: > >> > >> That is on purpose. The chip has an errata that causes badness if > >> you use the last XX bytes of DRAM. I forget exactly what XX is, but > >> we just remove the last page. > > > >Doing that from the device-tree is very hairy tho... you end up with > >informations in there that aren't aligned etc... oh well. > > What? -ENOTVERBOSEENOUGH. > > I don't see how this is really different from U-Boot just passing in > a smaller memory size in the old arch/ppc world. (And I think U-Boot > will actually fixup the device tree in a similar manner itself these > days.) So if there are problems with this, please do tell. Is it cropping the memory nodes or using the reserve map ? Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
[USB] powerpc: Workaround for the PPC440EPX USBH_23 errata [take 3]
A published errata for ppc440epx states, that when running Linux with both
EHCI and OHCI modules loaded, the EHCI module experiences a fatal error
when a high-speed device is connected to the USB2.0, and functions normally
if OHCI module is not loaded.
There used to be recommendation to use only hi-speed or full-speed
devices with specific conditions, when respective module was unloaded.
Later, it was observed that ohci suspend is enough to keep things
going, and it was turned into workaround, as explained below.
Quote from original descriprion:
The 440EPx USB 2.0 Host controller is an EHCI compliant controller. In USB
2.0 Host controllers, each EHCI controller has one or more companion
controllers, which may be OHCI or UHCI. An USB 2.0 Host controller will
contain one or more ports. For each port, only one of the controllers is
connected at any one time. In the 440EPx, there is only one OHCI companion
controller,
and only one USB 2.0 Host port.
All ports on an USB 2.0 controller default to the companion controller. If
you load only an ohci driver, it will have control of the ports and any
deviceplugged in will operate, although high speed devices will be forced to
operate at full speed. When an ehci driver is loaded, it explicitly takes
control
of the ports. If there is a device connected, and / or every time there is a
new device connected, the ehci driver determines if the device is high speed or
not. If it is high speed, the driver retains control of the port. If it
is not, the driver explicitly gives the companion controller control of the
port.
The is a software workaround that uses
Initial version of the software workaround was posted to linux-usb-devel:
http://www.mail-archive.com/[EMAIL PROTECTED]/msg54019.html
and later available from amcc.com:
http://www.amcc.com/Embedded/Downloads/download.html?cat=1&family=15&ins=2
The patch below is generally based on the latter, but reworked to
powerpc/of_device USB drivers, and uses a few devicetree inquiries to get
rid of (some) hardcoded defines.
Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]>
Signed-off-by: Stefan Roese <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/sequoia.dts |2 +-
drivers/usb/host/ehci-hub.c |9 +++
drivers/usb/host/ehci-ppc-of.c| 45 -
drivers/usb/host/ehci.h | 31 +
drivers/usb/host/ohci-ppc-of.c| 25 +
5 files changed, 109 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/boot/dts/sequoia.dts
b/arch/powerpc/boot/dts/sequoia.dts
index 72d15f0..db04dfa 100644
--- a/arch/powerpc/boot/dts/sequoia.dts
+++ b/arch/powerpc/boot/dts/sequoia.dts
@@ -134,7 +134,7 @@
};
USB1: [EMAIL PROTECTED] {
- compatible = "ohci-be";
+ compatible = "ibm,usb-ohci-440epx", "ohci-be";
reg = <0x 0xe400 0x0060>;
interrupt-parent = <&UIC0>;
interrupts = <0x15 0x8>;
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
index 740835b..c25d8fe 100644
--- a/drivers/usb/host/ehci-hub.c
+++ b/drivers/usb/host/ehci-hub.c
@@ -424,8 +424,15 @@ static int check_reset_complete (
port_status &= ~PORT_RWC_BITS;
ehci_writel(ehci, port_status, status_reg);
- } else
+ /* ensure 440EPX ohci controller state is operational */
+ if (ehci->has_amcc_usb23)
+ set_ohci_hcfs(ehci, 1);
+ } else {
ehci_dbg (ehci, "port %d high speed\n", index + 1);
+ /* ensure 440EPx ohci controller state is suspended */
+ if (ehci->has_amcc_usb23)
+ set_ohci_hcfs(ehci, 0);
+ }
return port_status;
}
diff --git a/drivers/usb/host/ehci-ppc-of.c b/drivers/usb/host/ehci-ppc-of.c
index b018dee..ef732b7 100644
--- a/drivers/usb/host/ehci-ppc-of.c
+++ b/drivers/usb/host/ehci-ppc-of.c
@@ -107,11 +107,13 @@ ehci_hcd_ppc_of_probe(struct of_device *op, const struct
of_device_id *match)
{
struct device_node *dn = op->node;
struct usb_hcd *hcd;
- struct ehci_hcd *ehci;
+ struct ehci_hcd *ehci = NULL;
struct resource res;
int irq;
int rv;
+ struct device_node *np;
+
if (usb_disabled())
return -ENODEV;
@@ -149,6 +151,20 @@ ehci_hcd_ppc_of_probe(struct of_device *op, const struct
of_device_id *match)
}
ehci = hcd_to_ehci(hcd);
+ np = of_find_compatible_node(NULL, NULL, "ibm,usb-ohci-440epx");
+ if (np != NULL) {
+ /* claim we really affected by usb23 erratum */
+ if (!of_address_to_resource(np, 0, &res))
+ ehci->ohci_hcctrl_reg = ioremap(res.start +
+ OHCI_HCCTRL_OFFSET, OHCI_HCCTRL_LEN);
+ else
+
Re: [PATCH] kexec memory ranges dynamic allocation
On Sat, Nov 01, 2008 at 11:43:15AM +0300, Maxim Uvarov wrote: > 2008/11/1 Simon Horman <[EMAIL PROTECTED]> > > > On Fri, Oct 31, 2008 at 09:53:23AM +0300, Maxim Uvarov wrote: > > > 2008/10/31 Simon Horman <[EMAIL PROTECTED]> > > > > > > > Hi, > > > > > > > > Could someone please comment on the satus of this patch? > > > > > > > Hello, Simon > > > > > > I can not reproduce error which you wrote before on my target. So it is > > a > > > little bit > > > difficult to say what was wrong exactly. > > > > Hi, > > > > the version of the patch below (which I think is the latest) > > compiles fine for me. I wanted to confirm that you > > and Chandru are happy for it to be merged. > > > > If so, could you please provide a short descripton for the change-log > > and a Signed-off-by line. > > Patch looks good. > > Description is: >Do not count max_memory_range for allocation. Increase allocation > buffers >when it is needed. This actually allows us to avoid a lot of troubles > with >various device-tree files. > > Signed-off-by: Maxim Uvarov <[EMAIL PROTECTED]> Thanks, applied. -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] i2c-cpm: Detect and report NAK right away instead of timing out.
On Fri, Oct 31, 2008 at 05:29:25PM -0700, Mike Ditto wrote: > Make the driver report an ENXIO error immediately upon NAK instead of > waiting for another interrupt and getting a timeout. > > Signed-off-by: Mike Ditto <[EMAIL PROTECTED]> > --- > When reading from a device that is not present or declines to respond > to, e.g., a non-existent register address, CPM immediately reports a > NAK condition in the TxBD, but the driver kept waiting until a timeout, > which takes 1 second and causes an ugly console error message. hmm, that block of text could probably go into the patch description. It looks ok, I'll merge and push out to linus with the s3c fixes. > Index: linux/drivers/i2c/busses/i2c-cpm.c > === > retrieving revision 1.3 > diff -u -p -r1.3 i2c-cpm.c > --- linux/drivers/i2c/busses/i2c-cpm.c31 Oct 2008 06:36:08 - > 1.3 > +++ linux/drivers/i2c/busses/i2c-cpm.c1 Nov 2008 00:12:45 - > @@ -369,6 +369,7 @@ static int cpm_i2c_xfer(struct i2c_adapt > pmsg = &msgs[tptr]; > if (pmsg->flags & I2C_M_RD) > ret = wait_event_interruptible_timeout(cpm->i2c_wait, > + (in_be16(&tbdf[tptr].cbd_sc) & BD_SC_NAK) || > !(in_be16(&rbdf[rptr].cbd_sc) & BD_SC_EMPTY), > 1 * HZ); > else > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben ([EMAIL PROTECTED], http://www.fluff.org/) 'a smiley only costs 4 bytes' -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.
On Mon, 03 Nov 2008 08:33:16 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > On Sun, 2008-11-02 at 08:41 -0500, Josh Boyer wrote: > > On Sun, Nov 02, 2008 at 08:55:02AM +1100, Benjamin Herrenschmidt wrote: > > >On Sat, 2008-11-01 at 07:30 -0400, Josh Boyer wrote: > > >> > > >> That is on purpose. The chip has an errata that causes badness if > > >> you use the last XX bytes of DRAM. I forget exactly what XX is, but > > >> we just remove the last page. > > > > > >Doing that from the device-tree is very hairy tho... you end up with > > >informations in there that aren't aligned etc... oh well. > > > > What? -ENOTVERBOSEENOUGH. > > > > I don't see how this is really different from U-Boot just passing in > > a smaller memory size in the old arch/ppc world. (And I think U-Boot > > will actually fixup the device tree in a similar manner itself these > > days.) So if there are problems with this, please do tell. > > Is it cropping the memory nodes or using the reserve map ? Cropping the size of the memory node. That was simplest to do from the cuboot wrapper at the time. If marking it reserved via a reserve map is more elegant and correct, we could do that. But I will still like to know what about the other way is hairy please. josh ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 1/2] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.
> Cropping the size of the memory node. That was simplest to do from the > cuboot wrapper at the time. If marking it reserved via a reserve map > is more elegant and correct, we could do that. > > But I will still like to know what about the other way is hairy please. I don't like it :-) Bad feeling ... don't like having a memory node entry that isn't aligned to some large power of two typically. Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] i2c-cpm: Detect and report NAK right away instead of timing out.
Ben Dooks wrote: When reading from a device that is not present or declines to respond to, e.g., a non-existent register address, CPM immediately reports a NAK condition in the TxBD, but the driver kept waiting until a timeout, which takes 1 second and causes an ugly console error message. hmm, that block of text could probably go into the patch description. It's certainly fine with me if you want to include it. I was just trying, perhaps inappropriately, to separate the "bug report" from the "description of the change". -=] Mike [=- -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rfc][patch] powerpc: replace isync with lwsync
Nick Piggin writes: > This is an interesting one for me. AFAIKS it is possible to use lwsync for > a full barrier after a successful ll/sc operation, right? (or stop me here > if I'm wrong). An lwsync would order subsequent loads after the lwarx/ldarx, and subsequent stores after the stcwx./stcdx., which should be good enough. > isync followed by a branch I guess does something like puts a bubble > into the pipeline until the branch retires? So it is probably always > going to cost some cycles. I don't know about "retires", but isync is going to stop following instructions from executing until the outcome of the branch is known. On machines that don't have lwsync we will still want to use isync (since the other alternative would be the full heavyweight sync). Your patch doesn't seem to do that. Paul. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH] powerpc: remove unused variable from pci_dlpar.c
And get rid of this build warning:
arch/powerpc/platforms/pseries/pci_dlpar.c: In function 'init_phb_dynamic':
arch/powerpc/platforms/pseries/pci_dlpar.c:192: warning: unused variable 'b'
This is one of the very few warnings left in a ppc64_defconfig build and
getting rid of it will make it easier to see future introduced ones (in
fact this was introduced very recently).
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/pseries/pci_dlpar.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
[Resent to get Paul's address right and add cc to Ben]
This patch is against Linus' tree and so could go into 2.6.28 if you
think it should. This is also fixed by one of Ben's ominbus patches
(http://patchwork.ozlabs.org/patch/6041/) but this is more suitable for
upstream merge.
diff --git a/arch/powerpc/platforms/pseries/pci_dlpar.c
b/arch/powerpc/platforms/pseries/pci_dlpar.c
index 31481dc..7190493 100644
--- a/arch/powerpc/platforms/pseries/pci_dlpar.c
+++ b/arch/powerpc/platforms/pseries/pci_dlpar.c
@@ -189,7 +189,6 @@ struct pci_controller * __devinit init_phb_dynamic(struct
device_node *dn)
{
struct pci_controller *phb;
int primary;
- struct pci_bus *b;
primary = list_empty(&hose_list);
phb = pcibios_alloc_controller(dn);
--
1.5.6.5
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: remove unused variable from pci_dlpar.c
On Mon, 2008-11-03 at 18:07 +1100, Stephen Rothwell wrote:
> And get rid of this build warning:
>
> arch/powerpc/platforms/pseries/pci_dlpar.c: In function 'init_phb_dynamic':
> arch/powerpc/platforms/pseries/pci_dlpar.c:192: warning: unused variable 'b'
>
> This is one of the very few warnings left in a ppc64_defconfig build and
> getting rid of it will make it easier to see future introduced ones (in
> fact this was introduced very recently).
>
> Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
> ---
Ack.
> arch/powerpc/platforms/pseries/pci_dlpar.c |1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> This patch is against Linus' tree and so could go into 2.6.28 if you
> think it should. This is also fixed by one of Ben's ominbus patches
> (http://patchwork.ozlabs.org/patch/6041/) but this is more suitable for
> upstream merge.
>
> diff --git a/arch/powerpc/platforms/pseries/pci_dlpar.c
> b/arch/powerpc/platforms/pseries/pci_dlpar.c
> index 31481dc..7190493 100644
> --- a/arch/powerpc/platforms/pseries/pci_dlpar.c
> +++ b/arch/powerpc/platforms/pseries/pci_dlpar.c
> @@ -189,7 +189,6 @@ struct pci_controller * __devinit init_phb_dynamic(struct
> device_node *dn)
> {
> struct pci_controller *phb;
> int primary;
> - struct pci_bus *b;
>
> primary = list_empty(&hose_list);
> phb = pcibios_alloc_controller(dn);
> --
> 1.5.6.5
>
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH] powerpc: remove unused variable from pci_dlpar.c
And get rid of this build warning:
arch/powerpc/platforms/pseries/pci_dlpar.c: In function 'init_phb_dynamic':
arch/powerpc/platforms/pseries/pci_dlpar.c:192: warning: unused variable 'b'
This is one of the very few warnings left in a ppc64_defconfig build and
getting rid of it will make it easier to see future introduced ones (in
fact this was introduced very recently).
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/pseries/pci_dlpar.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
This patch is against Linus' tree and so could go into 2.6.28 if you
think it should. This is also fixed by one of Ben's ominbus patches
(http://patchwork.ozlabs.org/patch/6041/) but this is more suitable for
upstream merge.
diff --git a/arch/powerpc/platforms/pseries/pci_dlpar.c
b/arch/powerpc/platforms/pseries/pci_dlpar.c
index 31481dc..7190493 100644
--- a/arch/powerpc/platforms/pseries/pci_dlpar.c
+++ b/arch/powerpc/platforms/pseries/pci_dlpar.c
@@ -189,7 +189,6 @@ struct pci_controller * __devinit init_phb_dynamic(struct
device_node *dn)
{
struct pci_controller *phb;
int primary;
- struct pci_bus *b;
primary = list_empty(&hose_list);
phb = pcibios_alloc_controller(dn);
--
1.5.6.5
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
