RE: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc
> -Original Message- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Friday, August 12, 2011 18:05 PM > To: Zang Roy-R61911 > Cc: linux-...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; akpm@linux- > foundation.org; Xu Lei-B33228; Kumar Gala; Wood Scott-B07421 > Subject: Re: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl > esdhc > > Hello, > > On Fri, Aug 12, 2011 at 09:44:26AM +, Zang Roy-R61911 wrote: > [...] > > > We try to not pollute generic sdhci.c driver with chip-specific > > > quirks. > > > > > > Maybe you can do the fixups via IO accessors? Or by introducing > > > some additional sdhci op? > > Anton, > > thanks for the comment, as we discussed, the original code use 8 bit byte > operation, > > while in fact, on some powerpc platform, 32 bit operation is needed. > > should it be possible fixed by adding some wrapper in IO accessors or > introduce additional sdhci op? > > I would do it in the IO accessors. I am looking forward to your patch. Roy ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH] powerpc: pseries: Avoid spurious error during hotplug CPU add
During hotplug CPU add we get the following error:
Unexpected Error (0) returned from configure-connector
ibm,configure-connector returns 0 for configuration complete, so
catch this and avoid the error.
Signed-off-by: Anton Blanchard
---
Index: linux-powerpc/arch/powerpc/platforms/pseries/dlpar.c
===
--- linux-powerpc.orig/arch/powerpc/platforms/pseries/dlpar.c 2011-08-12
09:37:11.921180339 +1000
+++ linux-powerpc/arch/powerpc/platforms/pseries/dlpar.c2011-08-15
10:09:25.940626779 +1000
@@ -112,6 +112,7 @@ void dlpar_free_cc_nodes(struct device_n
dlpar_free_one_cc_node(dn);
}
+#define COMPLETE 0
#define NEXT_SIBLING1
#define NEXT_CHILD 2
#define NEXT_PROPERTY 3
@@ -158,6 +159,9 @@ struct device_node *dlpar_configure_conn
spin_unlock(&rtas_data_buf_lock);
switch (rc) {
+ case COMPLETE:
+ break;
+
case NEXT_SIBLING:
dn = dlpar_parse_cc_node(ccwa);
if (!dn)
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
