RE: [PATCH 2/4] powerpc/booke: Merge the 32 bit e5500/e500mc cpu setup code.
> -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Friday, August 03, 2012 10:04 PM > To: Sethi Varun-B16395 > Cc: ag...@suse.de; b...@kernel.crashing.org; linuxppc- > d...@lists.ozlabs.org; kvm-...@vger.kernel.org > Subject: Re: [PATCH 2/4] powerpc/booke: Merge the 32 bit e5500/e500mc cpu > setup code. > > > On Jul 9, 2012, at 7:58 AM, Varun Sethi wrote: > > > Merge the 32 bit cpu setup code for e500mc/e5500 and define the > "cpu_restore" > > routine (for e5500/e6500) only for the 64 bit case. The cpu_restore > > routine is used in the 64 bit case for setting up the secondary cores. > > > > Signed-off-by: Varun Sethi > > --- > > arch/powerpc/kernel/cpu_setup_fsl_booke.S |1 + > > arch/powerpc/kernel/cputable.c|4 > > 2 files changed, 5 insertions(+), 0 deletions(-) > > > > diff --git a/arch/powerpc/kernel/cpu_setup_fsl_booke.S > > b/arch/powerpc/kernel/cpu_setup_fsl_booke.S > > index a55d028..5e87737 100644 > > --- a/arch/powerpc/kernel/cpu_setup_fsl_booke.S > > +++ b/arch/powerpc/kernel/cpu_setup_fsl_booke.S > > @@ -75,6 +75,7 @@ _GLOBAL(__setup_cpu_e500v2) > > mtlrr4 > > blr > > _GLOBAL(__setup_cpu_e500mc) > > +_GLOBAL(__setup_cpu_e5500) > > This is a bit confusing, as we now have duplicated __setup_cpu_e5500() > between the ppc32 and ppc64 cases. > > If you build this patch for corenet32_smp_defconfig it fails. [Sethi Varun-B16395] I am able to build without any issue with the same config. -Varun ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [git pull] Please pull powerpc.git merge branch
On Aug 3, 2012, at 5:34 PM, Benjamin Herrenschmidt wrote: > On Fri, 2012-08-03 at 08:39 -0500, Kumar Gala wrote: >> Ben, >> >> Weekly bug fix pull request. > > Well, Linus is on holiday so I don't think it makes sense for me to ask > him to pull anything just yet... I'll put it in my tree some time next > week and will send it along with whatever I have as well when it looks > like he might be back :-) No problem, just trying to get into a weekly cadence of pull requests. - k > > Cheers, > Ben. > >> - k >> >> The following changes since commit 0d7614f09c1ebdbaa1599a5aba7593f147bf96ee: >> >> Linux 3.6-rc1 (2012-08-02 16:38:10 -0700) >> >> are available in the git repository at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git merge >> >> for you to fetch changes up to c9f11c30374329a0d2a88cf05281ca49d8eca9ab: >> >> powerpc/fsl-pci: Only scan PCI bus if configured as a host (2012-08-03 >> 08:25:52 -0500) >> >> >> Jia Hongtao (1): >> powerpc/fsl-pci: Only scan PCI bus if configured as a host >> >> arch/powerpc/sysdev/fsl_pci.c | 13 - >> 1 file changed, 8 insertions(+), 5 deletions(-) > ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 3/4] powerpc/booke: Separate out restore_e5500/setup_e5500 routines.
On Jul 9, 2012, at 8:01 AM, Varun Sethi wrote: > For the 64 bit case separate out e5500 cpu_setup and cpu_restore functions. > The cpu_setup function (for the primary core) is passed the cpu_spec pointer, > which is not there in case of the cpu_restore function. Also, in our case > we will have to manipulate the CPU_FTR_EMB_HV flag on the the primary core. > > Signed-off-by: Varun Sethi > --- > arch/powerpc/kernel/cpu_setup_fsl_booke.S | 38 > arch/powerpc/kernel/exceptions-64e.S | 18 + > 2 files changed, 34 insertions(+), 22 deletions(-) applied to next - k ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 2/4] powerpc/booke: Merge the 32 bit e5500/e500mc cpu setup code.
On Jul 9, 2012, at 7:58 AM, Varun Sethi wrote: > Merge the 32 bit cpu setup code for e500mc/e5500 and define the "cpu_restore" > routine (for e5500/e6500) only for the 64 bit case. The cpu_restore routine > is used in the 64 bit case for setting up the secondary cores. > > Signed-off-by: Varun Sethi > --- > arch/powerpc/kernel/cpu_setup_fsl_booke.S |1 + > arch/powerpc/kernel/cputable.c|4 > 2 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/kernel/cpu_setup_fsl_booke.S > b/arch/powerpc/kernel/cpu_setup_fsl_booke.S > index a55d028..5e87737 100644 > --- a/arch/powerpc/kernel/cpu_setup_fsl_booke.S > +++ b/arch/powerpc/kernel/cpu_setup_fsl_booke.S > @@ -75,6 +75,7 @@ _GLOBAL(__setup_cpu_e500v2) > mtlrr4 > blr > _GLOBAL(__setup_cpu_e500mc) > +_GLOBAL(__setup_cpu_e5500) This is a bit confusing, as we now have duplicated __setup_cpu_e5500() between the ppc32 and ppc64 cases. If you build this patch for corenet32_smp_defconfig it fails. I'll fixup and add the proper #ifdef's to handle this. --- applied to next - k ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 1/4] powepc/booke: Separate out E.HV check and ivor setup code.
On Jul 9, 2012, at 7:55 AM, Varun Sethi wrote: > Move the E.HV check and CPU_FTR_EMB_HV flag manipulation to the cpu setup > code. > Create a separate routine for E.HV ivors setup. > > Signed-off-by: Varun Sethi > --- > arch/powerpc/kernel/cpu_setup_fsl_booke.S | 29 ++--- > arch/powerpc/kernel/head_fsl_booke.S | 18 -- > 2 files changed, 30 insertions(+), 17 deletions(-) applied to next - k ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
