Re: [PATCH v2] powerpc/83xx: add support for mpc8306

[Filip Brozović]

On 4/3/2015 10:24 PM, Scott Wood wrote:

What are you using PPC_MPC8306 for in your custom board code?


Sorry for the late reply, I was a bit busy over the Easter weekend.

I'm not currently using it for anything, so I guess I could remove it 
and just use PPC_MPC830x in my board code. However, I think it's best if 
this patch is ignored (for now), and I'll submit a patch series for the 
8306 and a custom board in a couple of weeks/months, when I find some 
time to clean up the board code.


- Filip
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2] powerpc/83xx: add support for mpc8306

[Filip Brozović]

On 4/3/2015 2:01 PM, Paul Bolle wrote:

On Fri, 2015-04-03 at 12:44 +0200, Filip Brozovic wrote:

--- a/arch/powerpc/platforms/83xx/Kconfig
+++ b/arch/powerpc/platforms/83xx/Kconfig



+# used for gpio
+config PPC_MPC830x
+   bool
+   select ARCH_WANT_OPTIONAL_GPIOLIB
+
+config PPC_MPC8306
+   bool


To me these two new Kconfig symbols look pointless:
- they have no prompt, so one cannot set them manually;
- no other Kconfig symbol selects them;
- they do not default to 'y'.

I'm not aware of a way to set these symbols to 'y' outside of those
three. Is there perhaps a way for kconfig to set these symbols to 'y'
that I have missed?

Or do you expect to do one of these three things in a separate patch?



The idea was that boards in the Kconfig file would select these symbols 
in order to enable support for the 8306. I mainly wanted to get this 
patch into mainline in order to make kernel maintenance for a couple of 
custom in-house developed boards easier. Since these boards are not 
widely available and our customers are unlikely to want to change and 
recompile the kernel, I have so far leaned towards not including support 
for them in mainline. As far as I can see, boards which are included in 
mainline right now are mostly evaluation boards which are easily 
available at most electronics distributors.


That being said, I don't know what the official stance on this is; is 
adding custom boards encouraged regardless of their availability (e.g. 
if I develop a custom board with the intention of only ever actually 
making a single prototype for personal use, should I go and submit 
patches so that support makes it into the mainline kernel?), or should 
there be a minimum level of public interest before incorporating custom 
boards into mainline? If it's the latter, I suppose a solution would be 
to include support for the Freescale MPC8306SOM in mainline. Of course, 
this has its own problems, since someone would have to write and 
maintain it (and I don't have an MPC8306SOM nor the time needed to do 
maintenance).


- Filip
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/83xx: add support for mpc8306

[Filip Brozović]

On 3/31/2015 7:54 PM, Scott Wood wrote:

This breaks multiplatform support.  You need to determine this at
runtime.


Understood, but I'm unsure of how to do this exactly. Would it be 
appropriate to define another array, snum_init_14, with the SNUM values 
for the MPC8306 QE, change the minimum number of SNUMs in 
qe_get_num_of_snums() to 14 and set the correct values this way? In that 
case, compatibility with other platforms would be kept intact, and the 
QE device tree node for MPC8306 (and MPC8309) boards would just have to 
have the fsl,qe-num-snums property set to 14 in order for the driver to 
set the correct values.

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev