Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Nicolas.Ferre 
Joe,

Please drop this chunk: it's a successive controller version number 
which are all backward compatible with "fallthrough" on each case so 
removing from this last one makes it inconsistent.

In sort: NACK for atmel-mci.

Best regards,
   Nicolas


On 09/09/2020 at 22:06, Joe Perches wrote:
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index 444bd3a0a922..8324312e4f42 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -2435,7 +2435,7 @@ static void atmci_get_cap(struct atmel_mci *host)
>  case 0x100:
>  host->caps.has_bad_data_ordering = 0;
>  host->caps.need_reset_after_xfer = 0;
> -   fallthrough;
> +   break;
>  case 0x0:
>  break;
>  default:


-- 
Nicolas Ferre

Re: [PATCH v2 15/34] dt-bindings: arm: Convert Atmel board/soc bindings to json-schema

2018-12-04 Thread Nicolas.Ferre 
On 03/12/2018 at 22:32, Rob Herring wrote:
> Convert Atmel SoC bindings to DT schema format using json-schema.
> 
> Cc: Mark Rutland 
> Cc: Nicolas Ferre 

I'm listed here...

> Cc: Alexandre Belloni 

Proper email address here...


> Cc: devicet...@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org
> Signed-off-by: Rob Herring 
> ---
>   .../devicetree/bindings/arm/atmel-at91.txt|  72 --
>   .../devicetree/bindings/arm/atmel-at91.yaml   | 133 ++
>   2 files changed, 133 insertions(+), 72 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/arm/atmel-at91.txt
>   create mode 100644 Documentation/devicetree/bindings/arm/atmel-at91.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.txt 
> b/Documentation/devicetree/bindings/arm/atmel-at91.txt
> deleted file mode 100644
> index 4bf1b4da7659..
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.txt
> +++ /dev/null
> @@ -1,72 +0,0 @@
> -Atmel AT91 device tree bindings.
> -

[..]

> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml 
> b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> new file mode 100644
> index ..19431f58b906
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -0,0 +1,133 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/atmel-at91.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel AT91 device tree bindings.
> +
> +maintainers:
> +  - Alexandre Belloni 
> +  - Ludovic Desroches 

... and sorry but it's not correct just above ^^^
- wrong Ludovic's email address
- wrong Alexander's email address
- and I'm not part of the game anymore...

So actually our MAINTAINER's entry is up-to-date: please use it.


> +description: |
> +  Boards with a SoC of the Atmel AT91 or SMART family shall have the 
> following
> +
> +properties:
> +  $nodename:
> +const: '/'
> +  compatible:
> +oneOf:
> +  - items:
> +  - const: atmel,at91rm9200
> +  - items:
> +  - enum:
> +  - olimex,sam9-l9260
> +  - enum:
> +  - atmel,at91sam9260
> +  - atmel,at91sam9261
> +  - atmel,at91sam9263
> +  - atmel,at91sam9g20
> +  - atmel,at91sam9g45
> +  - atmel,at91sam9n12
> +  - atmel,at91sam9rl
> +  - atmel,at91sam9xe
> +  - const: atmel,at91sam9
> +
> +  - items:
> +  - enum:
> +  - atmel,at91sam9g15
> +  - atmel,at91sam9g25
> +  - atmel,at91sam9g35
> +  - atmel,at91sam9x25
> +  - atmel,at91sam9x35
> +  - const: atmel,at91sam9x5
> +  - const: atmel,at91sam9
> +
> +  - items:
> +  - const: atmel,sama5d27
> +  - const: atmel,sama5d2
> +  - const: atmel,sama5
> +
> +  - description: Nattis v2 board with Natte v2 power board
> +items:
> +  - const: axentia,nattis-2
> +  - const: axentia,natte-2
> +  - const: axentia,linea
> +  - const: atmel,sama5d31
> +  - const: atmel,sama5d3
> +  - const: atmel,sama5
> +
> +  - description: TSE-850 v3 board
> +items:
> +  - const: axentia,tse850v3
> +  - const: axentia,linea
> +  - const: atmel,sama5d31
> +  - const: atmel,sama5d3
> +  - const: atmel,sama5
> +
> +  - items:
> +  - const: axentia,linea
> +  - const: atmel,sama5d31
> +  - const: atmel,sama5d3
> +  - const: atmel,sama5
> +
> +  - items:
> +  - enum:
> +  - atmel,sama5d31
> +  - atmel,sama5d33
> +  - atmel,sama5d34
> +  - atmel,sama5d35
> +  - atmel,sama5d36
> +  - const: atmel,sama5d3
> +  - const: atmel,sama5
> +
> +  - items:
> +  - enum:
> +  - atmel,sama5d41
> +  - atmel,sama5d42
> +  - atmel,sama5d43
> +  - atmel,sama5d44
> +  - const: atmel,sama5d4
> +  - const: atmel,sama5
> +
> +  - items:
> +  - enum:
> +  - atmel,sams70j19
> +  - atmel,sams70j20
> +  - atmel,sams70j21
> +  - atmel,sams70n19
> +  - atmel,sams70n20
> +  - atmel,sams70n21
> +  - atmel,sams70q19
> +  - atmel,sams70q20
> +  - atmel,sams70q21
> +  - const: atmel,sams70
> +  - const: atmel,samv7
> +
> +  - items:
> +  - enum:
> +  - atmel,samv70j19
> +  - atmel,samv70j20
> +  - atmel,samv70n19
> +  - atmel,samv70n20
> +  - atmel,samv70q19
> +  - atmel,samv70q20
> +  - const: atmel,samv70
> +  - const: atmel,samv7
> +
> +  - items:
> +