Re: [PATCH v1 1/3] powerpc, 8xx: remove support for 8xx

[Tom Rini]

On Wed, Jun 14, 2017 at 09:40:18AM +0200, Christophe LEROY wrote:
> 
> 
> Le 13/06/2017 à 09:37, Heiko Schocher a écrit :
> >Hello Christophe,
> >
> >Am 13.06.2017 um 07:40 schrieb Christophe LEROY:
> >>
> >>
> >>Le 13/06/2017 à 07:26, Christophe LEROY a écrit :
> >>>There was for long time no activity in the 8xx area.
> >>>We need to go further and convert to Kconfig, but it
> >>>turned out, nobody is interested anymore in 8xx,
> >>>so remove it (with a heavy heart, knowing that I remove
> >>>here the root of U-Boot).
> >>>
> >>>Signed-off-by: Heiko Schocher 
> >>>
> >>
> >>Please don't do that.
> >
> >Tom already applied the patch to mainline ...
> 
> Can be reverted ?

It's not a trivial revert, but it wouldn't take took long to resolve the
conflicts, for someone that's interested in the architecture.

> >>As you can see in Linux kernel activity, there have been a lot
> >>activity related to the 8xx,
> >>including but not limited to:
> >>1/ HW Crypto for the 885 (Talitos SEC1)
> >>2/ TX NAPI in the 8xx Ethernet driver
> >>3/ Scatter/Gather support in the 8xx Ethernet driver
> >>4/ Hugepages
> >>5/ Perf events
> >>6/ hw breakpoints
> >>7/ Linear memory mapping via Large TLBs
> >
> >Thats linux ... not u-boot!
> 
> Sure, but it shows there is still interest to that processor. The
> 885 is a good recent 8xx.
> u-boot is not really something we focus on. We update it once a
> year, as far as it can start our Linux box we are happy.

I suppose this highlights the risks of not upstreaming your code.  If
someone had been submitting a new board in the last few years, they
would (likely, yes, we've made a few mistakes in missing maintainers at
times) have been CC'd on one of the "Does anyone care about this still?"
messages that've been both in public and in private.

> >>The followings links give an overview of the activity:
> >>
> >>https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/drivers/crypto/talitos.c
> >>
> >>https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
> >>
> >>
> >>https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/arch/powerpc/kernel/head_8xx.S
> >>
> >>
> >>https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/arch/powerpc/mm/8xx_mmu.c
> >>
> >>
> >>We have thousands of boards with mpc885 running and requiring
> >>support for at least the next 10 years.
> >
> >Ok, nice to hear!
> >
> >>How can the 8xx survive without U-boot support ?
> >
> >Tom asked (I think a lot of times) regarding converting mpc8xx to
> >Kconfig / DM and nobody did the necessary steps. We also asked
> >our customers if they can do the necessary changes, none was interested.
> 
> I did't know. Indeed I was not following uboot activity until
> someone who knows the level of interest we have in 8xx alerted me
> yesterday.
> It would have been nice if you had notified linuxppc-dev list.
> 
> >
> >So, if you need mpc8xx support in U-Boot, simply add it again with
> >Kconfig and DM support included!
> 
> Ok, I'll try and come with a patch to convert 8xx in the coming
> weeks. In the mean time please revert the deletion in order to avoid
> nightmare conflicts when the converting patch comes.

Well, how about this.  Now that you know there's a problem, and a need
for a maintainer, can you please submit a patch, in the next say 2
weeks, that brings back the core of mpc8xx and lists you (or someone
else from your company) as the maintainer for mpc8xx, and we'll aim for
v2017.09 as having (a) one of your platforms, or relevant reference
platform in mainline.  I don't want "just a revert" as there's many
boards that no, we don't want anymore as no one is maintaining them.
Thanks!

-- 
Tom


signature.asc
Description: Digital signature

Re: [Patch] NULL pointer deref with corrupted squashfs image

[Tom Rini]

On Tue, Jan 20, 2009 at 05:47:14PM +0100, Eric Sesterhenn wrote:
 * Jörn Engel (jo...@logfs.org) wrote:
  On Fri, 16 January 2009 16:07:00 -0700, Tom Rini wrote:
   
   Sounds like a plan to me, except maybe zlib_inflate_unsafe() and a
   comment above the wrapper saying what/why is going on?
  
  Eric, will you do the honors?  Since you did all the hard work before,
  you derserve the fame as well. :)
 
 Since I am not sure either about xtensa I added chris to the cc list.

How about we just change all callers from arch/*/boot to use the _unsafe
version?  Then..

 +/*
 +These two wrappers decide wheter strm-next_out gets checked for NULL.
 +The zlib_inflate_unsafe() version got added because the PPC zImage
 +gets extracted to memory address 0 and therefore
 +we avoid this check for zlib_inflate_unsafe()

These two wrappers decide wheter strm-next_out gets checked for NULL.
The zlib_inflate_unsafe() version is primarily used in the pre-Linux
'boot' directory code to allow for extraction to memory address 0 and
therefore we avoid this check.

-- 
Tom Rini
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Update maintainers for powerpc

[Tom Rini]

On Fri, Jul 04, 2008 at 09:04:42PM +1000, Paul Mackerras wrote:

 This updates the MAINTAINERS entries for powerpc.  It adds Ben H to
 the overall Linux for PowerPC entry and makes it clear this covers
 both 32-bit and 64-bit machines.  It removes the separate entry we had
 for Linux on 64-bit PowerPC where Anton and I were listed as
 maintainers - Anton hasn't been involved in the day-to-day maintenance
 of the code for several years.  Finally, it removes the entry for the
 Linux for PowerPC boot code where Tom Rini was listed as the
 maintainer.  That code got completely rewritten when we merged
 32-bit and 64-bit, and I and the various platform maintainers have
 been maintaining that code since.
 
 Signed-off-by: Paul Mackerras [EMAIL PROTECTED]

Acked-by: Tom Rini [EMAIL PROTECTED]

-- 
Tom Rini
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev