Re: [PATCH v2 1/2] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-02-08 Thread Wols Lists

On 08/02/2022 15:21, Paul Menzel wrote:

So, do the same as commit 9564a8cf422d ("Kbuild: fix # escaping in .cmd
files for future Make") and commit 929bef467771 ("bpf: Use $(pound) instead
of \# in Makefiles") and define and use a `$(pound)` variable.


As commented elsewhere, for the sake of us ENGLISH speakers, *PLEASE* 
make that $(hash). A pound sign is £.


Cheers,
Wol


Re: [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-02-08 Thread Wols Lists

On 26/01/2022 11:41, Paul Menzel wrote:

So, do the same as commit 9564a8cf422d (Kbuild: fix # escaping in .cmd
files for future Make) and commit 929bef467771 (bpf: Use $(pound) instead
of \# in Makefiles) and define and use a `$(pound)` variable.


Ouch!

In the English (as opposed to American) speaking world this will be very 
confusing! The pound sign is £ not #.


If this is not dictated by some sort of upstream PLEASE can we make it 
$(hash) not $(pound)


Cheers,
Wol