Re: [kbuild-all] [PATCH v6 2/4] resource: Use list_head to link sibling resource
Hi,
On 07/08, Baoquan He wrote:
>Hi,
>
>On 07/05/18 at 01:00am, kbuild test robot wrote:
>> Hi Baoquan,
>>
>> I love your patch! Yet something to improve:
>>
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on v4.18-rc3 next-20180704]
>> [if your patch is applied to the wrong git tree, please drop us a note to
>> help improve the system]
>
>Thanks for telling.
>
>I cloned 0day-ci/linut to my local pc.
>https://github.com/0day-ci/linux.git
>
>However, I didn't find below branch. And tried to open it in web
>broswer, also failed.
>
Sorry for the inconvenience, 0day bot didn't push the branch to github
successfully,
Just push it manually, you can have a try again.
Thanks,
Xiaolong
>
>> url:
>> https://github.com/0day-ci/linux/commits/Baoquan-He/resource-Use-list_head-to-link-sibling-resource/20180704-121402
>> config: mips-rb532_defconfig (attached as .config)
>> compiler: mipsel-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
>> reproduce:
>> wget
>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
>> ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> # save the attached .config to linux build tree
>> GCC_VERSION=7.2.0 make.cross ARCH=mips
>
>I did find a old one which is for the old version 5 post.
>
>[bhe@linux]$ git remote -v
>0day-cihttps://github.com/0day-ci/linux.git (fetch)
>0day-cihttps://github.com/0day-ci/linux.git (push)
>[bhe@dhcp-128-28 linux]$ git branch -a| grep Baoquan| grep resource
>
> remotes/0day-ci/Baoquan-He/resource-Use-list_head-to-link-sibling-resource/20180612-113600
>
>Could you help have a look at this?
>
>Thanks
>Baoquan
>
>>
>> All error/warnings (new ones prefixed by >>):
>>
>> >> arch/mips/pci/pci-rc32434.c:57:11: error: initialization from
>> >> incompatible pointer type [-Werror=incompatible-pointer-types]
>> .child = &rc32434_res_pci_mem2
>> ^
>>arch/mips/pci/pci-rc32434.c:57:11: note: (near initialization for
>> 'rc32434_res_pci_mem1.child.next')
>> >> arch/mips/pci/pci-rc32434.c:51:47: warning: missing braces around
>> >> initializer [-Wmissing-braces]
>> static struct resource rc32434_res_pci_mem1 = {
>> ^
>>arch/mips/pci/pci-rc32434.c:60:47: warning: missing braces around
>> initializer [-Wmissing-braces]
>> static struct resource rc32434_res_pci_mem2 = {
>> ^
>>cc1: some warnings being treated as errors
>>
>> vim +57 arch/mips/pci/pci-rc32434.c
>>
>> 73b4390f Ralf Baechle 2008-07-16 50
>> 73b4390f Ralf Baechle 2008-07-16 @51 static struct resource
>> rc32434_res_pci_mem1 = {
>> 73b4390f Ralf Baechle 2008-07-16 52 .name = "PCI MEM1",
>> 73b4390f Ralf Baechle 2008-07-16 53 .start = 0x5000,
>> 73b4390f Ralf Baechle 2008-07-16 54 .end = 0x5FFF,
>> 73b4390f Ralf Baechle 2008-07-16 55 .flags = IORESOURCE_MEM,
>> 73b4390f Ralf Baechle 2008-07-16 56 .sibling = NULL,
>> 73b4390f Ralf Baechle 2008-07-16 @57 .child = &rc32434_res_pci_mem2
>> 73b4390f Ralf Baechle 2008-07-16 58 };
>> 73b4390f Ralf Baechle 2008-07-16 59
>>
>> :: The code at line 57 was first introduced by commit
>> :: 73b4390fb23456964201abda79f1210fe337d01a [MIPS] Routerboard 532:
>> Support for base system
>>
>> :: TO: Ralf Baechle
>> :: CC: Ralf Baechle
>>
>> ---
>> 0-DAY kernel test infrastructureOpen Source Technology Center
>> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
>
>___
>kbuild-all mailing list
>kbuild-...@lists.01.org
>https://lists.01.org/mailman/listinfo/kbuild-all
Re: [kbuild-all] [PATCH] include/linux/vfio.h: Guard powerpc-specific functions with CONFIG_VFIO_SPAPR_EEH
On 06/08, Alexey Kardashevskiy wrote:
>On 08/06/17 15:35, Alexey Kardashevskiy wrote:
>> Hi,
>>
>> How did you manage to have CONFIG_EEH=y and CONFIG_VFIO_SPAPR_EEH=n? "make
>> oldconfig" fixes this to CONFIG_VFIO_SPAPR_EEH=y.
>
>
>Also, the attached config has "CONFIG_VFIO_SPAPR_EEH=m" and cannot produce
>the error below, what am I missing here?
Sorry for the late, I can reproduce below error by following below steps with
attached config in original report:
wget
https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=powerpc
What's your steps?
Thanks,
Xiaolong
>
>
>
>>
>>
>>
>> On 08/06/17 02:31, kbuild test robot wrote:
>>> Hi Murilo,
>>>
>>> [auto build test ERROR on linus/master]
>>> [also build test ERROR on v4.12-rc4 next-20170607]
>>> [if your patch is applied to the wrong git tree, please drop us a note to
>>> help improve the system]
>>>
>>> url:
>>> https://github.com/0day-ci/linux/commits/Murilo-Opsfelder-Araujo/include-linux-vfio-h-Guard-powerpc-specific-functions-with-CONFIG_VFIO_SPAPR_EEH/20170607-000643
>>> config: powerpc-allmodconfig (attached as .config)
>>> compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
>>> reproduce:
>>> wget
>>> https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O
>>> ~/bin/make.cross
>>> chmod +x ~/bin/make.cross
>>> # save the attached .config to linux build tree
>>> make.cross ARCH=powerpc
>>>
>>> All errors (new ones prefixed by >>):
>>>
> drivers/vfio/vfio_spapr_eeh.c:22:6: error: redefinition of
> 'vfio_spapr_pci_eeh_open'
>>> void vfio_spapr_pci_eeh_open(struct pci_dev *pdev)
>>> ^~~
>>>In file included from drivers/vfio/vfio_spapr_eeh.c:14:0:
>>>include/linux/vfio.h:160:20: note: previous definition of
>>> 'vfio_spapr_pci_eeh_open' was here
>>> static inline void vfio_spapr_pci_eeh_open(struct pci_dev *pdev)
>>>^~~
> drivers/vfio/vfio_spapr_eeh.c:28:6: error: redefinition of
> 'vfio_spapr_pci_eeh_release'
>>> void vfio_spapr_pci_eeh_release(struct pci_dev *pdev)
>>> ^~
>>>In file included from drivers/vfio/vfio_spapr_eeh.c:14:0:
>>>include/linux/vfio.h:164:20: note: previous definition of
>>> 'vfio_spapr_pci_eeh_release' was here
>>> static inline void vfio_spapr_pci_eeh_release(struct pci_dev *pdev)
>>>^~
> drivers/vfio/vfio_spapr_eeh.c:34:6: error: redefinition of
> 'vfio_spapr_iommu_eeh_ioctl'
>>> long vfio_spapr_iommu_eeh_ioctl(struct iommu_group *group,
>>> ^~
>>>In file included from drivers/vfio/vfio_spapr_eeh.c:14:0:
>>>include/linux/vfio.h:168:20: note: previous definition of
>>> 'vfio_spapr_iommu_eeh_ioctl' was here
>>> static inline long vfio_spapr_iommu_eeh_ioctl(struct iommu_group *group,
>>>^~
>>>
>>> vim +/vfio_spapr_pci_eeh_open +22 drivers/vfio/vfio_spapr_eeh.c
>>>
>>> 1b69be5e Gavin Shan 2014-06-10 16
>>> 89a2edd6 Alexey Kardashevskiy 2014-08-08 17 #define DRIVER_VERSION
>>> "0.1"
>>> 89a2edd6 Alexey Kardashevskiy 2014-08-08 18 #define DRIVER_AUTHOR "Gavin
>>> Shan, IBM Corporation"
>>> 89a2edd6 Alexey Kardashevskiy 2014-08-08 19 #define DRIVER_DESC "VFIO
>>> IOMMU SPAPR EEH"
>>> 89a2edd6 Alexey Kardashevskiy 2014-08-08 20
>>> 1b69be5e Gavin Shan 2014-06-10 21 /* We might build address
>>> mapping here for "fast" path later */
>>> 9b936c96 Alexey Kardashevskiy 2014-08-08 @22 void
>>> vfio_spapr_pci_eeh_open(struct pci_dev *pdev)
>>> 1b69be5e Gavin Shan 2014-06-10 23 {
>>> 9b936c96 Alexey Kardashevskiy 2014-08-08 24eeh_dev_open(pdev);
>>> 1b69be5e Gavin Shan 2014-06-10 25 }
>>> 92d18a68 Gavin Shan 2014-08-08 26
>>> EXPORT_SYMBOL_GPL(vfio_spapr_pci_eeh_open);
>>> 1b69be5e Gavin Shan 2014-06-10 27
>>> 1b69be5e Gavin Shan 2014-06-10 @28 void
>>> vfio_spapr_pci_eeh_release(struct pci_dev *pdev)
>>> 1b69be5e Gavin Shan 2014-06-10 29 {
>>> 1b69be5e Gavin Shan 2014-06-10 30eeh_dev_release(pdev);
>>> 1b69be5e Gavin Shan 2014-06-10 31 }
>>> 92d18a68 Gavin Shan 2014-08-08 32
>>> EXPORT_SYMBOL_GPL(vfio_spapr_pci_eeh_release);
>>> 1b69be5e Gavin Shan 2014-06-10 33
>>> 1b69be5e Gavin Shan 2014-06-10 @34 long
>>> vfio_spapr_iommu_eeh_ioctl(struct iommu_group *group,
>>> 1b69be5e Gavin Shan 2014-06-10 35
>>> unsigned int cmd, unsigned long arg)
>>> 1b69be5e Gavin Shan 2014-06-10 36 {
>>> 1b69be5e Gavin Shan 2014-06-10 37struct eeh_pe *pe;
>>>
>>> :: T
Re: [mm] c4344e8035: WARNING: CPU: 0 PID: 101 at mm/memory.c:303 __tlb_remove_page_size+0x25/0x99
On 10/12, Aneesh Kumar K.V wrote:
>kernel test robot writes:
>
>> FYI, we noticed the following commit:
>>
>> https://github.com/0day-ci/linux
>> Aneesh-Kumar-K-V/mm-Use-the-correct-page-size-when-removing-the-page/20161012-013446
>> commit c4344e80359420d7574b3b90fddf53311f1d24e6 ("mm: Remove the page size
>> change check in tlb_remove_page")
>>
>> in testcase: boot
>>
>> on test machine: qemu-system-i386 -enable-kvm -cpu Haswell,+smep,+smap -m
>> 360M
>>
>> caused below changes:
>>
>>
>> ++++
>> || eff764128d | c4344e8035 |
>> ++++
>> | boot_successes | 59 | 0 |
>> | boot_failures | 0 | 43 |
>> | WARNING:at_mm/memory.c:#__tlb_remove_page_size | 0 | 43 |
>> | calltrace:SyS_execve | 0 | 43 |
>> | calltrace:run_init_process | 0 | 21 |
>> ++++
>>
>>
>>
>> [4.096204] Write protecting the kernel text: 3148k
>> [4.096911] Write protecting the kernel read-only data: 1444k
>> [4.120357] [ cut here ]
>> [4.121078] WARNING: CPU: 0 PID: 101 at mm/memory.c:303
>> __tlb_remove_page_size+0x25/0x99
>> [4.122380] Modules linked in:
>> [4.122788] CPU: 0 PID: 101 Comm: run-parts Not tainted
>> 4.8.0-mm1-00315-gc4344e8 #5
>> [4.123956] bd145dc4 b111e5e6 bd145de0 b10320dc 012f b10974d1
>> bd145e70 c4954170
>> [4.125277] c4954170 bd145df4 b103215f 0009
>> bd145e04 b10974d1
>> [4.126424] c4954170 bd145e70 bd145e14 b10263ca bd145e70 bd47bafc
>> bd145e40 b109767a
>> [4.127622] Call Trace:
>
>Thanks for the report. The below change should fix this.
>
>commit 18c929e7cf672da617dc218c6265366bf78b1644
>Author: Aneesh Kumar K.V
>Date: Wed Oct 12 08:40:41 2016 +0530
>
>update mmu gather page size before flushing page table cache
>
>diff --git a/mm/memory.c b/mm/memory.c
>index 26d1ba8c87e6..7e7eccb82a2b 100644
>--- a/mm/memory.c
>+++ b/mm/memory.c
>@@ -526,7 +526,11 @@ void free_pgd_range(struct mmu_gather *tlb,
> end -= PMD_SIZE;
> if (addr > end - 1)
> return;
>-
>+ /*
>+ * We add page table cache pages with PAGE_SIZE,
>+ * (see pte_free_tlb()), flush the tlb if we need
>+ */
>+ tlb_remove_check_page_size_change(tlb, PAGE_SIZE);
> pgd = pgd_offset(tlb->mm, addr);
> do {
> next = pgd_addr_end(addr, end);
>
Just applied this fix on top of commit c4344e8035 and confirmed that
reportedwarning is gone with this fix.
Tested-by: Xiaolong Ye
=
compiler/kconfig/rootfs/sleep/tbox_group/testcase:
gcc-6/i386-randconfig-s1-201641/quantal-core-i386.cgz/1/vm-vp-quantal-i386/boot
commit:
c4344e80359420d7574b3b90fddf53311f1d24e6
384db818365c90b91d8bad80be188765e801cf58 ("update mmu gather page size before
flushing page table cache")
c4344e80359420d7 384db818365c90b91d8bad80be
--
fail:runs %reproductionfail:runs
| | |
24:24-100%:5
dmesg.WARNING:at_mm/memory.c:#__tlb_remove_page_size
Thanks,
Xiaolong
