Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-06-16 Thread Christian Zigotzky 

On 13 June 2022 at 05:57 pm, Rob Herring wrote:

On Thu, Jun 9, 2022 at 12:03 PM Christian Zigotzky
 wrote:

On 06 June 2022 at 07:06 pm, Rob Herring wrote:

On Mon, Jun 6, 2022 at 11:14 AM Christian Zigotzky
 wrote:

On 06 June 2022 at 04:58 pm, Rob Herring wrote:

On Fri, May 27, 2022 at 9:23 AM Rob Herring  wrote:

On Fri, May 27, 2022 at 3:33 AM Christian Zigotzky
 wrote:

On 27 May 2022 at 10:14 am, Prabhakar Mahadev Lad wrote:

Hi,


-Original Message-
From: Christian Zigotzky 

On 27 May 2022 at 09:56 am, Prabhakar Mahadev Lad wrote:

Hi,


-Original Message-
From: Christophe Leroy 

[...]


Looks like the driver which you are using has not been converted to use

platform_get_irq(), could you please check that.

Cheers,
Prabhakar

Do you mean the mouse and keyboard driver?


No it could be your gpio/pinctrl driver assuming the keyboard/mouse are using 
GPIO's. If you are using interrupts then it might be some hierarchal irqc 
driver in drivers/irqchip/.

Cheers,
Prabhakar

Good to know. I only use unmodified drivers from the official Linux
kernel so it's not an issue of the Cyrus+ board.

The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
resources to a child platform device. Can you try the following
change:

diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 44a7e58a26e3..47d9b7be60da 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register(
   const char *name, int id)
{
   struct platform_device *pdev;
-   const struct resource *res = ofdev->resource;
-   unsigned int num = ofdev->num_resources;
   int retval;

   pdev = platform_device_alloc(name, id);
@@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_device_register(
   if (retval)
   goto error;

-   if (num) {
-   retval = platform_device_add_resources(pdev, res, num);
-   if (retval)
-   goto error;
-   }
+   pdev->dev.of_node = ofdev->dev.of_node;

>From the log, I think you also need to add this line:

pdev->dev.of_node_reused = true;


   retval = platform_device_add(pdev);
   if (retval)

Hello Rob,

Thanks a lot for your answer.

Is the following patch correct?

Yes


--- a/drivers/usb/host/fsl-mph-dr-of.c2022-05-28 09:10:26.797688422
+0200
+++ b/drivers/usb/host/fsl-mph-dr-of.c2022-05-28 09:15:01.668594809
+0200
@@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_
const char *name, int id)
{
struct platform_device *pdev;
-const struct resource *res = ofdev->resource;
-unsigned int num = ofdev->num_resources;
int retval;

pdev = platform_device_alloc(name, id);
@@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_
if (retval)
goto error;

-if (num) {
-retval = platform_device_add_resources(pdev, res, num);
-if (retval)
-goto error;
-}
+pdev->dev.of_node = ofdev->dev.of_node;
+pdev->dev.of_node_reused = true;

retval = platform_device_add(pdev);
if (retval)

---

Thanks,
Christian

Hello Rob,

I tested this patch today and unfortunately the issue still exists.

The log is the same?

Rob

Yes, it's the same.

Link: http://www.xenosoft.de/dmesg_FSL_P5040_Void_PPC-2.txt

-- Christian

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-06-13 Thread Rob Herring 
On Thu, Jun 9, 2022 at 12:03 PM Christian Zigotzky
 wrote:
>
> On 06 June 2022 at 07:06 pm, Rob Herring wrote:
> > On Mon, Jun 6, 2022 at 11:14 AM Christian Zigotzky
> >  wrote:
> >> On 06 June 2022 at 04:58 pm, Rob Herring wrote:
> >>> On Fri, May 27, 2022 at 9:23 AM Rob Herring  wrote:
>  On Fri, May 27, 2022 at 3:33 AM Christian Zigotzky
>   wrote:
> > On 27 May 2022 at 10:14 am, Prabhakar Mahadev Lad wrote:
> >> Hi,
> >>
> >>> -Original Message-
> >>> From: Christian Zigotzky 
> >>>
> >>> On 27 May 2022 at 09:56 am, Prabhakar Mahadev Lad wrote:
>  Hi,
> 
> > -Original Message-
> > From: Christophe Leroy 
> >>> [...]
> >>>
>  Looks like the driver which you are using has not been converted to 
>  use
> >>> platform_get_irq(), could you please check that.
>  Cheers,
>  Prabhakar
> >>> Do you mean the mouse and keyboard driver?
> >>>
> >> No it could be your gpio/pinctrl driver assuming the keyboard/mouse 
> >> are using GPIO's. If you are using interrupts then it might be some 
> >> hierarchal irqc driver in drivers/irqchip/.
> >>
> >> Cheers,
> >> Prabhakar
> > Good to know. I only use unmodified drivers from the official Linux
> > kernel so it's not an issue of the Cyrus+ board.
>  The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
>  resources to a child platform device. Can you try the following
>  change:
> 
>  diff --git a/drivers/usb/host/fsl-mph-dr-of.c 
>  b/drivers/usb/host/fsl-mph-dr-of.c
>  index 44a7e58a26e3..47d9b7be60da 100644
>  --- a/drivers/usb/host/fsl-mph-dr-of.c
>  +++ b/drivers/usb/host/fsl-mph-dr-of.c
>  @@ -80,8 +80,6 @@ static struct platform_device 
>  *fsl_usb2_device_register(
>    const char *name, int id)
> {
>    struct platform_device *pdev;
>  -   const struct resource *res = ofdev->resource;
>  -   unsigned int num = ofdev->num_resources;
>    int retval;
> 
>    pdev = platform_device_alloc(name, id);
>  @@ -106,11 +104,7 @@ static struct platform_device 
>  *fsl_usb2_device_register(
>    if (retval)
>    goto error;
> 
>  -   if (num) {
>  -   retval = platform_device_add_resources(pdev, res, num);
>  -   if (retval)
>  -   goto error;
>  -   }
>  +   pdev->dev.of_node = ofdev->dev.of_node;
> >>> >From the log, I think you also need to add this line:
> >>>
> >>> pdev->dev.of_node_reused = true;
> >>>
>    retval = platform_device_add(pdev);
>    if (retval)
> >> Hello Rob,
> >>
> >> Thanks a lot for your answer.
> >>
> >> Is the following patch correct?
> > Yes
> >
> >> --- a/drivers/usb/host/fsl-mph-dr-of.c2022-05-28 09:10:26.797688422
> >> +0200
> >> +++ b/drivers/usb/host/fsl-mph-dr-of.c2022-05-28 09:15:01.668594809
> >> +0200
> >> @@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_
> >>const char *name, int id)
> >>{
> >>struct platform_device *pdev;
> >> -const struct resource *res = ofdev->resource;
> >> -unsigned int num = ofdev->num_resources;
> >>int retval;
> >>
> >>pdev = platform_device_alloc(name, id);
> >> @@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_
> >>if (retval)
> >>goto error;
> >>
> >> -if (num) {
> >> -retval = platform_device_add_resources(pdev, res, num);
> >> -if (retval)
> >> -goto error;
> >> -}
> >> +pdev->dev.of_node = ofdev->dev.of_node;
> >> +pdev->dev.of_node_reused = true;
> >>
> >>retval = platform_device_add(pdev);
> >>if (retval)
> >>
> >> ---
> >>
> >> Thanks,
> >> Christian
> Hello Rob,
>
> I tested this patch today and unfortunately the issue still exists.

The log is the same?

Rob

[FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-06-09 Thread Christian Zigotzky 

On 06 June 2022 at 07:06 pm, Rob Herring wrote:

On Mon, Jun 6, 2022 at 11:14 AM Christian Zigotzky
 wrote:

On 06 June 2022 at 04:58 pm, Rob Herring wrote:

On Fri, May 27, 2022 at 9:23 AM Rob Herring  wrote:

On Fri, May 27, 2022 at 3:33 AM Christian Zigotzky
 wrote:

On 27 May 2022 at 10:14 am, Prabhakar Mahadev Lad wrote:

Hi,


-Original Message-
From: Christian Zigotzky 

On 27 May 2022 at 09:56 am, Prabhakar Mahadev Lad wrote:

Hi,


-Original Message-
From: Christophe Leroy 

[...]


Looks like the driver which you are using has not been converted to use

platform_get_irq(), could you please check that.

Cheers,
Prabhakar

Do you mean the mouse and keyboard driver?


No it could be your gpio/pinctrl driver assuming the keyboard/mouse are using 
GPIO's. If you are using interrupts then it might be some hierarchal irqc 
driver in drivers/irqchip/.

Cheers,
Prabhakar

Good to know. I only use unmodified drivers from the official Linux
kernel so it's not an issue of the Cyrus+ board.

The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
resources to a child platform device. Can you try the following
change:

diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 44a7e58a26e3..47d9b7be60da 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register(
  const char *name, int id)
   {
  struct platform_device *pdev;
-   const struct resource *res = ofdev->resource;
-   unsigned int num = ofdev->num_resources;
  int retval;

  pdev = platform_device_alloc(name, id);
@@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_device_register(
  if (retval)
  goto error;

-   if (num) {
-   retval = platform_device_add_resources(pdev, res, num);
-   if (retval)
-   goto error;
-   }
+   pdev->dev.of_node = ofdev->dev.of_node;

>From the log, I think you also need to add this line:

pdev->dev.of_node_reused = true;


  retval = platform_device_add(pdev);
  if (retval)

Hello Rob,

Thanks a lot for your answer.

Is the following patch correct?

Yes


--- a/drivers/usb/host/fsl-mph-dr-of.c2022-05-28 09:10:26.797688422
+0200
+++ b/drivers/usb/host/fsl-mph-dr-of.c2022-05-28 09:15:01.668594809
+0200
@@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_
   const char *name, int id)
   {
   struct platform_device *pdev;
-const struct resource *res = ofdev->resource;
-unsigned int num = ofdev->num_resources;
   int retval;

   pdev = platform_device_alloc(name, id);
@@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_
   if (retval)
   goto error;

-if (num) {
-retval = platform_device_add_resources(pdev, res, num);
-if (retval)
-goto error;
-}
+pdev->dev.of_node = ofdev->dev.of_node;
+pdev->dev.of_node_reused = true;

   retval = platform_device_add(pdev);
   if (retval)

---

Thanks,
Christian

Hello Rob,

I tested this patch today and unfortunately the issue still exists.

Do you have another idea?

Thanks,
Christian

Updated patch:

--- a/drivers/usb/host/fsl-mph-dr-of.c  2022-06-06 02:18:54.0 +0200
+++ b/drivers/usb/host/fsl-mph-dr-of.c  2022-06-09 19:31:50.135472793 +0200
@@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_
    const char *name, int id)
 {
    struct platform_device *pdev;
-   const struct resource *res = ofdev->resource;
-   unsigned int num = ofdev->num_resources;
    int retval;

    pdev = platform_device_alloc(name, id);
@@ -105,12 +103,8 @@ static struct platform_device *fsl_usb2_
    retval = platform_device_add_data(pdev, pdata, sizeof(*pdata));
    if (retval)
    goto error;
-
-   if (num) {
-   retval = platform_device_add_resources(pdev, res, num);
-   if (retval)
-   goto error;
-   }
+    pdev->dev.of_node = ofdev->dev.of_node;
+    pdev->dev.of_node_reused = true;

    retval = platform_device_add(pdev);
    if (retval)

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-06-06 Thread Rob Herring 
On Mon, Jun 6, 2022 at 11:14 AM Christian Zigotzky
 wrote:
>
> On 06 June 2022 at 04:58 pm, Rob Herring wrote:
> > On Fri, May 27, 2022 at 9:23 AM Rob Herring  wrote:
> >> On Fri, May 27, 2022 at 3:33 AM Christian Zigotzky
> >>  wrote:
> >>> On 27 May 2022 at 10:14 am, Prabhakar Mahadev Lad wrote:
>  Hi,
> 
> > -Original Message-
> > From: Christian Zigotzky 
> >
> > On 27 May 2022 at 09:56 am, Prabhakar Mahadev Lad wrote:
> >> Hi,
> >>
> >>> -Original Message-
> >>> From: Christophe Leroy 
> > [...]
> >
> >> Looks like the driver which you are using has not been converted to use
> > platform_get_irq(), could you please check that.
> >> Cheers,
> >> Prabhakar
> > Do you mean the mouse and keyboard driver?
> >
>  No it could be your gpio/pinctrl driver assuming the keyboard/mouse are 
>  using GPIO's. If you are using interrupts then it might be some 
>  hierarchal irqc driver in drivers/irqchip/.
> 
>  Cheers,
>  Prabhakar
> >>> Good to know. I only use unmodified drivers from the official Linux
> >>> kernel so it's not an issue of the Cyrus+ board.
> >> The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
> >> resources to a child platform device. Can you try the following
> >> change:
> >>
> >> diff --git a/drivers/usb/host/fsl-mph-dr-of.c 
> >> b/drivers/usb/host/fsl-mph-dr-of.c
> >> index 44a7e58a26e3..47d9b7be60da 100644
> >> --- a/drivers/usb/host/fsl-mph-dr-of.c
> >> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> >> @@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register(
> >>  const char *name, int id)
> >>   {
> >>  struct platform_device *pdev;
> >> -   const struct resource *res = ofdev->resource;
> >> -   unsigned int num = ofdev->num_resources;
> >>  int retval;
> >>
> >>  pdev = platform_device_alloc(name, id);
> >> @@ -106,11 +104,7 @@ static struct platform_device 
> >> *fsl_usb2_device_register(
> >>  if (retval)
> >>  goto error;
> >>
> >> -   if (num) {
> >> -   retval = platform_device_add_resources(pdev, res, num);
> >> -   if (retval)
> >> -   goto error;
> >> -   }
> >> +   pdev->dev.of_node = ofdev->dev.of_node;
> > >From the log, I think you also need to add this line:
> >
> > pdev->dev.of_node_reused = true;
> >
> >>  retval = platform_device_add(pdev);
> >>  if (retval)
> Hello Rob,
>
> Thanks a lot for your answer.
>
> Is the following patch correct?

Yes

>
> --- a/drivers/usb/host/fsl-mph-dr-of.c2022-05-28 09:10:26.797688422
> +0200
> +++ b/drivers/usb/host/fsl-mph-dr-of.c2022-05-28 09:15:01.668594809
> +0200
> @@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_
>   const char *name, int id)
>   {
>   struct platform_device *pdev;
> -const struct resource *res = ofdev->resource;
> -unsigned int num = ofdev->num_resources;
>   int retval;
>
>   pdev = platform_device_alloc(name, id);
> @@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_
>   if (retval)
>   goto error;
>
> -if (num) {
> -retval = platform_device_add_resources(pdev, res, num);
> -if (retval)
> -goto error;
> -}
> +pdev->dev.of_node = ofdev->dev.of_node;
> +pdev->dev.of_node_reused = true;
>
>   retval = platform_device_add(pdev);
>   if (retval)
>
> ---
>
> Thanks,
> Christian

[FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-06-06 Thread Christian Zigotzky 

On 06 June 2022 at 04:58 pm, Rob Herring wrote:

On Fri, May 27, 2022 at 9:23 AM Rob Herring  wrote:

On Fri, May 27, 2022 at 3:33 AM Christian Zigotzky
 wrote:

On 27 May 2022 at 10:14 am, Prabhakar Mahadev Lad wrote:

Hi,


-Original Message-
From: Christian Zigotzky 

On 27 May 2022 at 09:56 am, Prabhakar Mahadev Lad wrote:

Hi,


-Original Message-
From: Christophe Leroy 

[...]


Looks like the driver which you are using has not been converted to use

platform_get_irq(), could you please check that.

Cheers,
Prabhakar

Do you mean the mouse and keyboard driver?


No it could be your gpio/pinctrl driver assuming the keyboard/mouse are using 
GPIO's. If you are using interrupts then it might be some hierarchal irqc 
driver in drivers/irqchip/.

Cheers,
Prabhakar

Good to know. I only use unmodified drivers from the official Linux
kernel so it's not an issue of the Cyrus+ board.

The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
resources to a child platform device. Can you try the following
change:

diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 44a7e58a26e3..47d9b7be60da 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register(
 const char *name, int id)
  {
 struct platform_device *pdev;
-   const struct resource *res = ofdev->resource;
-   unsigned int num = ofdev->num_resources;
 int retval;

 pdev = platform_device_alloc(name, id);
@@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_device_register(
 if (retval)
 goto error;

-   if (num) {
-   retval = platform_device_add_resources(pdev, res, num);
-   if (retval)
-   goto error;
-   }
+   pdev->dev.of_node = ofdev->dev.of_node;

>From the log, I think you also need to add this line:

pdev->dev.of_node_reused = true;


 retval = platform_device_add(pdev);
 if (retval)

Hello Rob,

Thanks a lot for your answer.

Is the following patch correct?

--- a/drivers/usb/host/fsl-mph-dr-of.c    2022-05-28 09:10:26.797688422 
+0200
+++ b/drivers/usb/host/fsl-mph-dr-of.c    2022-05-28 09:15:01.668594809 
+0200

@@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_
                 const char *name, int id)
 {
 struct platform_device *pdev;
-    const struct resource *res = ofdev->resource;
-    unsigned int num = ofdev->num_resources;
 int retval;

 pdev = platform_device_alloc(name, id);
@@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_
 if (retval)
     goto error;

-    if (num) {
-        retval = platform_device_add_resources(pdev, res, num);
-        if (retval)
-            goto error;
-    }
+    pdev->dev.of_node = ofdev->dev.of_node;
+    pdev->dev.of_node_reused = true;

 retval = platform_device_add(pdev);
 if (retval)

---

Thanks,
Christian

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-06-06 Thread Rob Herring 
On Fri, May 27, 2022 at 9:23 AM Rob Herring  wrote:
>
> On Fri, May 27, 2022 at 3:33 AM Christian Zigotzky
>  wrote:
> >
> > On 27 May 2022 at 10:14 am, Prabhakar Mahadev Lad wrote:
> > > Hi,
> > >
> > >> -Original Message-
> > >> From: Christian Zigotzky 
> > >>
> > >> On 27 May 2022 at 09:56 am, Prabhakar Mahadev Lad wrote:
> > >>> Hi,
> > >>>
> >  -Original Message-
> >  From: Christophe Leroy 

[...]

> > >>> Looks like the driver which you are using has not been converted to use
> > >> platform_get_irq(), could you please check that.
> > >>> Cheers,
> > >>> Prabhakar
> > >> Do you mean the mouse and keyboard driver?
> > >>
> > > No it could be your gpio/pinctrl driver assuming the keyboard/mouse are 
> > > using GPIO's. If you are using interrupts then it might be some 
> > > hierarchal irqc driver in drivers/irqchip/.
> > >
> > > Cheers,
> > > Prabhakar
> > Good to know. I only use unmodified drivers from the official Linux
> > kernel so it's not an issue of the Cyrus+ board.
>
> The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
> resources to a child platform device. Can you try the following
> change:
>
> diff --git a/drivers/usb/host/fsl-mph-dr-of.c 
> b/drivers/usb/host/fsl-mph-dr-of.c
> index 44a7e58a26e3..47d9b7be60da 100644
> --- a/drivers/usb/host/fsl-mph-dr-of.c
> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> @@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register(
> const char *name, int id)
>  {
> struct platform_device *pdev;
> -   const struct resource *res = ofdev->resource;
> -   unsigned int num = ofdev->num_resources;
> int retval;
>
> pdev = platform_device_alloc(name, id);
> @@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_device_register(
> if (retval)
> goto error;
>
> -   if (num) {
> -   retval = platform_device_add_resources(pdev, res, num);
> -   if (retval)
> -   goto error;
> -   }
> +   pdev->dev.of_node = ofdev->dev.of_node;

>From the log, I think you also need to add this line:

pdev->dev.of_node_reused = true;

>
> retval = platform_device_add(pdev);
> if (retval)

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-06-04 Thread Christian Zigotzky 

On 27 May 2022 at 03:40 pm, Darren Stevens wrote:
> Hi Christian,
>
> Can you send me the full dmesg output from this failed boot? I looked 
but can't seem to find which component is at fault here

>
> Thanks
> Darren

On 01 June 2022 at 02:35 pm, Rob Herring wrote:

On Tue, May 31, 2022 at 06:29:38PM +0200, Christian Zigotzky wrote:



On 31. May 2022, at 15:46, Rob Herring  wrote:

On Mon, May 30, 2022 at 12:26 AM Christian Zigotzky
 wrote:

On 27 May 2022 at 04:23 pm, Rob Herring wrote:
The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
resources to a child platform device. Can you try the following
change:

diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 44a7e58a26e3..47d9b7be60da 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register(
 const char *name, int id)
  {
 struct platform_device *pdev;
-   const struct resource *res = ofdev->resource;
-   unsigned int num = ofdev->num_resources;
 int retval;

 pdev = platform_device_alloc(name, id);
@@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_device_register(
 if (retval)
 goto error;

-   if (num) {
-   retval = platform_device_add_resources(pdev, res, num);
-   if (retval)
-   goto error;
-   }
+   pdev->dev.of_node = ofdev->dev.of_node;

 retval = platform_device_add(pdev);
 if (retval)

Hello Rob,

Thanks a lot for your patch! Unfortunately, this leads to a boot loop.
Do you have another idea?

Do you have a dmesg log?

 From the boot loop?

Yes.


The other way to fix is creating a IRQ resource and adding it to the
child device resources.

Good idea.

Not really. I'd rather have the child device just point to the DT node,
but that doesn't seem to work for some drivers and I want to understand
why.

Rob


Hello Rob,
Hello Darren,

The keyboard and mouse issue still exists in the latest git kernel.

Here are the logs:

- http://www.xenosoft.de/dmesg_FSL_P5040_Void_PPC.txt
- http://www.xenosoft.de/dmesg_FSL_P5040_MintPPC.txt
- http://www.xenosoft.de/dmesg_FSL_P5040_Void_PPC_with_Robs_patch.txt

Thanks,
Christian

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-06-01 Thread Rob Herring 
On Tue, May 31, 2022 at 06:29:38PM +0200, Christian Zigotzky wrote:
> 
> 
> > On 31. May 2022, at 15:46, Rob Herring  wrote:
> > 
> > On Mon, May 30, 2022 at 12:26 AM Christian Zigotzky
> >  wrote:
> >> 
> >>> On 27 May 2022 at 04:23 pm, Rob Herring wrote:
> >>> The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
> >>> resources to a child platform device. Can you try the following
> >>> change:
> >>> 
> >>> diff --git a/drivers/usb/host/fsl-mph-dr-of.c 
> >>> b/drivers/usb/host/fsl-mph-dr-of.c
> >>> index 44a7e58a26e3..47d9b7be60da 100644
> >>> --- a/drivers/usb/host/fsl-mph-dr-of.c
> >>> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> >>> @@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register(
> >>> const char *name, int id)
> >>>  {
> >>> struct platform_device *pdev;
> >>> -   const struct resource *res = ofdev->resource;
> >>> -   unsigned int num = ofdev->num_resources;
> >>> int retval;
> >>> 
> >>> pdev = platform_device_alloc(name, id);
> >>> @@ -106,11 +104,7 @@ static struct platform_device 
> >>> *fsl_usb2_device_register(
> >>> if (retval)
> >>> goto error;
> >>> 
> >>> -   if (num) {
> >>> -   retval = platform_device_add_resources(pdev, res, num);
> >>> -   if (retval)
> >>> -   goto error;
> >>> -   }
> >>> +   pdev->dev.of_node = ofdev->dev.of_node;
> >>> 
> >>> retval = platform_device_add(pdev);
> >>> if (retval)
> >> Hello Rob,
> >> 
> >> Thanks a lot for your patch! Unfortunately, this leads to a boot loop.
> >> Do you have another idea?
> > 
> > Do you have a dmesg log?
> 
> From the boot loop?

Yes.

> 
> > 
> > The other way to fix is creating a IRQ resource and adding it to the
> > child device resources.
> 
> Good idea.

Not really. I'd rather have the child device just point to the DT node, 
but that doesn't seem to work for some drivers and I want to understand 
why.

Rob

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-31 Thread Christian Zigotzky 
On 31. May 2022, at 15:46, Rob Herring  wrote:

Do you have a dmesg log?

The other way to fix is creating a IRQ resource and adding it to the
child device resources.

Rob

——

Rob,

Do you mean a dmesg from the boot loop?
The other way is a good idea.

Cheers,
Christian

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-31 Thread Christian Zigotzky 



> On 31. May 2022, at 15:46, Rob Herring  wrote:
> 
> On Mon, May 30, 2022 at 12:26 AM Christian Zigotzky
>  wrote:
>> 
>>> On 27 May 2022 at 04:23 pm, Rob Herring wrote:
>>> The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
>>> resources to a child platform device. Can you try the following
>>> change:
>>> 
>>> diff --git a/drivers/usb/host/fsl-mph-dr-of.c 
>>> b/drivers/usb/host/fsl-mph-dr-of.c
>>> index 44a7e58a26e3..47d9b7be60da 100644
>>> --- a/drivers/usb/host/fsl-mph-dr-of.c
>>> +++ b/drivers/usb/host/fsl-mph-dr-of.c
>>> @@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register(
>>> const char *name, int id)
>>>  {
>>> struct platform_device *pdev;
>>> -   const struct resource *res = ofdev->resource;
>>> -   unsigned int num = ofdev->num_resources;
>>> int retval;
>>> 
>>> pdev = platform_device_alloc(name, id);
>>> @@ -106,11 +104,7 @@ static struct platform_device 
>>> *fsl_usb2_device_register(
>>> if (retval)
>>> goto error;
>>> 
>>> -   if (num) {
>>> -   retval = platform_device_add_resources(pdev, res, num);
>>> -   if (retval)
>>> -   goto error;
>>> -   }
>>> +   pdev->dev.of_node = ofdev->dev.of_node;
>>> 
>>> retval = platform_device_add(pdev);
>>> if (retval)
>> Hello Rob,
>> 
>> Thanks a lot for your patch! Unfortunately, this leads to a boot loop.
>> Do you have another idea?
> 
> Do you have a dmesg log?

From the boot loop?

> 
> The other way to fix is creating a IRQ resource and adding it to the
> child device resources.

Good idea.
> 
> Rob

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-31 Thread Rob Herring 
On Mon, May 30, 2022 at 12:26 AM Christian Zigotzky
 wrote:
>
> On 27 May 2022 at 04:23 pm, Rob Herring wrote:
> > The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
> > resources to a child platform device. Can you try the following
> > change:
> >
> > diff --git a/drivers/usb/host/fsl-mph-dr-of.c 
> > b/drivers/usb/host/fsl-mph-dr-of.c
> > index 44a7e58a26e3..47d9b7be60da 100644
> > --- a/drivers/usb/host/fsl-mph-dr-of.c
> > +++ b/drivers/usb/host/fsl-mph-dr-of.c
> > @@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register(
> >  const char *name, int id)
> >   {
> >  struct platform_device *pdev;
> > -   const struct resource *res = ofdev->resource;
> > -   unsigned int num = ofdev->num_resources;
> >  int retval;
> >
> >  pdev = platform_device_alloc(name, id);
> > @@ -106,11 +104,7 @@ static struct platform_device 
> > *fsl_usb2_device_register(
> >  if (retval)
> >  goto error;
> >
> > -   if (num) {
> > -   retval = platform_device_add_resources(pdev, res, num);
> > -   if (retval)
> > -   goto error;
> > -   }
> > +   pdev->dev.of_node = ofdev->dev.of_node;
> >
> >  retval = platform_device_add(pdev);
> >  if (retval)
> Hello Rob,
>
> Thanks a lot for your patch! Unfortunately, this leads to a boot loop.
> Do you have another idea?

Do you have a dmesg log?

The other way to fix is creating a IRQ resource and adding it to the
child device resources.

Rob

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-29 Thread Christian Zigotzky 

On 27 May 2022 at 04:23 pm, Rob Herring wrote:

The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
resources to a child platform device. Can you try the following
change:

diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 44a7e58a26e3..47d9b7be60da 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register(
 const char *name, int id)
  {
 struct platform_device *pdev;
-   const struct resource *res = ofdev->resource;
-   unsigned int num = ofdev->num_resources;
 int retval;

 pdev = platform_device_alloc(name, id);
@@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_device_register(
 if (retval)
 goto error;

-   if (num) {
-   retval = platform_device_add_resources(pdev, res, num);
-   if (retval)
-   goto error;
-   }
+   pdev->dev.of_node = ofdev->dev.of_node;

 retval = platform_device_add(pdev);
 if (retval)

Hello Rob,

Thanks a lot for your patch! Unfortunately, this leads to a boot loop. 
Do you have another idea?


Thanks,
Christian

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-28 Thread Christian Zigotzky 

On 28 May 2022 at 10:05 am, Christian Zigotzky wrote:

On 27 May 2022 at 04:23 am, Rob Herring wrote:

The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
resources to a child platform device. Can you try the following
change:

diff --git a/drivers/usb/host/fsl-mph-dr-of.c 
b/drivers/usb/host/fsl-mph-dr-of.c

index 44a7e58a26e3..47d9b7be60da 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -80,8 +80,6 @@ static struct platform_device 
*fsl_usb2_device_register(

 const char *name, int id)
  {
 struct platform_device *pdev;
-   const struct resource *res = ofdev->resource;
-   unsigned int num = ofdev->num_resources;
 int retval;

 pdev = platform_device_alloc(name, id);
@@ -106,11 +104,7 @@ static struct platform_device 
*fsl_usb2_device_register(

 if (retval)
 goto error;

-   if (num) {
-   retval = platform_device_add_resources(pdev, res, num);
-   if (retval)
-   goto error;
-   }
+   pdev->dev.of_node = ofdev->dev.of_node;

 retval = platform_device_add(pdev);
 if (retval)

Hi Rob,

Thanks a lot for your patch! :-)

First attempt with the latest git kernel:

patching file a/drivers/usb/host/fsl-mph-dr-of.c
Hunk #1 FAILED at 80.
Hunk #2 FAILED at 106.
2 out of 2 hunks FAILED -- saving rejects to file 
a/drivers/usb/host/fsl-mph-dr-of.c.rej


I created a new patch with your modifications. (see attachment)

Unfortunately I can't test it. The git kernel doesn't compile currently.

powerpc-linux-gnu-ld: net/rds/tcp_stats.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/wireless/wext-spy.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/wireless/wext-priv.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/tipc/bcast.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/bearer.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/tipc/core.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/link.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/discover.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/tipc/msg.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/name_distr.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/tipc/subscr.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/tipc/name_table.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/tipc/net.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/netlink.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/tipc/netlink_compat.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/tipc/node.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/eth_media.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/tipc/topsrv.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/tipc/group.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/trace.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/udp_media.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/tipc/sysctl.o:(.bss+0x40): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): 
first defined here
powerpc-linux-gnu-ld: net/tipc/crypto.o:(.bss+0x0): multiple 
definition of

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-28 Thread Christophe Leroy 


Le 28/05/2022 à 10:05, Christian Zigotzky a écrit :
> On 27 May 2022 at 04:23 am, Rob Herring wrote:
>> The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
>> resources to a child platform device. Can you try the following
>> change:
>>
>> diff --git a/drivers/usb/host/fsl-mph-dr-of.c 
>> b/drivers/usb/host/fsl-mph-dr-of.c
>> index 44a7e58a26e3..47d9b7be60da 100644
>> --- a/drivers/usb/host/fsl-mph-dr-of.c
>> +++ b/drivers/usb/host/fsl-mph-dr-of.c
>> @@ -80,8 +80,6 @@ static struct platform_device 
>> *fsl_usb2_device_register(
>>  const char *name, int id)
>>   {
>>  struct platform_device *pdev;
>> -   const struct resource *res = ofdev->resource;
>> -   unsigned int num = ofdev->num_resources;
>>  int retval;
>>
>>  pdev = platform_device_alloc(name, id);
>> @@ -106,11 +104,7 @@ static struct platform_device 
>> *fsl_usb2_device_register(
>>  if (retval)
>>  goto error;
>>
>> -   if (num) {
>> -   retval = platform_device_add_resources(pdev, res, num);
>> -   if (retval)
>> -   goto error;
>> -   }
>> +   pdev->dev.of_node = ofdev->dev.of_node;
>>
>>  retval = platform_device_add(pdev);
>>  if (retval)
> Hi Rob,
> 
> Thanks a lot for your patch! :-)
> 
> First attempt with the latest git kernel:
> 
> patching file a/drivers/usb/host/fsl-mph-dr-of.c
> Hunk #1 FAILED at 80.
> Hunk #2 FAILED at 106.
> 2 out of 2 hunks FAILED -- saving rejects to file 
> a/drivers/usb/host/fsl-mph-dr-of.c.rej
> 
> I created a new patch with your modifications. (see attachment)
> 
> Unfortunately I can't test it. The git kernel doesn't compile currently.
> 
> powerpc-linux-gnu-ld: net/rds/tcp_stats.o:(.bss+0x0): multiple 
> definition of `cacheline_aligned'; init/version.o:(.bss+0x0): first 
> defined here

...

> make: *** [Makefile:1160: vmlinux] Error 1
> 
> @All
> Could you please check the multiple definition of `cacheline_aligned'?
> 

Fix at 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220527112035.2842155-1-...@ellerman.id.au/

Christophe

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-28 Thread Christian Zigotzky 

On 27 May 2022 at 04:23 am, Rob Herring wrote:

The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the
resources to a child platform device. Can you try the following
change:

diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
index 44a7e58a26e3..47d9b7be60da 100644
--- a/drivers/usb/host/fsl-mph-dr-of.c
+++ b/drivers/usb/host/fsl-mph-dr-of.c
@@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register(
 const char *name, int id)
  {
 struct platform_device *pdev;
-   const struct resource *res = ofdev->resource;
-   unsigned int num = ofdev->num_resources;
 int retval;

 pdev = platform_device_alloc(name, id);
@@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_device_register(
 if (retval)
 goto error;

-   if (num) {
-   retval = platform_device_add_resources(pdev, res, num);
-   if (retval)
-   goto error;
-   }
+   pdev->dev.of_node = ofdev->dev.of_node;

 retval = platform_device_add(pdev);
 if (retval)

Hi Rob,

Thanks a lot for your patch! :-)

First attempt with the latest git kernel:

patching file a/drivers/usb/host/fsl-mph-dr-of.c
Hunk #1 FAILED at 80.
Hunk #2 FAILED at 106.
2 out of 2 hunks FAILED -- saving rejects to file 
a/drivers/usb/host/fsl-mph-dr-of.c.rej


I created a new patch with your modifications. (see attachment)

Unfortunately I can't test it. The git kernel doesn't compile currently.

powerpc-linux-gnu-ld: net/rds/tcp_stats.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): first 
defined here
powerpc-linux-gnu-ld: net/wireless/wext-spy.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): first 
defined here
powerpc-linux-gnu-ld: net/wireless/wext-priv.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): first 
defined here
powerpc-linux-gnu-ld: net/tipc/bcast.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/bearer.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/core.o:(.bss+0x0): multiple definition of 
`cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/link.o:(.bss+0x0): multiple definition of 
`cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/discover.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): first 
defined here
powerpc-linux-gnu-ld: net/tipc/msg.o:(.bss+0x0): multiple definition of 
`cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/name_distr.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): first 
defined here
powerpc-linux-gnu-ld: net/tipc/subscr.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/name_table.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): first 
defined here
powerpc-linux-gnu-ld: net/tipc/net.o:(.bss+0x0): multiple definition of 
`cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/netlink.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/netlink_compat.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): first 
defined here
powerpc-linux-gnu-ld: net/tipc/node.o:(.bss+0x0): multiple definition of 
`cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/eth_media.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): first 
defined here
powerpc-linux-gnu-ld: net/tipc/topsrv.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/group.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/trace.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/udp_media.o:(.bss+0x0): multiple 
definition of `cacheline_aligned'; init/version.o:(.bss+0x0): first 
defined here
powerpc-linux-gnu-ld: net/tipc/sysctl.o:(.bss+0x40): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here
powerpc-linux-gnu-ld: net/tipc/crypto.o:(.bss+0x0): multiple definition 
of `cacheline_aligned'; init/version.o:(.bss+0x0): first defined here

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-27 Thread Rob Herring 
On Fri, May 27, 2022 at 3:33 AM Christian Zigotzky
 wrote:
>
> On 27 May 2022 at 10:14 am, Prabhakar Mahadev Lad wrote:
> > Hi,
> >
> >> -Original Message-
> >> From: Christian Zigotzky 
> >> Sent: 27 May 2022 09:06
> >> To: Prabhakar Mahadev Lad ;
> >> Christophe Leroy ; Rob Herring
> >> 
> >> Cc: Darren Stevens ; linuxppc-dev  >> d...@lists.ozlabs.org>; mad skateman ; R.T.Dickinson
> >> ; Christian Zigotzky 
> >> Subject: [FSL P50x0] Keyboard and mouse don't work anymore after the
> >> devicetree updates for 5.19
> >>
> >> On 27 May 2022 at 09:56 am, Prabhakar Mahadev Lad wrote:
> >>> Hi,
> >>>
>  -Original Message-
>  From: Christophe Leroy 
>  Sent: 27 May 2022 08:23
>  To: Christian Zigotzky ;
>  rob.herr...@calxeda.com; Prabhakar Mahadev Lad
>  
>  Cc: Darren Stevens ; linuxppc-dev   d...@lists.ozlabs.org>; mad skateman ;
>  R.T.Dickinson ; Christian Zigotzky
>  
>  Subject: Re: [FSL P50x0] Keyboard and mouse don't work anymore after
>  the devicetree updates for 5.19
> 
>  Hi
> 
>  Le 26/05/2022 à 19:42, Christian Zigotzky a écrit :
> > Hello,
> >
> > My keyboard and mouse don't work anymore with my Cyrus+ board with a
> > FSL
> > P50x0 PowerPC SoC [1] after the devicetree updates for 5.19 [2].
> > After reverting the devicetree updates, my keyboard and mouse work
> > without any problems.
> > I figured out that the issue is in the patch for the file platform.c
> > [3].  I created a patch for reverting the problematic code. (see
> > attachment)
> > After reverting the changes with the attached patch, the keyboard
> > and mouse work again.
> > Please check your changes in the file platform.c [3].
> >
> > Thanks,
> > Christian
> >
> > [1]
> > https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwiki.
> > amiga.org%2Findex.php%3Ftitle%3DX5000data=05%7C01%7Cprabhakar.m
> > ah
> > adev-lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53
> > d8
> > 2571da1947e49cb4625a166a4a2a%7C0%7C0%7C637892329912063922%7CUnknown%
> > 7C
> > TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX
> > VC
> > I6Mn0%3D%7C3000%7C%7C%7Csdata=fSABvBDi%2FYlqU1eydQB6%2F4BzxXkqR
> > M0
> > Ln9hdInyTp6w%3Dreserved=0
> > [2]
> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> > kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git
> > %2
> > Fcommit%2F%3Fid%3D86c87bea6b42100c67418af690919c44de6ede6edata=
> > 05
> > %7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34
> > bd
> > 4208da3fb1c007%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C63789232
> > 99
> > 12063922%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzI
> > iL
> > CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=ENkjlza0J7xF
> > iI
> > aPUwMBxHBIkXJNkT%2BLTZ3xuPz%2B10Q%3Dreserved=0
> >
> > [3]
> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> > kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git
> > %2
> > Fdiff%2Fdrivers%2Fof%2Fplatform.c%3Fid%3D86c87bea6b42100c67418af6909
> > 19
> > c44de6ede6edata=05%7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas
> > .c
> > om%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d82571da1947e49cb4625a166a
> > 4a
> > 2a%7C0%7C0%7C637892329912063922%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w
> > Lj
> > AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C
> > 
> > mp;sdata=yEJUK%2BGK2dzWARC5rfhsSSFSwD%2BLZm8aNNHqQhPYP7Y%3Drese
> > rv
> > ed=0
>  Based on your patch I would say the culprit commit is
>  https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
>  hub.c%2Fdata=05%7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas.com
>  %7Cbf899ff2084643971c7908da3fb7d4b9%7C53d82571da1947e49cb4625a166a4a2
>  a%7C0%7C1%7C637892356025845542%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
>  AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&
>  amp;sdata=%2FzI4yueF6Pc%2Fpvh7Ax9WilnaYX8ozFTRyQpiVaaacbg%3Drese
>  rved=0
>  om%2Ftorvalds%2Flinux%2Fcommit%2Fa1a2b7125e1079cfcc13a116aa3af3df2f9e
>  002b&
>  amp;data=05%7C01%7Cprabhakar.mahadev-
>  lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d82571
>  da194
>  7e49cb4625a166a4a2a%7C0%7C0%7C637892329912063922%7CUnknown%7CTWFpbGZs
>  b3d8e
>  yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
>  000%7
>  C%7C%7Csdata=ONR1CiaSID6q4%2Fo%2BI6MlPA4ij89BJphQRpEu5tQxvYQ%3D&
>  amp;r
>  eserved=0
> 
>  commit a1a2b7125e1079cfcc13a116aa3af3df2f9e002b
>  Author: Lad Prabhakar 
>  Date:   Wed Mar 16 20:06:33 2022 +
> 
> of/platform: Drop static setup of IRQ resource from DT

[FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-27 Thread Christian Zigotzky 

On 27 May 2022 at 10:14 am, Prabhakar Mahadev Lad wrote:

Hi,


-Original Message-
From: Christian Zigotzky 
Sent: 27 May 2022 09:06
To: Prabhakar Mahadev Lad ;
Christophe Leroy ; Rob Herring

Cc: Darren Stevens ; linuxppc-dev ; mad skateman ; R.T.Dickinson
; Christian Zigotzky 
Subject: [FSL P50x0] Keyboard and mouse don't work anymore after the
devicetree updates for 5.19

On 27 May 2022 at 09:56 am, Prabhakar Mahadev Lad wrote:

Hi,


-Original Message-
From: Christophe Leroy 
Sent: 27 May 2022 08:23
To: Christian Zigotzky ;
rob.herr...@calxeda.com; Prabhakar Mahadev Lad

Cc: Darren Stevens ; linuxppc-dev ; mad skateman ;
R.T.Dickinson ; Christian Zigotzky

Subject: Re: [FSL P50x0] Keyboard and mouse don't work anymore after
the devicetree updates for 5.19

Hi

Le 26/05/2022 à 19:42, Christian Zigotzky a écrit :

Hello,

My keyboard and mouse don't work anymore with my Cyrus+ board with a
FSL
P50x0 PowerPC SoC [1] after the devicetree updates for 5.19 [2].
After reverting the devicetree updates, my keyboard and mouse work
without any problems.
I figured out that the issue is in the patch for the file platform.c
[3].  I created a patch for reverting the problematic code. (see
attachment)
After reverting the changes with the attached patch, the keyboard
and mouse work again.
Please check your changes in the file platform.c [3].

Thanks,
Christian

[1]
https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwiki.
amiga.org%2Findex.php%3Ftitle%3DX5000data=05%7C01%7Cprabhakar.m
ah
adev-lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53
d8
2571da1947e49cb4625a166a4a2a%7C0%7C0%7C637892329912063922%7CUnknown%
7C
TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX
VC
I6Mn0%3D%7C3000%7C%7C%7Csdata=fSABvBDi%2FYlqU1eydQB6%2F4BzxXkqR
M0
Ln9hdInyTp6w%3Dreserved=0
[2]
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git
%2
Fcommit%2F%3Fid%3D86c87bea6b42100c67418af690919c44de6ede6edata=
05
%7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34
bd
4208da3fb1c007%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C63789232
99
12063922%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzI
iL
CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=ENkjlza0J7xF
iI
aPUwMBxHBIkXJNkT%2BLTZ3xuPz%2B10Q%3Dreserved=0

[3]
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git
%2
Fdiff%2Fdrivers%2Fof%2Fplatform.c%3Fid%3D86c87bea6b42100c67418af6909
19
c44de6ede6edata=05%7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas
.c
om%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d82571da1947e49cb4625a166a
4a
2a%7C0%7C0%7C637892329912063922%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w
Lj
AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C

mp;sdata=yEJUK%2BGK2dzWARC5rfhsSSFSwD%2BLZm8aNNHqQhPYP7Y%3Drese
rv
ed=0

Based on your patch I would say the culprit commit is
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
hub.c%2Fdata=05%7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas.com
%7Cbf899ff2084643971c7908da3fb7d4b9%7C53d82571da1947e49cb4625a166a4a2
a%7C0%7C1%7C637892356025845542%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&
amp;sdata=%2FzI4yueF6Pc%2Fpvh7Ax9WilnaYX8ozFTRyQpiVaaacbg%3Drese
rved=0
om%2Ftorvalds%2Flinux%2Fcommit%2Fa1a2b7125e1079cfcc13a116aa3af3df2f9e
002b&
amp;data=05%7C01%7Cprabhakar.mahadev-
lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d82571
da194
7e49cb4625a166a4a2a%7C0%7C0%7C637892329912063922%7CUnknown%7CTWFpbGZs
b3d8e
yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
000%7
C%7C%7Csdata=ONR1CiaSID6q4%2Fo%2BI6MlPA4ij89BJphQRpEu5tQxvYQ%3D&
amp;r
eserved=0

commit a1a2b7125e1079cfcc13a116aa3af3df2f9e002b
Author: Lad Prabhakar 
Date:   Wed Mar 16 20:06:33 2022 +

   of/platform: Drop static setup of IRQ resource from DT core

   Now that all the DT drivers have switched to platform_get_irq()
we can now
   safely drop the static setup of IRQ resource from DT core code.

   With the above change hierarchical setup of irq domains is no

longer

   bypassed and thus allowing hierarchical interrupt domains to

describe

   interrupts using "interrupts" DT property.

   Signed-off-by: Lad Prabhakar 
   Acked-by: Marc Zyngier 
   Tested-by: Marc Zyngier 
   Signed-off-by: Rob Herring 
   Link:
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flor
e.ker%2Fdata=05%7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas.com
%7Cbf899ff2084643971c7908da3fb7d4b9%7C53d82571da1947e49cb4625a166a4a2
a%7C0%7C1%7C637892356025845542%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&
amp;sdata=R%2FhdNkjna6kT31Fy9L3HjrDscWR743O%2BAY8sITu9pVE%3Drese
rved=0

RE: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-27 Thread Prabhakar Mahadev Lad 
Hi,

> -Original Message-
> From: Christian Zigotzky 
> Sent: 27 May 2022 09:06
> To: Prabhakar Mahadev Lad ;
> Christophe Leroy ; Rob Herring
> 
> Cc: Darren Stevens ; linuxppc-dev  d...@lists.ozlabs.org>; mad skateman ; R.T.Dickinson
> ; Christian Zigotzky 
> Subject: [FSL P50x0] Keyboard and mouse don't work anymore after the
> devicetree updates for 5.19
> 
> On 27 May 2022 at 09:56 am, Prabhakar Mahadev Lad wrote:
> > Hi,
> >
> >> -Original Message-
> >> From: Christophe Leroy 
> >> Sent: 27 May 2022 08:23
> >> To: Christian Zigotzky ;
> >> rob.herr...@calxeda.com; Prabhakar Mahadev Lad
> >> 
> >> Cc: Darren Stevens ; linuxppc-dev  >> d...@lists.ozlabs.org>; mad skateman ;
> >> R.T.Dickinson ; Christian Zigotzky
> >> 
> >> Subject: Re: [FSL P50x0] Keyboard and mouse don't work anymore after
> >> the devicetree updates for 5.19
> >>
> >> Hi
> >>
> >> Le 26/05/2022 à 19:42, Christian Zigotzky a écrit :
> >>> Hello,
> >>>
> >>> My keyboard and mouse don't work anymore with my Cyrus+ board with a
> >>> FSL
> >>> P50x0 PowerPC SoC [1] after the devicetree updates for 5.19 [2].
> >>> After reverting the devicetree updates, my keyboard and mouse work
> >>> without any problems.
> >>> I figured out that the issue is in the patch for the file platform.c
> >>> [3].  I created a patch for reverting the problematic code. (see
> >>> attachment)
> >>> After reverting the changes with the attached patch, the keyboard
> >>> and mouse work again.
> >>> Please check your changes in the file platform.c [3].
> >>>
> >>> Thanks,
> >>> Christian
> >>>
> >>> [1]
> >>> https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwiki.
> >>> amiga.org%2Findex.php%3Ftitle%3DX5000data=05%7C01%7Cprabhakar.m
> >>> ah
> >>> adev-lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53
> >>> d8
> >>> 2571da1947e49cb4625a166a4a2a%7C0%7C0%7C637892329912063922%7CUnknown%
> >>> 7C
> >>> TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX
> >>> VC
> >>> I6Mn0%3D%7C3000%7C%7C%7Csdata=fSABvBDi%2FYlqU1eydQB6%2F4BzxXkqR
> >>> M0
> >>> Ln9hdInyTp6w%3Dreserved=0
> >>> [2]
> >>> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> >>> kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git
> >>> %2
> >>> Fcommit%2F%3Fid%3D86c87bea6b42100c67418af690919c44de6ede6edata=
> >>> 05
> >>> %7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34
> >>> bd
> >>> 4208da3fb1c007%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C63789232
> >>> 99
> >>> 12063922%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzI
> >>> iL
> >>> CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=ENkjlza0J7xF
> >>> iI
> >>> aPUwMBxHBIkXJNkT%2BLTZ3xuPz%2B10Q%3Dreserved=0
> >>>
> >>> [3]
> >>> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> >>> kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git
> >>> %2
> >>> Fdiff%2Fdrivers%2Fof%2Fplatform.c%3Fid%3D86c87bea6b42100c67418af6909
> >>> 19
> >>> c44de6ede6edata=05%7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas
> >>> .c
> >>> om%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d82571da1947e49cb4625a166a
> >>> 4a
> >>> 2a%7C0%7C0%7C637892329912063922%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w
> >>> Lj
> >>> AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C
> >>> 
> >>> mp;sdata=yEJUK%2BGK2dzWARC5rfhsSSFSwD%2BLZm8aNNHqQhPYP7Y%3Drese
> >>> rv
> >>> ed=0
> >>
> >> Based on your patch I would say the culprit commit is
> >> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit
> >> hub.c%2Fdata=05%7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas.com
> >> %7Cbf899ff2084643971c7908da3fb7d4b9%7C53d82571da1947e49cb4625a166a4a2
> >> a%7C0%7C1%7C637892356025845542%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
> >> AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&
> >> amp;sdata=%2FzI4yueF6Pc%2Fpvh7Ax9WilnaYX8ozFTRyQpiVaaacbg%3Drese
> >> rved=0
> >> om%2Ftorvalds%2Flinux%2Fcommit%2Fa1a2b7125e1079cfcc13a116aa3af3df2f9e
> >> 002b&
> >> amp;data=05%7C01%7Cprabhakar.mahadev-
> >> lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d82571
> >> da194
> >> 7e49cb4625a166a4a2a%7C0%7C0%7C637892329912063922%7CUnknown%7CTWFpbGZs
> >> b3d8e
> >> yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> >> 000%7
> >> C%7C%7Csdata=ONR1CiaSID6q4%2Fo%2BI6MlPA4ij89BJphQRpEu5tQxvYQ%3D&
> >> amp;r
> >> eserved=0
> >>
> >> commit a1a2b7125e1079cfcc13a116aa3af3df2f9e002b
> >> Author: Lad Prabhakar 
> >> Date:   Wed Mar 16 20:06:33 2022 +
> >>
> >>   of/platform: Drop static setup of IRQ resource from DT core
> >>
> >>   Now that all the DT drivers have switched to platform_get_irq()
> >> we can now
> >>   safely drop the static setup of IRQ resource from DT core code.
> >>
> >>   With the above change hierarchical setup of irq domains is no
> longer
> >>   bypassed and thus allowing hierarchical interrupt domains to
> describe
> >>   interrupts using

[FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-27 Thread Christian Zigotzky 

On 27 May 2022 at 09:56 am, Prabhakar Mahadev Lad wrote:

Hi,


-Original Message-
From: Christophe Leroy 
Sent: 27 May 2022 08:23
To: Christian Zigotzky ; rob.herr...@calxeda.com;
Prabhakar Mahadev Lad 
Cc: Darren Stevens ; linuxppc-dev ; mad skateman ; R.T.Dickinson
; Christian Zigotzky 
Subject: Re: [FSL P50x0] Keyboard and mouse don't work anymore after the
devicetree updates for 5.19

Hi

Le 26/05/2022 à 19:42, Christian Zigotzky a écrit :

Hello,

My keyboard and mouse don't work anymore with my Cyrus+ board with a
FSL
P50x0 PowerPC SoC [1] after the devicetree updates for 5.19 [2].
After reverting the devicetree updates, my keyboard and mouse work
without any problems.
I figured out that the issue is in the patch for the file platform.c
[3].  I created a patch for reverting the problematic code. (see
attachment)
After reverting the changes with the attached patch, the keyboard and
mouse work again.
Please check your changes in the file platform.c [3].

Thanks,
Christian

[1]
https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwiki.
amiga.org%2Findex.php%3Ftitle%3DX5000data=05%7C01%7Cprabhakar.mah
adev-lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d8
2571da1947e49cb4625a166a4a2a%7C0%7C0%7C637892329912063922%7CUnknown%7C
TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
I6Mn0%3D%7C3000%7C%7C%7Csdata=fSABvBDi%2FYlqU1eydQB6%2F4BzxXkqRM0
Ln9hdInyTp6w%3Dreserved=0
[2]
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2
Fcommit%2F%3Fid%3D86c87bea6b42100c67418af690919c44de6ede6edata=05
%7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd
4208da3fb1c007%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C6378923299
12063922%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=ENkjlza0J7xFiI
aPUwMBxHBIkXJNkT%2BLTZ3xuPz%2B10Q%3Dreserved=0

[3]
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2
Fdiff%2Fdrivers%2Fof%2Fplatform.c%3Fid%3D86c87bea6b42100c67418af690919
c44de6ede6edata=05%7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas.c
om%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d82571da1947e49cb4625a166a4a
2a%7C0%7C0%7C637892329912063922%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C
mp;sdata=yEJUK%2BGK2dzWARC5rfhsSSFSwD%2BLZm8aNNHqQhPYP7Y%3Dreserv
ed=0


Based on your patch I would say the culprit commit is
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c
om%2Ftorvalds%2Flinux%2Fcommit%2Fa1a2b7125e1079cfcc13a116aa3af3df2f9e002b&
amp;data=05%7C01%7Cprabhakar.mahadev-
lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d82571da194
7e49cb4625a166a4a2a%7C0%7C0%7C637892329912063922%7CUnknown%7CTWFpbGZsb3d8e
yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7
C%7C%7Csdata=ONR1CiaSID6q4%2Fo%2BI6MlPA4ij89BJphQRpEu5tQxvYQ%3Dr
eserved=0

commit a1a2b7125e1079cfcc13a116aa3af3df2f9e002b
Author: Lad Prabhakar 
Date:   Wed Mar 16 20:06:33 2022 +

  of/platform: Drop static setup of IRQ resource from DT core

  Now that all the DT drivers have switched to platform_get_irq() we
can now
  safely drop the static setup of IRQ resource from DT core code.

  With the above change hierarchical setup of irq domains is no longer
  bypassed and thus allowing hierarchical interrupt domains to describe
  interrupts using "interrupts" DT property.

  Signed-off-by: Lad Prabhakar 
  Acked-by: Marc Zyngier 
  Tested-by: Marc Zyngier 
  Signed-off-by: Rob Herring 
  Link:
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.ker
nel.org%2Fr%2F20220316200633.28974-1-prabhakar.mahadev-
lad.rj%40bp.renesas.comdata=05%7C01%7Cprabhakar.mahadev-
lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d82571da194
7e49cb4625a166a4a2a%7C0%7C0%7C637892329912063922%7CUnknown%7CTWFpbGZsb3d8e
yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7
C%7C%7Csdata=ri76vfLpmxe7vFDAlsBjyrSSkuTMz0ydftu3XObLGLA%3Dreser
ved=0


Looks like the driver which you are using has not been converted to use 
platform_get_irq(), could you please check that.

Cheers,
Prabhakar

Do you mean the mouse and keyboard driver?

-- Christian

RE: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-27 Thread Prabhakar Mahadev Lad 
Hi,

> -Original Message-
> From: Christophe Leroy 
> Sent: 27 May 2022 08:23
> To: Christian Zigotzky ; rob.herr...@calxeda.com;
> Prabhakar Mahadev Lad 
> Cc: Darren Stevens ; linuxppc-dev  d...@lists.ozlabs.org>; mad skateman ; R.T.Dickinson
> ; Christian Zigotzky 
> Subject: Re: [FSL P50x0] Keyboard and mouse don't work anymore after the
> devicetree updates for 5.19
> 
> Hi
> 
> Le 26/05/2022 à 19:42, Christian Zigotzky a écrit :
> > Hello,
> >
> > My keyboard and mouse don't work anymore with my Cyrus+ board with a
> > FSL
> > P50x0 PowerPC SoC [1] after the devicetree updates for 5.19 [2].
> > After reverting the devicetree updates, my keyboard and mouse work
> > without any problems.
> > I figured out that the issue is in the patch for the file platform.c
> > [3].  I created a patch for reverting the problematic code. (see
> > attachment)
> > After reverting the changes with the attached patch, the keyboard and
> > mouse work again.
> > Please check your changes in the file platform.c [3].
> >
> > Thanks,
> > Christian
> >
> > [1]
> > https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwiki.
> > amiga.org%2Findex.php%3Ftitle%3DX5000data=05%7C01%7Cprabhakar.mah
> > adev-lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d8
> > 2571da1947e49cb4625a166a4a2a%7C0%7C0%7C637892329912063922%7CUnknown%7C
> > TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
> > I6Mn0%3D%7C3000%7C%7C%7Csdata=fSABvBDi%2FYlqU1eydQB6%2F4BzxXkqRM0
> > Ln9hdInyTp6w%3Dreserved=0
> > [2]
> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> > kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2
> > Fcommit%2F%3Fid%3D86c87bea6b42100c67418af690919c44de6ede6edata=05
> > %7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd
> > 4208da3fb1c007%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C6378923299
> > 12063922%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
> > CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7Csdata=ENkjlza0J7xFiI
> > aPUwMBxHBIkXJNkT%2BLTZ3xuPz%2B10Q%3Dreserved=0
> >
> > [3]
> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> > kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2
> > Fdiff%2Fdrivers%2Fof%2Fplatform.c%3Fid%3D86c87bea6b42100c67418af690919
> > c44de6ede6edata=05%7C01%7Cprabhakar.mahadev-lad.rj%40bp.renesas.c
> > om%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d82571da1947e49cb4625a166a4a
> > 2a%7C0%7C0%7C637892329912063922%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
> > AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C
> > mp;sdata=yEJUK%2BGK2dzWARC5rfhsSSFSwD%2BLZm8aNNHqQhPYP7Y%3Dreserv
> > ed=0
> 
> 
> Based on your patch I would say the culprit commit is
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.c
> om%2Ftorvalds%2Flinux%2Fcommit%2Fa1a2b7125e1079cfcc13a116aa3af3df2f9e002b&
> amp;data=05%7C01%7Cprabhakar.mahadev-
> lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d82571da194
> 7e49cb4625a166a4a2a%7C0%7C0%7C637892329912063922%7CUnknown%7CTWFpbGZsb3d8e
> yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7
> C%7C%7Csdata=ONR1CiaSID6q4%2Fo%2BI6MlPA4ij89BJphQRpEu5tQxvYQ%3Dr
> eserved=0
> 
> commit a1a2b7125e1079cfcc13a116aa3af3df2f9e002b
> Author: Lad Prabhakar 
> Date:   Wed Mar 16 20:06:33 2022 +
> 
>  of/platform: Drop static setup of IRQ resource from DT core
> 
>  Now that all the DT drivers have switched to platform_get_irq() we
> can now
>  safely drop the static setup of IRQ resource from DT core code.
> 
>  With the above change hierarchical setup of irq domains is no longer
>  bypassed and thus allowing hierarchical interrupt domains to describe
>  interrupts using "interrupts" DT property.
> 
>  Signed-off-by: Lad Prabhakar  lad...@bp.renesas.com>
>  Acked-by: Marc Zyngier 
>  Tested-by: Marc Zyngier 
>  Signed-off-by: Rob Herring 
>  Link:
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.ker
> nel.org%2Fr%2F20220316200633.28974-1-prabhakar.mahadev-
> lad.rj%40bp.renesas.comdata=05%7C01%7Cprabhakar.mahadev-
> lad.rj%40bp.renesas.com%7C4e9c08d1e3874a34bd4208da3fb1c007%7C53d82571da194
> 7e49cb4625a166a4a2a%7C0%7C0%7C637892329912063922%7CUnknown%7CTWFpbGZsb3d8e
> yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7
> C%7C%7Csdata=ri76vfLpmxe7vFDAlsBjyrSSkuTMz0ydftu3XObLGLA%3Dreser
> ved=0
> 
Looks like the driver which you are using has not been converted to use 
platform_get_irq(), could you please check that. 

Cheers,
Prabhakar

Fwd: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-27 Thread Christian Zigotzky 

Rob's email address corrected.

-- Christian


On 27 May 2022 at 09:23 am, Christophe Leroy wrote:

Hi

Le 26/05/2022 à 19:42, Christian Zigotzky a écrit :

Hello,

My keyboard and mouse don't work anymore with my Cyrus+ board with a FSL
P50x0 PowerPC SoC [1] after the devicetree updates for 5.19 [2].
After reverting the devicetree updates, my keyboard and mouse work
without any problems.
I figured out that the issue is in the patch for the file platform.c
[3].  I created a patch for reverting the problematic code. (see
attachment)
After reverting the changes with the attached patch, the keyboard and
mouse work again.
Please check your changes in the file platform.c [3].

Thanks,
Christian

[1] http://wiki.amiga.org/index.php?title=X5000
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=86c87bea6b42100c67418af690919c44de6ede6e

[3]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/drivers/of/platform.c?id=86c87bea6b42100c67418af690919c44de6ede6e


Based on your patch I would say the culprit commit is
https://github.com/torvalds/linux/commit/a1a2b7125e1079cfcc13a116aa3af3df2f9e002b

commit a1a2b7125e1079cfcc13a116aa3af3df2f9e002b
Author: Lad Prabhakar 
Date: Wed Mar 16 20:06:33 2022 +

of/platform: Drop static setup of IRQ resource from DT core

Now that all the DT drivers have switched to platform_get_irq() we
can now
safely drop the static setup of IRQ resource from DT core code.

With the above change hierarchical setup of irq domains is no longer
bypassed and thus allowing hierarchical interrupt domains to describe
interrupts using "interrupts" DT property.

Signed-off-by: Lad Prabhakar 
Acked-by: Marc Zyngier 
Tested-by: Marc Zyngier 
Signed-off-by: Rob Herring 
Link:
https://lore.kernel.org/r/20220316200633.28974-1-prabhakar.mahadev-lad...@bp.renesas.com



Can you please provide you device tree ?

Do you use any out-of-tree drivers ?

Thanks
Christophe

Hi Christophe,

No, I don't use any out-of-tree drivers. Please find attached the dtb, 
dts, and the dtsi file.


Thanks,
Christian/*
 * P5040 Silicon/SoC Device Tree Source (pre include)
 *
 * Copyright 2012 - 2015 Freescale Semiconductor Inc.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are met:
 * * Redistributions of source code must retain the above copyright
 *   notice, this list of conditions and the following disclaimer.
 * * Redistributions in binary form must reproduce the above copyright
 *   notice, this list of conditions and the following disclaimer in the
 *   documentation and/or other materials provided with the distribution.
 * * Neither the name of Freescale Semiconductor nor the
 *   names of its contributors may be used to endorse or promote products
 *   derived from this software without specific prior written permission.
 *
 *
 * ALTERNATIVELY, this software may be distributed under the terms of the
 * GNU General Public License ("GPL") as published by the Free Software
 * Foundation, either version 2 of that License or (at your option) any
 * later version.
 *
 * This software is provided by Freescale Semiconductor "as is" and any
 * express or implied warranties, including, but not limited to, the implied
 * warranties of merchantability and fitness for a particular purpose are
 * disclaimed. In no event shall Freescale Semiconductor be liable for any
 * direct, indirect, incidental, special, exemplary, or consequential damages
 * (including, but not limited to, procurement of substitute goods or services;
 * loss of use, data, or profits; or business interruption) however caused and
 * on any theory of liability, whether in contract, strict liability, or tort
 * (including negligence or otherwise) arising in any way out of the use of this
 * software, even if advised of the possibility of such damage.
 */

/dts-v1/;

/include/ "e5500_power_isa.dtsi"

/ {
compatible = "fsl,P5040";
#address-cells = <2>;
#size-cells = <2>;
interrupt-parent = <>;

aliases {
ccsr = 
dcsr = 

serial0 = 
serial1 = 
serial2 = 
serial3 = 
pci0 = 
pci1 = 
pci2 = 
usb0 = 
usb1 = 
dma0 = 
dma1 = 
sdhc = 
msi0 = 
msi1 = 
msi2 = 

crypto = 
sec_jr0 = _jr0;
sec_jr1 = _jr1;
sec_jr2 = _jr2;
sec_jr3 = _jr3;
rtic_a = _a;
rtic_b = _b;
rtic_c = _c;
rtic_d = _d;
sec_mon = _mon;

raideng = 
raideng_jr0 = _jr0;
raideng_jr1 = _jr1;
raideng_jr2 = _jr2;

[FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-27 Thread Christian Zigotzky 

On 27 May 2022 at 09:23 am, Christophe Leroy wrote:

Hi

Le 26/05/2022 à 19:42, Christian Zigotzky a écrit :

Hello,

My keyboard and mouse don't work anymore with my Cyrus+ board with a FSL
P50x0 PowerPC SoC [1] after the devicetree updates for 5.19 [2].
After reverting the devicetree updates, my keyboard and mouse work
without any problems.
I figured out that the issue is in the patch for the file platform.c
[3].  I created a patch for reverting the problematic code. (see
attachment)
After reverting the changes with the attached patch, the keyboard and
mouse work again.
Please check your changes in the file platform.c [3].

Thanks,
Christian

[1] http://wiki.amiga.org/index.php?title=X5000
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=86c87bea6b42100c67418af690919c44de6ede6e

[3]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/drivers/of/platform.c?id=86c87bea6b42100c67418af690919c44de6ede6e


Based on your patch I would say the culprit commit is
https://github.com/torvalds/linux/commit/a1a2b7125e1079cfcc13a116aa3af3df2f9e002b

commit a1a2b7125e1079cfcc13a116aa3af3df2f9e002b
Author: Lad Prabhakar 
Date:   Wed Mar 16 20:06:33 2022 +

  of/platform: Drop static setup of IRQ resource from DT core

  Now that all the DT drivers have switched to platform_get_irq() we
can now
  safely drop the static setup of IRQ resource from DT core code.

  With the above change hierarchical setup of irq domains is no longer
  bypassed and thus allowing hierarchical interrupt domains to describe
  interrupts using "interrupts" DT property.

  Signed-off-by: Lad Prabhakar 
  Acked-by: Marc Zyngier 
  Tested-by: Marc Zyngier 
  Signed-off-by: Rob Herring 
  Link:
https://lore.kernel.org/r/20220316200633.28974-1-prabhakar.mahadev-lad...@bp.renesas.com



Can you please provide you device tree ?

Do you use any out-of-tree drivers ?

Thanks
Christophe

Hi Christophe,

No, I don't use any out-of-tree drivers. Please find attached the dtb, 
dts, and the dtsi file.


Thanks,
Christian/*
 * P5040 Silicon/SoC Device Tree Source (pre include)
 *
 * Copyright 2012 - 2015 Freescale Semiconductor Inc.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are met:
 * * Redistributions of source code must retain the above copyright
 *   notice, this list of conditions and the following disclaimer.
 * * Redistributions in binary form must reproduce the above copyright
 *   notice, this list of conditions and the following disclaimer in the
 *   documentation and/or other materials provided with the distribution.
 * * Neither the name of Freescale Semiconductor nor the
 *   names of its contributors may be used to endorse or promote products
 *   derived from this software without specific prior written permission.
 *
 *
 * ALTERNATIVELY, this software may be distributed under the terms of the
 * GNU General Public License ("GPL") as published by the Free Software
 * Foundation, either version 2 of that License or (at your option) any
 * later version.
 *
 * This software is provided by Freescale Semiconductor "as is" and any
 * express or implied warranties, including, but not limited to, the implied
 * warranties of merchantability and fitness for a particular purpose are
 * disclaimed. In no event shall Freescale Semiconductor be liable for any
 * direct, indirect, incidental, special, exemplary, or consequential damages
 * (including, but not limited to, procurement of substitute goods or services;
 * loss of use, data, or profits; or business interruption) however caused and
 * on any theory of liability, whether in contract, strict liability, or tort
 * (including negligence or otherwise) arising in any way out of the use of this
 * software, even if advised of the possibility of such damage.
 */

/dts-v1/;

/include/ "e5500_power_isa.dtsi"

/ {
compatible = "fsl,P5040";
#address-cells = <2>;
#size-cells = <2>;
interrupt-parent = <>;

aliases {
ccsr = 
dcsr = 

serial0 = 
serial1 = 
serial2 = 
serial3 = 
pci0 = 
pci1 = 
pci2 = 
usb0 = 
usb1 = 
dma0 = 
dma1 = 
sdhc = 
msi0 = 
msi1 = 
msi2 = 

crypto = 
sec_jr0 = _jr0;
sec_jr1 = _jr1;
sec_jr2 = _jr2;
sec_jr3 = _jr3;
rtic_a = _a;
rtic_b = _b;
rtic_c = _c;
rtic_d = _d;
sec_mon = _mon;

raideng = 
raideng_jr0 = _jr0;
raideng_jr1 = _jr1;

Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19

2022-05-27 Thread Christophe Leroy 
Hi

Le 26/05/2022 à 19:42, Christian Zigotzky a écrit :
> Hello,
> 
> My keyboard and mouse don't work anymore with my Cyrus+ board with a FSL 
> P50x0 PowerPC SoC [1] after the devicetree updates for 5.19 [2].
> After reverting the devicetree updates, my keyboard and mouse work 
> without any problems.
> I figured out that the issue is in the patch for the file platform.c 
> [3].  I created a patch for reverting the problematic code. (see 
> attachment)
> After reverting the changes with the attached patch, the keyboard and 
> mouse work again.
> Please check your changes in the file platform.c [3].
> 
> Thanks,
> Christian
> 
> [1] http://wiki.amiga.org/index.php?title=X5000
> [2] 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=86c87bea6b42100c67418af690919c44de6ede6e
>  
> 
> [3] 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/drivers/of/platform.c?id=86c87bea6b42100c67418af690919c44de6ede6e


Based on your patch I would say the culprit commit is 
https://github.com/torvalds/linux/commit/a1a2b7125e1079cfcc13a116aa3af3df2f9e002b

commit a1a2b7125e1079cfcc13a116aa3af3df2f9e002b
Author: Lad Prabhakar 
Date:   Wed Mar 16 20:06:33 2022 +

 of/platform: Drop static setup of IRQ resource from DT core

 Now that all the DT drivers have switched to platform_get_irq() we 
can now
 safely drop the static setup of IRQ resource from DT core code.

 With the above change hierarchical setup of irq domains is no longer
 bypassed and thus allowing hierarchical interrupt domains to describe
 interrupts using "interrupts" DT property.

 Signed-off-by: Lad Prabhakar 
 Acked-by: Marc Zyngier 
 Tested-by: Marc Zyngier 
 Signed-off-by: Rob Herring 
 Link: 
https://lore.kernel.org/r/20220316200633.28974-1-prabhakar.mahadev-lad...@bp.renesas.com



Can you please provide you device tree ?

Do you use any out-of-tree drivers ?

Thanks
Christophe