RE: [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape

[Raghav Dogra]

Scott uses the updated email id <o...@buserror.net> and is already added.

Regards,
Raghav 

> -Original Message-
> From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org]
> Sent: Monday, July 04, 2016 3:19 PM
> To: Boris Brezillon <boris.brezil...@free-electrons.com>; Raghav Dogra
> <raghav.do...@nxp.com>; Paul Mackerras <pau...@samba.org>; Michael
> Ellerman <m...@ellerman.id.au>; Scott Wood <scottw...@freescale.com>
> Cc: linux-...@lists.infradead.org; Prabhakar Kushwaha
> <prabhakar.kushw...@nxp.com>; Yang-Leo Li <leoyang...@nxp.com>;
> o...@buserror.net; computersforpe...@gmail.com; linuxppc-
> d...@lists.ozlabs.org
> Subject: Re: [PATCH][v2] driver/memory: Update dependency of IFC for
> Layerscape
> 
> On Mon, 2016-07-04 at 11:29 +0200, Boris Brezillon wrote:
> > +PPC maintainers.
> 
> + Scott for FSL stuff
> 
> > Hi Raghav,
> >
> > Since you're touching powerpc drivers, the least you could do is add
> > ppc maintainers in Cc, so that they can ack/review your patch...
> >
> > On Fri, 1 Jul 2016 21:32:30 +0530
> > Raghav Dogra <raghav.do...@nxp.com> wrote:
> >
> > > This patch enables IFC NAND support on ARM layerscape platform.
> > > It fixes the dependency to enable NAND. The include files are being
> > > modified to ensure complilation for both PowerPC and ARM
> > > architectures.
> >
> > Still think this could be separated in 2 commits:
> > - the first one getting rid of the asm/prom.h inclusion
> > - the second one changing the Kconfig dependency
> >
> > >
> > > Signed-off-by: Raghav Dogra <raghav.do...@nxp.com>
> > > ---
> > > Applicable to git://git.infradead.org/l2-mtd.git
> > >
> > > Changes for v2: updated commit description
> > >
> > >  drivers/memory/Kconfig   | 2 +-
> > >  drivers/memory/fsl_ifc.c | 4 +++-
> > >  drivers/mtd/nand/Kconfig | 2 +-
> > >  3 files changed, 5 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig index
> > > 81ddb17..5645705 100644
> > > --- a/drivers/memory/Kconfig
> > > +++ b/drivers/memory/Kconfig
> > > @@ -104,7 +104,7 @@ config FSL_CORENET_CF
> > >
> > >  config FSL_IFC
> > >   bool
> > > - depends on FSL_SOC
> > > + depends on FSL_SOC || ARCH_LAYERSCAPE
> > >
> > >  config JZ4780_NEMC
> > >   bool "Ingenic JZ4780 SoC NEMC driver"
> > > diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c
> > > index 904b4af..1b182b1 100644
> > > --- a/drivers/memory/fsl_ifc.c
> > > +++ b/drivers/memory/fsl_ifc.c
> > > @@ -31,7 +31,9 @@
> > >  #include 
> > >  #include 
> > >  #include 
> > > -#include 
> > > +#include 
> > > +#include 
> > > +#include 
> > >
> > >  struct fsl_ifc_ctrl *fsl_ifc_ctrl_dev;
> > >  EXPORT_SYMBOL(fsl_ifc_ctrl_dev);
> > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> > > index f05e0e9..eace3ef 100644
> > > --- a/drivers/mtd/nand/Kconfig
> > > +++ b/drivers/mtd/nand/Kconfig
> > > @@ -438,7 +438,7 @@ config MTD_NAND_FSL_ELBC
> > >
> > >  config MTD_NAND_FSL_IFC
> > >   tristate "NAND support for Freescale IFC controller"
> > > - depends on MTD_NAND && FSL_SOC
> > > + depends on MTD_NAND && (FSL_SOC || ARCH_LAYERSCAPE)
> > >   select FSL_IFC
> > >   select MEMORY
> > >   help
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape

[Benjamin Herrenschmidt]

On Mon, 2016-07-04 at 11:29 +0200, Boris Brezillon wrote:
> +PPC maintainers.

+ Scott for FSL stuff

> Hi Raghav,
>
> Since you're touching powerpc drivers, the least you could do is add
> ppc maintainers in Cc, so that they can ack/review your patch...
> 
> On Fri, 1 Jul 2016 21:32:30 +0530
> Raghav Dogra  wrote:
> 
> > This patch enables IFC NAND support on ARM layerscape platform.
> > It fixes the dependency to enable NAND. The include files are being
> > modified
> > to ensure complilation for both PowerPC and ARM architectures.
> 
> Still think this could be separated in 2 commits:
> - the first one getting rid of the asm/prom.h inclusion
> - the second one changing the Kconfig dependency
> 
> > 
> > Signed-off-by: Raghav Dogra 
> > ---
> > Applicable to git://git.infradead.org/l2-mtd.git
> > 
> > Changes for v2: updated commit description
> > 
> >  drivers/memory/Kconfig   | 2 +-
> >  drivers/memory/fsl_ifc.c | 4 +++-
> >  drivers/mtd/nand/Kconfig | 2 +-
> >  3 files changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> > index 81ddb17..5645705 100644
> > --- a/drivers/memory/Kconfig
> > +++ b/drivers/memory/Kconfig
> > @@ -104,7 +104,7 @@ config FSL_CORENET_CF
> >  
> >  config FSL_IFC
> >     bool
> > -   depends on FSL_SOC
> > +   depends on FSL_SOC || ARCH_LAYERSCAPE
> >  
> >  config JZ4780_NEMC
> >     bool "Ingenic JZ4780 SoC NEMC driver"
> > diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c
> > index 904b4af..1b182b1 100644
> > --- a/drivers/memory/fsl_ifc.c
> > +++ b/drivers/memory/fsl_ifc.c
> > @@ -31,7 +31,9 @@
> >  #include 
> >  #include 
> >  #include 
> > -#include 
> > +#include 
> > +#include 
> > +#include 
> >  
> >  struct fsl_ifc_ctrl *fsl_ifc_ctrl_dev;
> >  EXPORT_SYMBOL(fsl_ifc_ctrl_dev);
> > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> > index f05e0e9..eace3ef 100644
> > --- a/drivers/mtd/nand/Kconfig
> > +++ b/drivers/mtd/nand/Kconfig
> > @@ -438,7 +438,7 @@ config MTD_NAND_FSL_ELBC
> >  
> >  config MTD_NAND_FSL_IFC
> >     tristate "NAND support for Freescale IFC controller"
> > -   depends on MTD_NAND && FSL_SOC
> > +   depends on MTD_NAND && (FSL_SOC || ARCH_LAYERSCAPE)
> >     select FSL_IFC
> >     select MEMORY
> >     help
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH][v2] driver/memory: Update dependency of IFC for Layerscape

[Boris Brezillon]

+PPC maintainers.

Hi Raghav,

Since you're touching powerpc drivers, the least you could do is add
ppc maintainers in Cc, so that they can ack/review your patch...

On Fri, 1 Jul 2016 21:32:30 +0530
Raghav Dogra  wrote:

> This patch enables IFC NAND support on ARM layerscape platform.
> It fixes the dependency to enable NAND. The include files are being modified
> to ensure complilation for both PowerPC and ARM architectures.

Still think this could be separated in 2 commits:
- the first one getting rid of the asm/prom.h inclusion
- the second one changing the Kconfig dependency

> 
> Signed-off-by: Raghav Dogra 
> ---
> Applicable to git://git.infradead.org/l2-mtd.git
> 
> Changes for v2: updated commit description
> 
>  drivers/memory/Kconfig   | 2 +-
>  drivers/memory/fsl_ifc.c | 4 +++-
>  drivers/mtd/nand/Kconfig | 2 +-
>  3 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index 81ddb17..5645705 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -104,7 +104,7 @@ config FSL_CORENET_CF
>  
>  config FSL_IFC
>   bool
> - depends on FSL_SOC
> + depends on FSL_SOC || ARCH_LAYERSCAPE
>  
>  config JZ4780_NEMC
>   bool "Ingenic JZ4780 SoC NEMC driver"
> diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c
> index 904b4af..1b182b1 100644
> --- a/drivers/memory/fsl_ifc.c
> +++ b/drivers/memory/fsl_ifc.c
> @@ -31,7 +31,9 @@
>  #include 
>  #include 
>  #include 
> -#include 
> +#include 
> +#include 
> +#include 
>  
>  struct fsl_ifc_ctrl *fsl_ifc_ctrl_dev;
>  EXPORT_SYMBOL(fsl_ifc_ctrl_dev);
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index f05e0e9..eace3ef 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -438,7 +438,7 @@ config MTD_NAND_FSL_ELBC
>  
>  config MTD_NAND_FSL_IFC
>   tristate "NAND support for Freescale IFC controller"
> - depends on MTD_NAND && FSL_SOC
> + depends on MTD_NAND && (FSL_SOC || ARCH_LAYERSCAPE)
>   select FSL_IFC
>   select MEMORY
>   help

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev