Re: [PATCH] Disable PowerMac cpufreq on SMP kernels

2009-08-13 Thread Benjamin Herrenschmidt
On Tue, 2009-08-11 at 11:39 +0200, Bastian Blank wrote:
 The build of a PowerMac 32bit kernel currently fails with
 
 error: #warning WARNING, CPUFREQ not recommended on SMP kernels
 
 This patch just disables this driver on SMP kernels, as it is obviously
 not supported.
 
 Signed-off-by: Bastian Blank wa...@debian.org

Why not remove the #error instead ? :-) I don't think it's still
meaningful, especially since we use the timebase for delays nowadays
which doesn't depend on the CPU frequency...

Ben.

 diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
 index 04a8061..99d3564 100644
 --- a/arch/powerpc/platforms/Kconfig
 +++ b/arch/powerpc/platforms/Kconfig
 @@ -149,7 +149,7 @@ menu CPU Frequency drivers
  
  config CPU_FREQ_PMAC
   bool Support for Apple PowerBooks
 - depends on ADB_PMU  PPC32
 + depends on ADB_PMU  PPC32  !SMP
   select CPU_FREQ_TABLE
   help
 This adds support for frequency switching on Apple PowerBooks,
 --
 To unsubscribe from this list: send the line unsubscribe linux-kernel in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 Please read the FAQ at  http://www.tux.org/lkml/

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


[PATCH] Disable PowerMac cpufreq on SMP kernels

2009-08-11 Thread Bastian Blank
The build of a PowerMac 32bit kernel currently fails with

error: #warning WARNING, CPUFREQ not recommended on SMP kernels

This patch just disables this driver on SMP kernels, as it is obviously
not supported.

Signed-off-by: Bastian Blank wa...@debian.org

diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
index 04a8061..99d3564 100644
--- a/arch/powerpc/platforms/Kconfig
+++ b/arch/powerpc/platforms/Kconfig
@@ -149,7 +149,7 @@ menu CPU Frequency drivers
 
 config CPU_FREQ_PMAC
bool Support for Apple PowerBooks
-   depends on ADB_PMU  PPC32
+   depends on ADB_PMU  PPC32  !SMP
select CPU_FREQ_TABLE
help
  This adds support for frequency switching on Apple PowerBooks,
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev