Re: [PATCH] Remove 'type' argument from access_ok() function
On Fri, Jan 4, 2019 at 1:28 AM Mathieu Malaterre wrote:
>
> Revert commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with
> access_ok()") to fix the following compilation error:
Gaah. I even *looked* at the powerpc use of 'type', but then when I
was actually going through my manual editing I forgot all about it.
So this wasn't a case of "the powerpc change was recent and clashed".
This was purely a case of "Linus screwed up".
Sorry.
Linus
Re: [PATCH] Remove 'type' argument from access_ok() function
Mathieu Malaterre a écrit :
In commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with
access_ok()") an attempt was made to remove a warning by referencing the
variable `type`, however in commit 96d4f267e40f ("Remove 'type' argument
from access_ok() function") the variable `type` has been removed.
Revert commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with
access_ok()") to fix the following compilation error:
arch/powerpc/include/asm/uaccess.h:66:32: error: ‘type’ undeclared
(first use in this function)
Signed-off-by: Mathieu Malaterre
Should you add a Fixes: 96d4f267e40f ?
Note that sparc arch will have the same issue.
Christophe
---
arch/powerpc/include/asm/uaccess.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/uaccess.h
b/arch/powerpc/include/asm/uaccess.h
index b31bf45eebd4..5f0c98e511a0 100644
--- a/arch/powerpc/include/asm/uaccess.h
+++ b/arch/powerpc/include/asm/uaccess.h
@@ -63,7 +63,7 @@ static inline int __access_ok(unsigned long addr,
unsigned long size,
#endif
#define access_ok(addr, size) \
- (__chk_user_ptr(addr), (void)(type),\
+ (__chk_user_ptr(addr), \
__access_ok((__force unsigned long)(addr), (size), get_fs()))
/*
--
2.19.2
[PATCH] Remove 'type' argument from access_ok() function
In commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with
access_ok()") an attempt was made to remove a warning by referencing the
variable `type`, however in commit 96d4f267e40f ("Remove 'type' argument
from access_ok() function") the variable `type` has been removed.
Revert commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with
access_ok()") to fix the following compilation error:
arch/powerpc/include/asm/uaccess.h:66:32: error: ‘type’ undeclared (first use
in this function)
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/include/asm/uaccess.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/uaccess.h
b/arch/powerpc/include/asm/uaccess.h
index b31bf45eebd4..5f0c98e511a0 100644
--- a/arch/powerpc/include/asm/uaccess.h
+++ b/arch/powerpc/include/asm/uaccess.h
@@ -63,7 +63,7 @@ static inline int __access_ok(unsigned long addr, unsigned
long size,
#endif
#define access_ok(addr, size) \
- (__chk_user_ptr(addr), (void)(type),\
+ (__chk_user_ptr(addr), \
__access_ok((__force unsigned long)(addr), (size), get_fs()))
/*
--
2.19.2
