Re: [PATCH] create modalias file in sysfs for bus vio

2008-02-03 Thread Stephen Rothwell 
Hi Olaf,

[Sorry, been on vacation]

On Fri, 25 Jan 2008 18:09:14 +0100 Olaf Hering [EMAIL PROTECTED] wrote:

 On Wed, Jan 23, Stephen Rothwell wrote:
 
  It would be nice if we could factor out the vio:T%sS%s string as it is
  also used in vio_hotplug().
 
 What exactly do you have in mind?
 Creating a tempstring seems to make things more complicated.

Yeah, but it would be nice if the format only had to be known/changed in
one place.  Don't worry about it for now. Or maybe create a static const
char [] or #define with the string.

-- 
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/


pgpJH6yfua8NK.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] create modalias file in sysfs for bus vio

2008-01-25 Thread Olaf Hering 
On Wed, Jan 23, Stephen Rothwell wrote:

 It would be nice if we could factor out the vio:T%sS%s string as it is
 also used in vio_hotplug().

What exactly do you have in mind?
Creating a tempstring seems to make things more complicated.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] create modalias file in sysfs for bus vio

2008-01-22 Thread Olaf Hering 

Create /sys/bus/vio/devices/*/modalias file to allow autoloading
of modules. modalias files are already present for many other bus types.

Signed-off-by: Olaf Hering [EMAIL PROTECTED]
---
 arch/powerpc/kernel/vio.c |   15 +++
 1 file changed, 15 insertions(+)

--- a/arch/powerpc/kernel/vio.c
+++ b/arch/powerpc/kernel/vio.c
@@ -296,9 +296,24 @@ static ssize_t devspec_show(struct devic
return sprintf(buf, %s\n, of_node ? of_node-full_name : none);
 }
 
+static ssize_t modalias_show (struct device *dev, struct device_attribute 
*attr,
+ char *buf)
+{
+   struct device_node *of_node = dev-archdata.of_node;
+   const char *compat;
+   int i = 0;
+
+   if (of_node) {
+   compat = of_get_property(of_node, compatible, i);
+   i = sprintf (buf, vio:T%sS%s\n, of_node-type, compat ? 
compat : );
+   }
+   return i;
+}
+
 static struct device_attribute vio_dev_attrs[] = {
__ATTR_RO(name),
__ATTR_RO(devspec),
+   __ATTR_RO(modalias),
__ATTR_NULL
 };
 
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] create modalias file in sysfs for bus vio

2008-01-22 Thread Stephen Rothwell 
Hi Olaf,

Thanks for this.  Just a couple of nits ...

On Tue, 22 Jan 2008 09:33:28 +0100 Olaf Hering [EMAIL PROTECTED] wrote:

 +static ssize_t modalias_show (struct device *dev, struct device_attribute 
 *attr,
   ^
No space here, please.

 +   char *buf)
 +{
 + struct device_node *of_node = dev-archdata.of_node;
 + const char *compat;
 + int i = 0;
 +
 + if (of_node) {
 + compat = of_get_property(of_node, compatible, i);
 + i = sprintf (buf, vio:T%sS%s\n, of_node-type, compat ? 
 compat : );
   ^
Or here.

It would be nice if we could factor out the vio:T%sS%s string as it is
also used in vio_hotplug().

-- 
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/


pgprDCya7ul3L.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev