Re: [PATCH] cxl: Test the correct mmio space before unmapping

2015-07-02 Thread Michael Neuling 
On Fri, 2015-07-03 at 10:23 +1000, Michael Neuling wrote:
> On Thu, 2015-07-02 at 15:55 +1000, Daniel Axtens wrote:
> > Before freeing p2n, test p2n, not p1n.
> > 
> > Signed-off-by: Daniel Axtens 
> 
> Nice catch but can you resend with a CC stable?

Actually stable is overkill, but this is a bug should to go in 4.2 as a
bug fix.

Mikey

> 
> Mikey
> 
> > 
> > ---
> > 
> > While a potentially nasty bug, this is only hit (at the moment)
> > in cxl_remove, so it's probably not a candidate for stable.
> > ---
> >  drivers/misc/cxl/pci.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> > index a16988d..fd43462 100644
> > --- a/drivers/misc/cxl/pci.c
> > +++ b/drivers/misc/cxl/pci.c
> > @@ -540,7 +540,7 @@ err:
> >  
> >  static void cxl_unmap_slice_regs(struct cxl_afu *afu)
> >  {
> > -   if (afu->p1n_mmio)
> > +   if (afu->p2n_mmio)
> > iounmap(afu->p2n_mmio);
> > if (afu->p1n_mmio)
> > iounmap(afu->p1n_mmio);
> 

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] cxl: Test the correct mmio space before unmapping

2015-07-02 Thread Michael Neuling 
On Thu, 2015-07-02 at 15:55 +1000, Daniel Axtens wrote:
> Before freeing p2n, test p2n, not p1n.
> 
> Signed-off-by: Daniel Axtens 

Nice catch but can you resend with a CC stable?

Mikey

> 
> ---
> 
> While a potentially nasty bug, this is only hit (at the moment)
> in cxl_remove, so it's probably not a candidate for stable.
> ---
>  drivers/misc/cxl/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
> index a16988d..fd43462 100644
> --- a/drivers/misc/cxl/pci.c
> +++ b/drivers/misc/cxl/pci.c
> @@ -540,7 +540,7 @@ err:
>  
>  static void cxl_unmap_slice_regs(struct cxl_afu *afu)
>  {
> - if (afu->p1n_mmio)
> + if (afu->p2n_mmio)
>   iounmap(afu->p2n_mmio);
>   if (afu->p1n_mmio)
>   iounmap(afu->p1n_mmio);

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] cxl: Test the correct mmio space before unmapping

2015-07-01 Thread Ian Munsie 
Acked-by: Ian Munsie 

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] cxl: Test the correct mmio space before unmapping

2015-07-01 Thread Daniel Axtens 
Before freeing p2n, test p2n, not p1n.

Signed-off-by: Daniel Axtens 

---

While a potentially nasty bug, this is only hit (at the moment)
in cxl_remove, so it's probably not a candidate for stable.
---
 drivers/misc/cxl/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c
index a16988d..fd43462 100644
--- a/drivers/misc/cxl/pci.c
+++ b/drivers/misc/cxl/pci.c
@@ -540,7 +540,7 @@ err:
 
 static void cxl_unmap_slice_regs(struct cxl_afu *afu)
 {
-   if (afu->p1n_mmio)
+   if (afu->p2n_mmio)
iounmap(afu->p2n_mmio);
if (afu->p1n_mmio)
iounmap(afu->p1n_mmio);
-- 
2.1.4

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev