Re: [PATCH] lib: fix build failure in CONFIG_DEBUG_VIRTUAL test
Christophe Leroy writes: > On several arches, virt_to_phys() is in io.h > > Build fails without it: > > CC lib/test_debug_virtual.o > lib/test_debug_virtual.c: In function 'test_debug_virtual_init': > lib/test_debug_virtual.c:26:7: error: implicit declaration of function > 'virt_to_phys' [-Werror=implicit-function-declaration] > pa = virt_to_phys(va); >^ > > Fixes: e4dace361552 ("lib: add test module for CONFIG_DEBUG_VIRTUAL") > CC: sta...@vger.kernel.org > Signed-off-by: Christophe Leroy > --- > lib/test_debug_virtual.c | 1 + > 1 file changed, 1 insertion(+) I'm going to take this via the powerpc tree, because otherwise Christophe's patch to implement CONFIG_DEBUG_VIRTUAL for powerpc will break the build for us. Hopefully no one minds :) cheers
Re: [PATCH] lib: fix build failure in CONFIG_DEBUG_VIRTUAL test
On Mon, Dec 10, 2018 at 12:08 AM Christophe Leroy wrote: > > On several arches, virt_to_phys() is in io.h > > Build fails without it: > > CC lib/test_debug_virtual.o > lib/test_debug_virtual.c: In function 'test_debug_virtual_init': > lib/test_debug_virtual.c:26:7: error: implicit declaration of function > 'virt_to_phys' [-Werror=implicit-function-declaration] > pa = virt_to_phys(va); >^ > > Fixes: e4dace361552 ("lib: add test module for CONFIG_DEBUG_VIRTUAL") > CC: sta...@vger.kernel.org > Signed-off-by: Christophe Leroy Reviewed-by: Kees Cook -Kees > --- > lib/test_debug_virtual.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/test_debug_virtual.c b/lib/test_debug_virtual.c > index d5a06addeb27..bf864c73e462 100644 > --- a/lib/test_debug_virtual.c > +++ b/lib/test_debug_virtual.c > @@ -5,6 +5,7 @@ > #include > #include > #include > +#include > > #include > #ifdef CONFIG_MIPS > -- > 2.13.3 > -- Kees Cook
[PATCH] lib: fix build failure in CONFIG_DEBUG_VIRTUAL test
On several arches, virt_to_phys() is in io.h Build fails without it: CC lib/test_debug_virtual.o lib/test_debug_virtual.c: In function 'test_debug_virtual_init': lib/test_debug_virtual.c:26:7: error: implicit declaration of function 'virt_to_phys' [-Werror=implicit-function-declaration] pa = virt_to_phys(va); ^ Fixes: e4dace361552 ("lib: add test module for CONFIG_DEBUG_VIRTUAL") CC: sta...@vger.kernel.org Signed-off-by: Christophe Leroy --- lib/test_debug_virtual.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/test_debug_virtual.c b/lib/test_debug_virtual.c index d5a06addeb27..bf864c73e462 100644 --- a/lib/test_debug_virtual.c +++ b/lib/test_debug_virtual.c @@ -5,6 +5,7 @@ #include #include #include +#include #include #ifdef CONFIG_MIPS -- 2.13.3