Re: [PATCH] powerpc/44x: Add hwmon support to Sequoia device tree
On Monday 08 September 2008 18:03, Scott Wood wrote: On Sat, Sep 06, 2008 at 05:07:15PM +0200, Wolfgang Grandegger wrote: How about dtt? That's what we use in U-Boot for digital temperature sensors as well. I vote against any acronyms that are not very well known. Even knowing that it's supposed to be digital temperature something, I can't figure out what the something is. Not having the context that it relates to temperature, I wouldn't have a clue what dtt is. hwmon is concise and fairly obvious, and unlike temp could be meaningfully used with chips that also monitor voltages, fan speeds, etc. -Scott Uh, thanks Scott. Now we got it. I am fully with you and my V2 patch should make everybody happy. So, let's apply this patch. Matthias ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc/44x: Add hwmon support to Sequoia device tree
On Tue, Sep 09, 2008 at 01:52:29PM +0200, Matthias Fuchs wrote: On Monday 08 September 2008 18:03, Scott Wood wrote: On Sat, Sep 06, 2008 at 05:07:15PM +0200, Wolfgang Grandegger wrote: How about dtt? That's what we use in U-Boot for digital temperature sensors as well. I vote against any acronyms that are not very well known. Even knowing that it's supposed to be digital temperature something, I can't figure out what the something is. Not having the context that it relates to temperature, I wouldn't have a clue what dtt is. hwmon is concise and fairly obvious, and unlike temp could be meaningfully used with chips that also monitor voltages, fan speeds, etc. -Scott Uh, thanks Scott. Now we got it. I am fully with you and my V2 patch should make everybody happy. So, let's apply this patch. I already have it queued up. josh ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc/44x: Add hwmon support to Sequoia device tree
On Sat, Sep 06, 2008 at 05:07:15PM +0200, Wolfgang Grandegger wrote: How about dtt? That's what we use in U-Boot for digital temperature sensors as well. I vote against any acronyms that are not very well known. Even knowing that it's supposed to be digital temperature something, I can't figure out what the something is. Not having the context that it relates to temperature, I wouldn't have a clue what dtt is. hwmon is concise and fairly obvious, and unlike temp could be meaningfully used with chips that also monitor voltages, fan speeds, etc. -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc/44x: Add hwmon support to Sequoia device tree
On Fri, Sep 05, 2008 at 08:17:03PM -0400, Sean MacLennan wrote:
On Fri, 5 Sep 2008 11:00:18 -0500
Scott Wood [EMAIL PROTECTED] wrote:
On Fri, Sep 05, 2008 at 12:19:43PM +0200, Stefan Roese wrote:
+
+[EMAIL PROTECTED] {
Not sure if we shouldn't use
[EMAIL PROTECTED] {
here. This is the way it is already done in warp.dts.
We shouldn't. Node names are supposed to be generic:
http://playground.sun.com/1275/practice/gnames/gnamv14a.html
Damn. Where were you a year ago when I first introduced this? ;)
And if it is really supposed to be generic, would [EMAIL PROTECTED] be a
better name since this is basically a generic temperature chip?
Now that the i2c driver is a full of platform driver, I think I
can change the name with no repercussions. So I can live with whatever
decision is made. Can't do anything about the systems that are out in
the field though
It's just the unit-name that should be generic, not the compatible. The
only thing unit-name is used for is path lookup and distinguishing between
similar hardware units. I don't think either is a problem in this case.
josh
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc/44x: Add hwmon support to Sequoia device tree
Hi,
I have chosen hwmon because those drivers are placed in the kernel's
drivers/hwmon subdirectory. temp sounds to much like temporary for
me :-)
We can name it sensor - inspired by the lm-sensors projects that
takes care of such sensors. Because these type of devices are not always
used to monitor the whatever hardware ... sensor could even be better.
So my favorites are sensor@ or [EMAIL PROTECTED]
Sean, I can take your adi instead of analog for this special sensor.
Matthias
On Saturday 06 September 2008 02:17:03 Sean MacLennan wrote:
On Fri, 5 Sep 2008 11:00:18 -0500
Scott Wood [EMAIL PROTECTED] wrote:
On Fri, Sep 05, 2008 at 12:19:43PM +0200, Stefan Roese wrote:
+
+ [EMAIL PROTECTED] {
Not sure if we shouldn't use
[EMAIL PROTECTED] {
here. This is the way it is already done in warp.dts.
We shouldn't. Node names are supposed to be generic:
http://playground.sun.com/1275/practice/gnames/gnamv14a.html
Damn. Where were you a year ago when I first introduced this? ;)
And if it is really supposed to be generic, would [EMAIL PROTECTED] be a
better name since this is basically a generic temperature chip?
Now that the i2c driver is a full of platform driver, I think I
can change the name with no repercussions. So I can live with whatever
decision is made. Can't do anything about the systems that are out in
the field though
Cheers,
Sean
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc/44x: Add hwmon support to Sequoia device tree
On Sat, 6 Sep 2008 14:40:41 +0200 Matthias Fuchs [EMAIL PROTECTED] wrote: Sean, I can take your adi instead of analog for this special sensor. I think I was told to use adi because it is the stock market symbol for analog devices. Cheers, Sean ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc/44x: Add hwmon support to Sequoia device tree
Matthias Fuchs wrote: Hi, I have chosen hwmon because those drivers are placed in the kernel's drivers/hwmon subdirectory. temp sounds to much like temporary for me :-) How about dtt? That's what we use in U-Boot for digital temperature sensors as well. We can name it sensor - inspired by the lm-sensors projects that takes care of such sensors. Because these type of devices are not always used to monitor the whatever hardware ... sensor could even be better. So my favorites are sensor@ or [EMAIL PROTECTED] Sean, I can take your adi instead of analog for this special sensor. adi sounds more reasonable, indeed and as the OF software ignores the vendor field, changing the name should not harm. Wolfgang. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc/44x: Add hwmon support to Sequoia device tree
On Thursday 04 September 2008, Matthias Fuchs wrote:
This patch adds support for the AD7414 temperature sensor
on Sequoia PPC440EPx board.
Signed-off-by: Matthias Fuchs [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/sequoia.dts |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/boot/dts/sequoia.dts
b/arch/powerpc/boot/dts/sequoia.dts index 72d15f0..9ba5def 100644
--- a/arch/powerpc/boot/dts/sequoia.dts
+++ b/arch/powerpc/boot/dts/sequoia.dts
@@ -246,13 +246,22 @@
};
IIC0: [EMAIL PROTECTED] {
+ #address-cells = 1;
+ #size-cells = 0;
compatible = ibm,iic-440epx, ibm,iic;
reg = 0xef600700 0x0014;
interrupt-parent = UIC0;
interrupts = 0x2 0x4;
+
+ [EMAIL PROTECTED] {
Not sure if we shouldn't use
[EMAIL PROTECTED] {
here. This is the way it is already done in warp.dts.
Other than this:
Acked-by: Stefan Roese [EMAIL PROTECTED]
Best regards,
Stefan
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc/44x: Add hwmon support to Sequoia device tree
Hi,
I was inspired by some I2C RTC node (tqm5200.dts). Those nodes
are named [EMAIL PROTECTED] But to be in common I can change it. Also
the vendor is differnet in warp's dts file. adi (analog device inc.) against
analog.
So I will update my patch to be compatible with warp.dts.
I keep your ack, Stefan.
Matthias
On Friday 05 September 2008 12:19, Stefan Roese wrote:
diff --git a/arch/powerpc/boot/dts/sequoia.dts
b/arch/powerpc/boot/dts/sequoia.dts index 72d15f0..9ba5def 100644
--- a/arch/powerpc/boot/dts/sequoia.dts
+++ b/arch/powerpc/boot/dts/sequoia.dts
@@ -246,13 +246,22 @@
};
IIC0: [EMAIL PROTECTED] {
+ #address-cells = 1;
+ #size-cells = 0;
compatible = ibm,iic-440epx, ibm,iic;
reg = 0xef600700 0x0014;
interrupt-parent = UIC0;
interrupts = 0x2 0x4;
+
+ [EMAIL PROTECTED] {
Not sure if we shouldn't use
[EMAIL PROTECTED] {
here. This is the way it is already done in warp.dts.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc/44x: Add hwmon support to Sequoia device tree
On Fri, Sep 05, 2008 at 12:19:43PM +0200, Stefan Roese wrote:
+
+ [EMAIL PROTECTED] {
Not sure if we shouldn't use
[EMAIL PROTECTED] {
here. This is the way it is already done in warp.dts.
We shouldn't. Node names are supposed to be generic:
http://playground.sun.com/1275/practice/gnames/gnamv14a.html
-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc/44x: Add hwmon support to Sequoia device tree
On Fri, 5 Sep 2008 11:00:18 -0500
Scott Wood [EMAIL PROTECTED] wrote:
On Fri, Sep 05, 2008 at 12:19:43PM +0200, Stefan Roese wrote:
+
+ [EMAIL PROTECTED] {
Not sure if we shouldn't use
[EMAIL PROTECTED] {
here. This is the way it is already done in warp.dts.
We shouldn't. Node names are supposed to be generic:
http://playground.sun.com/1275/practice/gnames/gnamv14a.html
Damn. Where were you a year ago when I first introduced this? ;)
And if it is really supposed to be generic, would [EMAIL PROTECTED] be a
better name since this is basically a generic temperature chip?
Now that the i2c driver is a full of platform driver, I think I
can change the name with no repercussions. So I can live with whatever
decision is made. Can't do anything about the systems that are out in
the field though
Cheers,
Sean
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH] powerpc/44x: Add hwmon support to Sequoia device tree
This patch adds support for the AD7414 temperature sensor
on Sequoia PPC440EPx board.
Signed-off-by: Matthias Fuchs [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/sequoia.dts |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/boot/dts/sequoia.dts
b/arch/powerpc/boot/dts/sequoia.dts
index 72d15f0..9ba5def 100644
--- a/arch/powerpc/boot/dts/sequoia.dts
+++ b/arch/powerpc/boot/dts/sequoia.dts
@@ -246,13 +246,22 @@
};
IIC0: [EMAIL PROTECTED] {
+ #address-cells = 1;
+ #size-cells = 0;
compatible = ibm,iic-440epx, ibm,iic;
reg = 0xef600700 0x0014;
interrupt-parent = UIC0;
interrupts = 0x2 0x4;
+
+ [EMAIL PROTECTED] {
+ compatible = analog,ad7414;
+ reg = 0x48;
+ };
};
IIC1: [EMAIL PROTECTED] {
+ #address-cells = 1;
+ #size-cells = 0;
compatible = ibm,iic-440epx, ibm,iic;
reg = 0xef600800 0x0014;
interrupt-parent = UIC0;
--
1.5.3
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
