Re: [PATCH] powerpc/5200: remove sysfs debug file from GPT driver

[Wolfram Sang]

On Fri, Mar 06, 2009 at 01:31:41PM -0700, Grant Likely wrote:
> Wolfram, you were right.  This was a bad idea.  I just took me a bit
> longer to clue into it.

Instant ACK :D Thanks!

Acked-by: Wolfram Sang 

-- 
Pengutronix e.K.   | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/  |


signature.asc
Description: Digital signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc/5200: remove sysfs debug file from GPT driver

[Grant Likely]

Wolfram, you were right.  This was a bad idea.  I just took me a bit
longer to clue into it.

g.

On Fri, Mar 6, 2009 at 1:30 PM, Grant Likely  wrote:
> From: Grant Likely 
>
> Remove poorly designed debug sysfs attribute entry from the GPT driver.
>
> Signed-off-by: Grant Likely 
> ---
>
>  arch/powerpc/platforms/52xx/mpc52xx_gpt.c |   39 
> -
>  1 files changed, 0 insertions(+), 39 deletions(-)
>
>
> diff --git a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c 
> b/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
> index cb038dc..bfbcd41 100644
> --- a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
> +++ b/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
> @@ -335,44 +335,6 @@ static void
>  mpc52xx_gpt_gpio_setup(struct mpc52xx_gpt_priv *p, struct device_node *np) { 
> }
>  #endif /* defined(CONFIG_GPIOLIB) */
>
> -/***
> - * SYSFS attributes
> - */
> -#if defined(CONFIG_SYSFS)
> -static ssize_t mpc52xx_gpt_show_regs(struct device *dev,
> -                                    struct device_attribute *attr, char *buf)
> -{
> -       struct mpc52xx_gpt_priv *gpt = dev_get_drvdata(dev);
> -       int i, len = 0;
> -       u32 __iomem *regs = (void __iomem *) gpt->regs;
> -
> -       for (i = 0; i < 4; i++)
> -               len += sprintf(buf + len, "%.8x ", in_be32(regs + i));
> -       len += sprintf(buf + len, "\n");
> -
> -       return len;
> -}
> -
> -static struct device_attribute mpc52xx_gpt_attrib[] = {
> -       __ATTR(regs, S_IRUGO | S_IWUSR, mpc52xx_gpt_show_regs, NULL),
> -};
> -
> -static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *gpt)
> -{
> -       int i, err = 0;
> -
> -       for (i = 0; i < ARRAY_SIZE(mpc52xx_gpt_attrib); i++) {
> -               err = device_create_file(gpt->dev, &mpc52xx_gpt_attrib[i]);
> -               if (err)
> -                       dev_err(gpt->dev, "error creating attribute %i\n", i);
> -       }
> -
> -}
> -
> -#else /* defined(CONFIG_SYSFS) */
> -static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *) { return 
> 0; }
> -#endif /* defined(CONFIG_SYSFS) */
> -
>  /* -
>  * of_platform bus binding code
>  */
> @@ -395,7 +357,6 @@ static int __devinit mpc52xx_gpt_probe(struct of_device 
> *ofdev,
>
>        dev_set_drvdata(&ofdev->dev, gpt);
>
> -       mpc52xx_gpt_create_attribs(gpt);
>        mpc52xx_gpt_gpio_setup(gpt, ofdev->node);
>        mpc52xx_gpt_irq_setup(gpt, ofdev->node);
>
>
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] powerpc/5200: remove sysfs debug file from GPT driver

[Grant Likely]

From: Grant Likely 

Remove poorly designed debug sysfs attribute entry from the GPT driver.

Signed-off-by: Grant Likely 
---

 arch/powerpc/platforms/52xx/mpc52xx_gpt.c |   39 -
 1 files changed, 0 insertions(+), 39 deletions(-)


diff --git a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c 
b/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
index cb038dc..bfbcd41 100644
--- a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
+++ b/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
@@ -335,44 +335,6 @@ static void
 mpc52xx_gpt_gpio_setup(struct mpc52xx_gpt_priv *p, struct device_node *np) { }
 #endif /* defined(CONFIG_GPIOLIB) */
 
-/***
- * SYSFS attributes
- */
-#if defined(CONFIG_SYSFS)
-static ssize_t mpc52xx_gpt_show_regs(struct device *dev,
-struct device_attribute *attr, char *buf)
-{
-   struct mpc52xx_gpt_priv *gpt = dev_get_drvdata(dev);
-   int i, len = 0;
-   u32 __iomem *regs = (void __iomem *) gpt->regs;
-
-   for (i = 0; i < 4; i++)
-   len += sprintf(buf + len, "%.8x ", in_be32(regs + i));
-   len += sprintf(buf + len, "\n");
-
-   return len;
-}
-
-static struct device_attribute mpc52xx_gpt_attrib[] = {
-   __ATTR(regs, S_IRUGO | S_IWUSR, mpc52xx_gpt_show_regs, NULL),
-};
-
-static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *gpt)
-{
-   int i, err = 0;
-
-   for (i = 0; i < ARRAY_SIZE(mpc52xx_gpt_attrib); i++) {
-   err = device_create_file(gpt->dev, &mpc52xx_gpt_attrib[i]);
-   if (err)
-   dev_err(gpt->dev, "error creating attribute %i\n", i);
-   }
-
-}
-
-#else /* defined(CONFIG_SYSFS) */
-static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *) { return 0; }
-#endif /* defined(CONFIG_SYSFS) */
-
 /* -
  * of_platform bus binding code
  */
@@ -395,7 +357,6 @@ static int __devinit mpc52xx_gpt_probe(struct of_device 
*ofdev,
 
dev_set_drvdata(&ofdev->dev, gpt);
 
-   mpc52xx_gpt_create_attribs(gpt);
mpc52xx_gpt_gpio_setup(gpt, ofdev->node);
mpc52xx_gpt_irq_setup(gpt, ofdev->node);
 

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev