Re: [PATCH] powerpc/archrandom: fix arch_get_random_seed_int()

2019-12-08 Thread Michael Ellerman 
On Wed, 2019-12-04 at 11:50:15 UTC, Ard Biesheuvel wrote:
> Commit 01c9348c7620ec65
> 
>   powerpc: Use hardware RNG for arch_get_random_seed_* not arch_get_random_*
> 
> updated arch_get_random_[int|long]() to be NOPs, and moved the hardware
> RNG backing to arch_get_random_seed_[int|long]() instead. However, it
> failed to take into account that arch_get_random_int() was implemented
> in terms of arch_get_random_long(), and so we ended up with a version
> of the former that is essentially a NOP as well.
> 
> Fix this by calling arch_get_random_seed_long() from
> arch_get_random_seed_int() instead.
> 
> Fixes: 01c9348c7620ec65 ("powerpc: Use hardware RNG for 
> arch_get_random_seed_* not arch_get_random_*")
> Signed-off-by: Ard Biesheuvel 

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/b6afd1234cf93aa0d71b4be4788c47534905f0be

cheers

[PATCH] powerpc/archrandom: fix arch_get_random_seed_int()

2019-12-04 Thread Ard Biesheuvel 
Commit 01c9348c7620ec65

  powerpc: Use hardware RNG for arch_get_random_seed_* not arch_get_random_*

updated arch_get_random_[int|long]() to be NOPs, and moved the hardware
RNG backing to arch_get_random_seed_[int|long]() instead. However, it
failed to take into account that arch_get_random_int() was implemented
in terms of arch_get_random_long(), and so we ended up with a version
of the former that is essentially a NOP as well.

Fix this by calling arch_get_random_seed_long() from
arch_get_random_seed_int() instead.

Fixes: 01c9348c7620ec65 ("powerpc: Use hardware RNG for arch_get_random_seed_* 
not arch_get_random_*")
Signed-off-by: Ard Biesheuvel 
---
 arch/powerpc/include/asm/archrandom.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/archrandom.h 
b/arch/powerpc/include/asm/archrandom.h
index 9c63b596e6ce..a09595f00cab 100644
--- a/arch/powerpc/include/asm/archrandom.h
+++ b/arch/powerpc/include/asm/archrandom.h
@@ -28,7 +28,7 @@ static inline int arch_get_random_seed_int(unsigned int *v)
unsigned long val;
int rc;
 
-   rc = arch_get_random_long();
+   rc = arch_get_random_seed_long();
if (rc)
*v = val;
 
-- 
2.17.1