On Mon, 2009-12-14 at 21:01 +0800, Li Yang wrote:
The function name of cpumask_clear_cpu was not correct.
Reported-by: Jin Qing b24...@freescale.com
Signed-off-by: Li Yang le...@freescale.com
---
This also implies that the CONFIG_HOTPLUG_CPU was never tested.
We are trying to add cpu hotplug for SMP suspend, but seeing the
following error(on 2.6.31 with context patches applied).
Any idea or suggestion?
Hotplug hass indeed never been tested on BookE as we lack a platform
that supports it :-)
As you log, it's useless since you haven't compiled verbose BUG info in
your kernel so the message indicating the file/line of the error is
absent.
Ben.
[ cut here ]
Badness at c00161b0 [verbose debug info unavailable]
NIP: c00161b0 LR: c0016190 CTR: c0038f7c
REGS: eec61e10 TRAP: 0700 Not tainted (2.6.31-00040-g7c92556-dirty)
MSR: 00021000 ME,CE CR: 22280028 XER:
TASK = eec54980[0] 'swapper' THREAD: eec6 CPU: 1
GPR00: 0001 eec61ec0 eec54980 c0562ea0 eecad500 0001
GPR08: 00eed000 0001 eecad67c 1ca8 00021000 eec60040
GPR16: eec54b0c c05208a0 c055fbe8 0001 c056 c0562ea0 0004
GPR24: eec6 0001 c0562e80 eec6 c05291f8 eecad500 c05291f8
NIP [c00161b0] switch_mmu_context+0x54/0x520
LR [c0016190] switch_mmu_context+0x34/0x520
Call Trace:
[eec61ec0] [c00709c8] tick_program_event+0x50/0x60 (unreliable)
[eec61f20] [c03beb54] schedule+0x2bc/0x7bc
[eec61fa0] [c0008a8c] cpu_idle+0x160/0x170
[eec61fc0] [c03c4be0] start_secondary+0x2d0/0x2e8
[eec61ff0] [c0001c9c] __secondary_start+0x30/0x84
Instruction dump:
543c0024 7ec3b378 833c0008 483ab1bd 813e0184 2f9d 39290001 913e0184
419e001c 813d0184 7d200034 5400d97e 0f00 3929 913d0184 3d20c055
MMU: More active contexts than CPUs ! (3 vs 2)
MMU: More active contexts than CPUs ! (3 vs 2)
arch/powerpc/mm/mmu_context_nohash.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/mm/mmu_context_nohash.c
b/arch/powerpc/mm/mmu_context_nohash.c
index be4f34c..1044a63 100644
--- a/arch/powerpc/mm/mmu_context_nohash.c
+++ b/arch/powerpc/mm/mmu_context_nohash.c
@@ -353,7 +353,7 @@ static int __cpuinit mmu_context_cpu_notify(struct
notifier_block *self,
read_lock(tasklist_lock);
for_each_process(p) {
if (p-mm)
- cpu_mask_clear_cpu(cpu, mm_cpumask(p-mm));
+ cpumask_clear_cpu(cpu, mm_cpumask(p-mm));
}
read_unlock(tasklist_lock);
break;
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
