** The Issue **
The ld_version() function seems to compute the wrong version value for
certain ld versions like the following:
$ ld --version GNU ld (GNU Binutils; SUSE Linux Enterprise 15)
2.37.20211103-150100.7.37
For input 2.37.20211103, the value computed is 20234803 which is way
more the value for a higher version like 2.39.0, that is 2390.
This issue was highlighted because with the above ld version, my powerpc
kernel build started failing with ld error: "unrecognized option
--no-warn-rwx-segments". This was caused due to the recent patch
579aee9fc594 added --no-warn-rwx-segments linker flag if the ld version
was greater than 2.39.
Due to the bug in ld_version(), my ld version (2.37.2003) was
wrongly calculated to be greater than 2.39 and the unsupported flag was
added.
** The fix **
If version is of the form x.y.z and length(z) == 8, then most probably
it is a date [mmdd]. As an approximation, discard the dd and
parts and keep the mm part in the version.
Signed-off-by: Ojaswin Mujoo
---
This is just an approximation since I'm not sure how common such release
versions for ld are and I didn't wan't to uneccassarily complicate the
logic. In case we want more accuracy we can try to use the last 4/5
digits to represent a more accurate date. Let me know if that would be
the preferred way.
PS: This issue also exists in ./scripts/ld-version.sh and I can look
into fixing that after this patch.
arch/powerpc/boot/wrapper | 4
1 file changed, 4 insertions(+)
diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
index af04cea82b94..af2688f79224 100755
--- a/arch/powerpc/boot/wrapper
+++ b/arch/powerpc/boot/wrapper
@@ -210,6 +210,10 @@ ld_version()
gsub(".*version ", "");
gsub("-.*", "");
split($1,a, ".");
+ if( length(a[3]) == "8" )
+ # a[3] is probably a date of format mmdd. An 8 digit number
will break
+ # the function so just keep the "mm" part as an approximation
+ a[3] = substr(a[3],5,2);
print a[1]*1 + a[2]*100 + a[3]*1;
exit
}'
--
2.31.1
