Re: [PATCH] powerpc: Look for "stdout-path" when setting up legacy consoles

2018-11-30 Thread Rob Herring
On Thu, Nov 29, 2018 at 9:54 PM Benjamin Herrenschmidt
 wrote:
>
> Commit 78e5dfea8 "powerpc: dts: replace 'linux,stdout-path' with 
> 'stdout-path'"
> broke the default console on a number of embedded PowerPC systems, because it
> failed to also update the code in arch/powerpc/kernel/legacy_serial.c to
> look for that property in addition to the old one.
>
> This fixes it.
>
> Signed-off-by: Benjamin Herrenschmidt 
> Fixes: 78e5dfea8 powerpc: dts: replace 'linux,stdout-path' with 'stdout-path'

Reviewed-by: Rob Herring 


[PATCH] powerpc: Look for "stdout-path" when setting up legacy consoles

2018-11-29 Thread Benjamin Herrenschmidt
Commit 78e5dfea8 "powerpc: dts: replace 'linux,stdout-path' with 'stdout-path'"
broke the default console on a number of embedded PowerPC systems, because it
failed to also update the code in arch/powerpc/kernel/legacy_serial.c to
look for that property in addition to the old one.

This fixes it.

Signed-off-by: Benjamin Herrenschmidt 
Fixes: 78e5dfea8 powerpc: dts: replace 'linux,stdout-path' with 'stdout-path'
---
diff --git a/arch/powerpc/kernel/legacy_serial.c 
b/arch/powerpc/kernel/legacy_serial.c
index 33b34a5..5b9dce1 100644
--- a/arch/powerpc/kernel/legacy_serial.c
+++ b/arch/powerpc/kernel/legacy_serial.c
@@ -372,6 +372,8 @@ void __init find_legacy_serial_ports(void)
 
/* Now find out if one of these is out firmware console */
path = of_get_property(of_chosen, "linux,stdout-path", NULL);
+   if (path == NULL)
+   path = of_get_property(of_chosen, "stdout-path", NULL);
if (path != NULL) {
stdout = of_find_node_by_path(path);
if (stdout)
@@ -595,8 +597,10 @@ static int __init check_legacy_serial_console(void)
/* We are getting a weird phandle from OF ... */
/* ... So use the full path instead */
name = of_get_property(of_chosen, "linux,stdout-path", NULL);
+   if (name == NULL)
+   name = of_get_property(of_chosen, "stdout-path", NULL);
if (name == NULL) {
-   DBG(" no linux,stdout-path !\n");
+   DBG(" no stdout-path !\n");
return -ENODEV;
}
prom_stdout = of_find_node_by_path(name);