Re: [PATCH] powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs

2008-10-08 Thread Benjamin Herrenschmidt 
On Wed, 2008-10-08 at 10:28 -0500, Timur Tabi wrote:
 On Fri, Sep 26, 2008 at 12:19 PM, Timur Tabi [EMAIL PROTECTED] wrote:
  The Kconfig files for PowerPC CHRP and PMAC support had default=y for some
  Kconfig options, and this caused support for CHRP and PMAC platforms to be
  enabled incorrectly for several platforms.  Fix the Kconfigs and the
  affected defconfigs.
 
 Ben,
 
 When you applied this patch, you removed the Kconfig changes.  Without
 those, doing a make xxx_defconfig will just add CONFIG_PPC_PMAC=y
 and CONFIG_PPC_CHRP=y to the .config!

Hrm. Yes, I removed those changes because I want to think more about
that aspect of things.

 $ make 83xx/mpc834x_itxgp_defconfig
   HOSTCC  scripts/basic/fixdep
   HOSTCC  scripts/basic/docproc
   HOSTCC  scripts/kconfig/conf.o
   HOSTCC  scripts/kconfig/kxgettext.o
   SHIPPED scripts/kconfig/zconf.tab.c
   SHIPPED scripts/kconfig/lex.zconf.c
   SHIPPED scripts/kconfig/zconf.hash.c
   HOSTCC  scripts/kconfig/zconf.tab.o
   HOSTLD  scripts/kconfig/conf
 #
 # configuration written to .config
 #
 $ grep CHRP .config
 CONFIG_PPC_CHRP=y
 
 So please apply my *original* patch.

yeah well, there's a consistency problem. If we remove default for these
we should remove default for all.

The bug I think is in your original patch in fact to just remove those
from .config rather than explicitely set them to not set.

I'm not going to remove the applied patch to avoid rebasing, it's
harmless to keep it in, please send another one that does the above.

Ben.

 

___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs

2008-10-08 Thread Timur Tabi 
Benjamin Herrenschmidt wrote:

 yeah well, there's a consistency problem. If we remove default for these
 we should remove default for all.

I only removed the default from the ones I knew were wrong.

 The bug I think is in your original patch in fact to just remove those
 from .config rather than explicitely set them to not set.

I did that because with the Kconfig changes, it's not necessary to set them to
not set, so it kept the patch smaller.

 I'm not going to remove the applied patch to avoid rebasing, it's
 harmless to keep it in, please send another one that does the above.

Ok.

-- 
Timur Tabi
Linux kernel developer at Freescale
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs

2008-10-06 Thread Timur Tabi 
On Fri, Sep 26, 2008 at 12:19 PM, Timur Tabi [EMAIL PROTECTED] wrote:
 The Kconfig files for PowerPC CHRP and PMAC support had default=y for some
 Kconfig options, and this caused support for CHRP and PMAC platforms to be
 enabled incorrectly for several platforms.  Fix the Kconfigs and the
 affected defconfigs.

 Signed-off-by: Timur Tabi [EMAIL PROTECTED]
 ---

 This patch is for 2.6.28.  Ben, please review and make sure I'm not being to
 conservative or too aggressive.  I don't know enough about CHRP and PMAC to
 be sure I'm doing this right.

Ping.

-- 
Timur Tabi
Linux kernel developer at Freescale
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs

2008-09-26 Thread Timur Tabi 
The Kconfig files for PowerPC CHRP and PMAC support had default=y for some
Kconfig options, and this caused support for CHRP and PMAC platforms to be
enabled incorrectly for several platforms.  Fix the Kconfigs and the
affected defconfigs.

Signed-off-by: Timur Tabi [EMAIL PROTECTED]
---

This patch is for 2.6.28.  Ben, please review and make sure I'm not being to
conservative or too aggressive.  I don't know enough about CHRP and PMAC to
be sure I'm doing this right.

 arch/powerpc/configs/83xx/asp8347_defconfig   |2 --
 arch/powerpc/configs/83xx/mpc8313_rdb_defconfig   |2 --
 arch/powerpc/configs/83xx/mpc8315_rdb_defconfig   |2 --
 arch/powerpc/configs/83xx/mpc832x_mds_defconfig   |2 --
 arch/powerpc/configs/83xx/mpc832x_rdb_defconfig   |2 --
 arch/powerpc/configs/83xx/mpc834x_itx_defconfig   |2 --
 arch/powerpc/configs/83xx/mpc834x_itxgp_defconfig |2 --
 arch/powerpc/configs/83xx/mpc834x_mds_defconfig   |2 --
 arch/powerpc/configs/83xx/mpc836x_mds_defconfig   |2 --
 arch/powerpc/configs/83xx/mpc836x_rdk_defconfig   |2 --
 arch/powerpc/configs/83xx/mpc837x_mds_defconfig   |2 --
 arch/powerpc/configs/83xx/mpc837x_rdb_defconfig   |2 --
 arch/powerpc/configs/83xx/sbc834x_defconfig   |2 --
 arch/powerpc/configs/86xx/mpc8610_hpcd_defconfig  |2 --
 arch/powerpc/configs/86xx/mpc8641_hpcn_defconfig  |2 --
 arch/powerpc/configs/86xx/sbc8641d_defconfig  |2 --
 arch/powerpc/configs/ep8248e_defconfig|2 --
 arch/powerpc/configs/mpc8272_ads_defconfig|2 --
 arch/powerpc/configs/mpc83xx_defconfig|2 --
 arch/powerpc/configs/pq2fads_defconfig|2 --
 arch/powerpc/platforms/chrp/Kconfig   |1 -
 arch/powerpc/platforms/powermac/Kconfig   |4 
 22 files changed, 0 insertions(+), 45 deletions(-)

diff --git a/arch/powerpc/configs/83xx/asp8347_defconfig 
b/arch/powerpc/configs/83xx/asp8347_defconfig
index 5e6780a..6638f5a 100644
--- a/arch/powerpc/configs/83xx/asp8347_defconfig
+++ b/arch/powerpc/configs/83xx/asp8347_defconfig
@@ -164,11 +164,9 @@ CONFIG_CLASSIC_RCU=y
 #
 CONFIG_PPC_MULTIPLATFORM=y
 CONFIG_CLASSIC32=y
-CONFIG_PPC_CHRP=y
 # CONFIG_MPC5121_ADS is not set
 # CONFIG_MPC5121_GENERIC is not set
 # CONFIG_PPC_MPC52xx is not set
-CONFIG_PPC_PMAC=y
 # CONFIG_PPC_CELL is not set
 # CONFIG_PPC_CELL_NATIVE is not set
 # CONFIG_PPC_82xx is not set
diff --git a/arch/powerpc/configs/83xx/mpc8313_rdb_defconfig 
b/arch/powerpc/configs/83xx/mpc8313_rdb_defconfig
index 2028337..df125f3 100644
--- a/arch/powerpc/configs/83xx/mpc8313_rdb_defconfig
+++ b/arch/powerpc/configs/83xx/mpc8313_rdb_defconfig
@@ -163,11 +163,9 @@ CONFIG_CLASSIC_RCU=y
 #
 CONFIG_PPC_MULTIPLATFORM=y
 CONFIG_CLASSIC32=y
-CONFIG_PPC_CHRP=y
 # CONFIG_MPC5121_ADS is not set
 # CONFIG_MPC5121_GENERIC is not set
 # CONFIG_PPC_MPC52xx is not set
-CONFIG_PPC_PMAC=y
 # CONFIG_PPC_CELL is not set
 # CONFIG_PPC_CELL_NATIVE is not set
 # CONFIG_PPC_82xx is not set
diff --git a/arch/powerpc/configs/83xx/mpc8315_rdb_defconfig 
b/arch/powerpc/configs/83xx/mpc8315_rdb_defconfig
index dd80eb0..6e0e08c 100644
--- a/arch/powerpc/configs/83xx/mpc8315_rdb_defconfig
+++ b/arch/powerpc/configs/83xx/mpc8315_rdb_defconfig
@@ -163,11 +163,9 @@ CONFIG_CLASSIC_RCU=y
 #
 CONFIG_PPC_MULTIPLATFORM=y
 CONFIG_CLASSIC32=y
-CONFIG_PPC_CHRP=y
 # CONFIG_MPC5121_ADS is not set
 # CONFIG_MPC5121_GENERIC is not set
 # CONFIG_PPC_MPC52xx is not set
-CONFIG_PPC_PMAC=y
 # CONFIG_PPC_CELL is not set
 # CONFIG_PPC_CELL_NATIVE is not set
 # CONFIG_PPC_82xx is not set
diff --git a/arch/powerpc/configs/83xx/mpc832x_mds_defconfig 
b/arch/powerpc/configs/83xx/mpc832x_mds_defconfig
index bdf50c8..d6e204a 100644
--- a/arch/powerpc/configs/83xx/mpc832x_mds_defconfig
+++ b/arch/powerpc/configs/83xx/mpc832x_mds_defconfig
@@ -163,11 +163,9 @@ CONFIG_CLASSIC_RCU=y
 #
 CONFIG_PPC_MULTIPLATFORM=y
 CONFIG_CLASSIC32=y
-CONFIG_PPC_CHRP=y
 # CONFIG_MPC5121_ADS is not set
 # CONFIG_MPC5121_GENERIC is not set
 # CONFIG_PPC_MPC52xx is not set
-CONFIG_PPC_PMAC=y
 # CONFIG_PPC_CELL is not set
 # CONFIG_PPC_CELL_NATIVE is not set
 # CONFIG_PPC_82xx is not set
diff --git a/arch/powerpc/configs/83xx/mpc832x_rdb_defconfig 
b/arch/powerpc/configs/83xx/mpc832x_rdb_defconfig
index 4eef8c9..1f3d343 100644
--- a/arch/powerpc/configs/83xx/mpc832x_rdb_defconfig
+++ b/arch/powerpc/configs/83xx/mpc832x_rdb_defconfig
@@ -163,11 +163,9 @@ CONFIG_CLASSIC_RCU=y
 #
 CONFIG_PPC_MULTIPLATFORM=y
 CONFIG_CLASSIC32=y
-CONFIG_PPC_CHRP=y
 # CONFIG_MPC5121_ADS is not set
 # CONFIG_MPC5121_GENERIC is not set
 # CONFIG_PPC_MPC52xx is not set
-CONFIG_PPC_PMAC=y
 # CONFIG_PPC_CELL is not set
 # CONFIG_PPC_CELL_NATIVE is not set
 # CONFIG_PPC_82xx is not set
diff --git a/arch/powerpc/configs/83xx/mpc834x_itx_defconfig 
b/arch/powerpc/configs/83xx/mpc834x_itx_defconfig
index 8d65139..4686c21 100644
--- a/arch/powerpc/configs/83xx/mpc834x_itx_defconfig
+++