Re: [PATCH] selftests: cachestat: Fix build warnings on ppc64

2024-05-29 Thread Shuah Khan 

On 5/20/24 21:01, Michael Ellerman wrote:

Fix warnings like:
   test_cachestat.c: In function ‘print_cachestat’:
   test_cachestat.c:30:38: warning: format ‘%llu’ expects argument of
   type ‘long long unsigned int’, but argument 2 has type ‘__u64’ {aka
   ‘long unsigned int’} [-Wformat=]

By switching to unsigned long long for u64 for ppc64 builds.

Signed-off-by: Michael Ellerman 
---
  tools/testing/selftests/cachestat/test_cachestat.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/cachestat/test_cachestat.c 
b/tools/testing/selftests/cachestat/test_cachestat.c
index b171fd53b004..632ab44737ec 100644
--- a/tools/testing/selftests/cachestat/test_cachestat.c
+++ b/tools/testing/selftests/cachestat/test_cachestat.c
@@ -1,5 +1,6 @@
  // SPDX-License-Identifier: GPL-2.0
  #define _GNU_SOURCE
+#define __SANE_USERSPACE_TYPES__ // Use ll64
  
  #include 

  #include 


Applied to linux-kselftest fixes for the next rc.

Michael, If you want to take this through, let me know, I can drop this.

thanks,
-- Shuah

[PATCH] selftests: cachestat: Fix build warnings on ppc64

2024-05-20 Thread Michael Ellerman 
Fix warnings like:
  test_cachestat.c: In function ‘print_cachestat’:
  test_cachestat.c:30:38: warning: format ‘%llu’ expects argument of
  type ‘long long unsigned int’, but argument 2 has type ‘__u64’ {aka
  ‘long unsigned int’} [-Wformat=]

By switching to unsigned long long for u64 for ppc64 builds.

Signed-off-by: Michael Ellerman 
---
 tools/testing/selftests/cachestat/test_cachestat.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/cachestat/test_cachestat.c 
b/tools/testing/selftests/cachestat/test_cachestat.c
index b171fd53b004..632ab44737ec 100644
--- a/tools/testing/selftests/cachestat/test_cachestat.c
+++ b/tools/testing/selftests/cachestat/test_cachestat.c
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 #define _GNU_SOURCE
+#define __SANE_USERSPACE_TYPES__ // Use ll64
 
 #include 
 #include 
-- 
2.45.1